Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Relax domain name checks in ResponseCookie

Browse Source 
Closes gh-23924
This commit is contained in:
Rossen Stoyanchev
2019-11-06 16:17:41 +00:00
parent 29599a93a4
commit 3a241b546f
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
spring-web/src/test/java/org/springframework/http/ResponseCookieTests.java
View File

@@ -66,4 +66,19 @@ public class ResponseCookieTests {
.hasMessageContaining("RFC2616 cookie value"));
}
@Test
public void domainChecks() {
Arrays.asList("abc", "abc.org", "abc-def.org", "abc3.org", ".abc.org")
.forEach(domain -> ResponseCookie.from("n", "v").domain(domain).build());
Arrays.asList("-abc.org", "abc.org.", "abc.org-", "-abc.org", "abc.org-")
.forEach(domain -> assertThatThrownBy(() -> ResponseCookie.from("n", "v").domain(domain).build())
.hasMessageContaining("Invalid first/last char"));
Arrays.asList("abc..org", "abc.-org", "abc-.org")
.forEach(domain -> assertThatThrownBy(() -> ResponseCookie.from("n", "v").domain(domain).build())
.hasMessageContaining("invalid cookie domain char"));
}
}