Allow AccessControl to determine visibility from a given type
This commit adapts AccessVisibility so that it can determine if the member or type signature is accessible from a given package. This lets implementers figure out if reflection is necessary without assuming that package private visibility is OK. Closes gh-29245
This commit is contained in:
Stephane Nicoll
@@ -0,0 +1,275 @@
|
||||
/*
|
||||
* Copyright 2002-2022 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* https://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package org.springframework.aot.generate;
|
||||
|
||||
import java.lang.reflect.Constructor;
|
||||
import java.lang.reflect.Executable;
|
||||
import java.lang.reflect.Field;
|
||||
import java.lang.reflect.Member;
|
||||
import java.lang.reflect.Method;
|
||||
import java.lang.reflect.Modifier;
|
||||
import java.util.Arrays;
|
||||
import java.util.HashSet;
|
||||
import java.util.Set;
|
||||
import java.util.function.IntFunction;
|
||||
|
||||
import org.springframework.core.ResolvableType;
|
||||
import org.springframework.javapoet.ClassName;
|
||||
import org.springframework.util.Assert;
|
||||
import org.springframework.util.ClassUtils;
|
||||
|
||||
/**
|
||||
* Determine the access control of a {@link Member} or type signature.
|
||||
*
|
||||
* @author Stephane Nicoll
|
||||
* @author Phillip Webb
|
||||
* @since 6.0
|
||||
*/
|
||||
public final class AccessControl {
|
||||
|
||||
private final Class<?> target;
|
||||
|
||||
private final Visibility visibility;
|
||||
|
||||
AccessControl(Class<?> target, Visibility visibility) {
|
||||
this.target = target;
|
||||
this.visibility = visibility;
|
||||
}
|
||||
|
||||
/**
|
||||
* Create an {@link AccessControl} for the given member. This considers the
|
||||
* member modifier, parameter types, return types and any enclosing classes.
|
||||
* The lowest overall {@link Visibility} is used.
|
||||
* @param member the source member
|
||||
* @return the {@link AccessControl} for the member
|
||||
*/
|
||||
public static AccessControl forMember(Member member) {
|
||||
return new AccessControl(member.getDeclaringClass(), Visibility.forMember(member));
|
||||
}
|
||||
|
||||
/**
|
||||
* Create an {@link AccessControl} for the given {@link ResolvableType}.
|
||||
* This considers the type itself as well as any generics.
|
||||
* @param resolvableType the source resolvable type
|
||||
* @return the {@link AccessControl} for the type
|
||||
*/
|
||||
public static AccessControl forResolvableType(ResolvableType resolvableType) {
|
||||
return new AccessControl(resolvableType.toClass(),
|
||||
Visibility.forResolvableType(resolvableType));
|
||||
}
|
||||
|
||||
/**
|
||||
* Create an {@link AccessControl} for the given {@link Class}.
|
||||
* @param type the source class
|
||||
* @return the {@link AccessControl} for the class
|
||||
*/
|
||||
public static AccessControl forClass(Class<?> type) {
|
||||
return new AccessControl(type, Visibility.forClass(type));
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns the lowest {@link AccessControl} from the given candidates.
|
||||
* @param candidates the candidates to check
|
||||
* @return the lowest {@link AccessControl} from the candidates
|
||||
*/
|
||||
public static AccessControl lowest(AccessControl... candidates) {
|
||||
int index = Visibility.lowestIndex(Arrays.stream(candidates)
|
||||
.map(AccessControl::getVisibility).toArray(Visibility[]::new));
|
||||
return candidates[index];
|
||||
}
|
||||
|
||||
/**
|
||||
* Return the lowest {@link Visibility} of this instance.
|
||||
* @return the visibility
|
||||
*/
|
||||
public Visibility getVisibility() {
|
||||
return this.visibility;
|
||||
}
|
||||
|
||||
/**
|
||||
* Return whether the member or type signature backed by ths instance is
|
||||
* accessible from any package.
|
||||
* @return {@code true} if it is public
|
||||
*/
|
||||
public boolean isPublic() {
|
||||
return this.visibility == Visibility.PUBLIC;
|
||||
}
|
||||
|
||||
/**
|
||||
* Specify whether the member or type signature backed by this instance is
|
||||
* accessible from the specified {@link ClassName}.
|
||||
* @param type the type to check
|
||||
* @return {@code true} if it is accessible
|
||||
*/
|
||||
public boolean isAccessibleFrom(ClassName type) {
|
||||
if (this.visibility == Visibility.PRIVATE) {
|
||||
return false;
|
||||
}
|
||||
if (this.visibility == Visibility.PUBLIC) {
|
||||
return true;
|
||||
}
|
||||
return this.target.getPackageName().equals(type.packageName());
|
||||
}
|
||||
|
||||
/**
|
||||
* Access visibility types as determined by the <a href=
|
||||
* "https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html">modifiers</a>
|
||||
* on a {@link Member} or {@link ResolvableType}.
|
||||
*/
|
||||
public enum Visibility {
|
||||
|
||||
/**
|
||||
* Public visibility. The member or type is visible to all classes.
|
||||
*/
|
||||
PUBLIC,
|
||||
|
||||
/**
|
||||
* Protected visibility. The member or type is only visible to classes
|
||||
* in the same package or subclasses.
|
||||
*/
|
||||
PROTECTED,
|
||||
|
||||
/**
|
||||
* Package-private visibility. The member or type is only visible to classes
|
||||
* in the same package.
|
||||
*/
|
||||
PACKAGE_PRIVATE,
|
||||
|
||||
/**
|
||||
* Private visibility. The member or type is not visible to other classes.
|
||||
*/
|
||||
PRIVATE;
|
||||
|
||||
|
||||
private static Visibility forMember(Member member) {
|
||||
Assert.notNull(member, "'member' must not be null");
|
||||
Visibility visibility = forModifiers(member.getModifiers());
|
||||
Visibility declaringClassVisibility = forClass(member.getDeclaringClass());
|
||||
visibility = lowest(visibility, declaringClassVisibility);
|
||||
if (visibility != PRIVATE) {
|
||||
if (member instanceof Field field) {
|
||||
Visibility fieldVisibility = forResolvableType(
|
||||
ResolvableType.forField(field));
|
||||
return lowest(visibility, fieldVisibility);
|
||||
}
|
||||
if (member instanceof Constructor<?> constructor) {
|
||||
Visibility parameterVisibility = forParameterTypes(constructor,
|
||||
i -> ResolvableType.forConstructorParameter(constructor, i));
|
||||
return lowest(visibility, parameterVisibility);
|
||||
}
|
||||
if (member instanceof Method method) {
|
||||
Visibility parameterVisibility = forParameterTypes(method,
|
||||
i -> ResolvableType.forMethodParameter(method, i));
|
||||
Visibility returnTypeVisibility = forResolvableType(
|
||||
ResolvableType.forMethodReturnType(method));
|
||||
return lowest(visibility, parameterVisibility, returnTypeVisibility);
|
||||
}
|
||||
}
|
||||
return PRIVATE;
|
||||
}
|
||||
|
||||
private static Visibility forResolvableType(ResolvableType resolvableType) {
|
||||
return forResolvableType(resolvableType, new HashSet<>());
|
||||
}
|
||||
|
||||
private static Visibility forResolvableType(ResolvableType resolvableType,
|
||||
Set<ResolvableType> seen) {
|
||||
if (!seen.add(resolvableType)) {
|
||||
return Visibility.PUBLIC;
|
||||
}
|
||||
Class<?> userClass = ClassUtils.getUserClass(resolvableType.toClass());
|
||||
ResolvableType userType = resolvableType.as(userClass);
|
||||
Visibility visibility = forClass(userType.toClass());
|
||||
for (ResolvableType generic : userType.getGenerics()) {
|
||||
visibility = lowest(visibility, forResolvableType(generic, seen));
|
||||
}
|
||||
return visibility;
|
||||
}
|
||||
|
||||
private static Visibility forParameterTypes(Executable executable,
|
||||
IntFunction<ResolvableType> resolvableTypeFactory) {
|
||||
Visibility visibility = Visibility.PUBLIC;
|
||||
Class<?>[] parameterTypes = executable.getParameterTypes();
|
||||
for (int i = 0; i < parameterTypes.length; i++) {
|
||||
ResolvableType type = resolvableTypeFactory.apply(i);
|
||||
visibility = lowest(visibility, forResolvableType(type));
|
||||
}
|
||||
return visibility;
|
||||
}
|
||||
|
||||
private static Visibility forClass(Class<?> clazz) {
|
||||
clazz = ClassUtils.getUserClass(clazz);
|
||||
Visibility visibility = forModifiers(clazz.getModifiers());
|
||||
if (clazz.isArray()) {
|
||||
visibility = lowest(visibility, forClass(clazz.getComponentType()));
|
||||
}
|
||||
Class<?> enclosingClass = clazz.getEnclosingClass();
|
||||
if (enclosingClass != null) {
|
||||
visibility = lowest(visibility, forClass(clazz.getEnclosingClass()));
|
||||
}
|
||||
return visibility;
|
||||
}
|
||||
|
||||
private static Visibility forModifiers(int modifiers) {
|
||||
if (Modifier.isPublic(modifiers)) {
|
||||
return PUBLIC;
|
||||
}
|
||||
if (Modifier.isProtected(modifiers)) {
|
||||
return PROTECTED;
|
||||
}
|
||||
if (Modifier.isPrivate(modifiers)) {
|
||||
return PRIVATE;
|
||||
}
|
||||
return PACKAGE_PRIVATE;
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns the lowest {@link Visibility} from the given candidates.
|
||||
* @param candidates the candidates to check
|
||||
* @return the lowest {@link Visibility} from the candidates
|
||||
*/
|
||||
static Visibility lowest(Visibility... candidates) {
|
||||
Visibility visibility = PUBLIC;
|
||||
for (Visibility candidate : candidates) {
|
||||
if (candidate.ordinal() > visibility.ordinal()) {
|
||||
visibility = candidate;
|
||||
}
|
||||
}
|
||||
return visibility;
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns the index of the lowest {@link Visibility} from the given
|
||||
* candidates.
|
||||
* @param candidates the candidates to check
|
||||
* @return the index of the lowest {@link Visibility} from the candidates
|
||||
*/
|
||||
static int lowestIndex(Visibility... candidates) {
|
||||
Visibility visibility = PUBLIC;
|
||||
int index = 0;
|
||||
for (int i = 0; i < candidates.length; i++) {
|
||||
Visibility candidate = candidates[i];
|
||||
if (candidate.ordinal() > visibility.ordinal()) {
|
||||
visibility = candidate;
|
||||
index = i;
|
||||
}
|
||||
}
|
||||
return index;
|
||||
}
|
||||
|
||||
}
|
||||
}
|
||||
@@ -1,184 +0,0 @@
|
||||
/*
|
||||
* Copyright 2002-2022 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* https://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package org.springframework.aot.generate;
|
||||
|
||||
import java.lang.reflect.Constructor;
|
||||
import java.lang.reflect.Executable;
|
||||
import java.lang.reflect.Field;
|
||||
import java.lang.reflect.Member;
|
||||
import java.lang.reflect.Method;
|
||||
import java.lang.reflect.Modifier;
|
||||
import java.util.HashSet;
|
||||
import java.util.Set;
|
||||
import java.util.function.IntFunction;
|
||||
|
||||
import org.springframework.core.ResolvableType;
|
||||
import org.springframework.util.Assert;
|
||||
import org.springframework.util.ClassUtils;
|
||||
|
||||
/**
|
||||
* Access visibility types as determined by the <a href=
|
||||
* "https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html">modifiers</a>
|
||||
* on a {@link Member} or {@link ResolvableType}.
|
||||
*
|
||||
* @author Phillip Webb
|
||||
* @author Stephane Nicoll
|
||||
* @since 6.0
|
||||
* @see #forMember(Member)
|
||||
* @see #forResolvableType(ResolvableType)
|
||||
*/
|
||||
public enum AccessVisibility {
|
||||
|
||||
/**
|
||||
* Public visibility. The member or type is visible to all classes.
|
||||
*/
|
||||
PUBLIC,
|
||||
|
||||
/**
|
||||
* Protected visibility. The member or type is only visible to subclasses.
|
||||
*/
|
||||
PROTECTED,
|
||||
|
||||
/**
|
||||
* Package-private visibility. The member or type is only visible to classes
|
||||
* in the same package.
|
||||
*/
|
||||
PACKAGE_PRIVATE,
|
||||
|
||||
/**
|
||||
* Private visibility. The member or type is not visible to other classes.
|
||||
*/
|
||||
PRIVATE;
|
||||
|
||||
|
||||
/**
|
||||
* Determine the {@link AccessVisibility} for the given member. This method
|
||||
* will consider the member modifier, parameter types, return types and any
|
||||
* enclosing classes. The lowest overall visibility will be returned.
|
||||
* @param member the source member
|
||||
* @return the {@link AccessVisibility} for the member
|
||||
*/
|
||||
public static AccessVisibility forMember(Member member) {
|
||||
Assert.notNull(member, "'member' must not be null");
|
||||
AccessVisibility visibility = forModifiers(member.getModifiers());
|
||||
AccessVisibility declaringClassVisibility = forClass(member.getDeclaringClass());
|
||||
visibility = lowest(visibility, declaringClassVisibility);
|
||||
if (visibility != PRIVATE) {
|
||||
if (member instanceof Field field) {
|
||||
AccessVisibility fieldVisibility = forResolvableType(
|
||||
ResolvableType.forField(field));
|
||||
return lowest(visibility, fieldVisibility);
|
||||
}
|
||||
if (member instanceof Constructor<?> constructor) {
|
||||
AccessVisibility parameterVisibility = forParameterTypes(constructor,
|
||||
i -> ResolvableType.forConstructorParameter(constructor, i));
|
||||
return lowest(visibility, parameterVisibility);
|
||||
}
|
||||
if (member instanceof Method method) {
|
||||
AccessVisibility parameterVisibility = forParameterTypes(method,
|
||||
i -> ResolvableType.forMethodParameter(method, i));
|
||||
AccessVisibility returnTypeVisibility = forResolvableType(
|
||||
ResolvableType.forMethodReturnType(method));
|
||||
return lowest(visibility, parameterVisibility, returnTypeVisibility);
|
||||
}
|
||||
}
|
||||
return PRIVATE;
|
||||
}
|
||||
|
||||
/**
|
||||
* Determine the {@link AccessVisibility} for the given
|
||||
* {@link ResolvableType}. This method will consider the type itself as well
|
||||
* as any generics.
|
||||
* @param resolvableType the source resolvable type
|
||||
* @return the {@link AccessVisibility} for the type
|
||||
*/
|
||||
public static AccessVisibility forResolvableType(ResolvableType resolvableType) {
|
||||
return forResolvableType(resolvableType, new HashSet<>());
|
||||
}
|
||||
|
||||
private static AccessVisibility forResolvableType(ResolvableType resolvableType,
|
||||
Set<ResolvableType> seen) {
|
||||
if (!seen.add(resolvableType)) {
|
||||
return AccessVisibility.PUBLIC;
|
||||
}
|
||||
Class<?> userClass = ClassUtils.getUserClass(resolvableType.toClass());
|
||||
ResolvableType userType = resolvableType.as(userClass);
|
||||
AccessVisibility visibility = forClass(userType.toClass());
|
||||
for (ResolvableType generic : userType.getGenerics()) {
|
||||
visibility = lowest(visibility, forResolvableType(generic, seen));
|
||||
}
|
||||
return visibility;
|
||||
}
|
||||
|
||||
private static AccessVisibility forParameterTypes(Executable executable,
|
||||
IntFunction<ResolvableType> resolvableTypeFactory) {
|
||||
AccessVisibility visibility = AccessVisibility.PUBLIC;
|
||||
Class<?>[] parameterTypes = executable.getParameterTypes();
|
||||
for (int i = 0; i < parameterTypes.length; i++) {
|
||||
ResolvableType type = resolvableTypeFactory.apply(i);
|
||||
visibility = lowest(visibility, forResolvableType(type));
|
||||
}
|
||||
return visibility;
|
||||
}
|
||||
|
||||
/**
|
||||
* Determine the {@link AccessVisibility} for the given {@link Class}.
|
||||
* @param clazz the source class
|
||||
* @return the {@link AccessVisibility} for the class
|
||||
*/
|
||||
public static AccessVisibility forClass(Class<?> clazz) {
|
||||
clazz = ClassUtils.getUserClass(clazz);
|
||||
AccessVisibility visibility = forModifiers(clazz.getModifiers());
|
||||
if (clazz.isArray()) {
|
||||
visibility = lowest(visibility, forClass(clazz.getComponentType()));
|
||||
}
|
||||
Class<?> enclosingClass = clazz.getEnclosingClass();
|
||||
if (enclosingClass != null) {
|
||||
visibility = lowest(visibility, forClass(clazz.getEnclosingClass()));
|
||||
}
|
||||
return visibility;
|
||||
}
|
||||
|
||||
private static AccessVisibility forModifiers(int modifiers) {
|
||||
if (Modifier.isPublic(modifiers)) {
|
||||
return PUBLIC;
|
||||
}
|
||||
if (Modifier.isProtected(modifiers)) {
|
||||
return PROTECTED;
|
||||
}
|
||||
if (Modifier.isPrivate(modifiers)) {
|
||||
return PRIVATE;
|
||||
}
|
||||
return PACKAGE_PRIVATE;
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns the lowest {@link AccessVisibility} put of the given candidates.
|
||||
* @param candidates the candidates to check
|
||||
* @return the lowest {@link AccessVisibility} from the candidates
|
||||
*/
|
||||
public static AccessVisibility lowest(AccessVisibility... candidates) {
|
||||
AccessVisibility visibility = PUBLIC;
|
||||
for (AccessVisibility candidate : candidates) {
|
||||
if (candidate.ordinal() > visibility.ordinal()) {
|
||||
visibility = candidate;
|
||||
}
|
||||
}
|
||||
return visibility;
|
||||
}
|
||||
|
||||
}
|
||||
@@ -0,0 +1,227 @@
|
||||
/*
|
||||
* Copyright 2002-2022 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* https://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package org.springframework.aot.generate;
|
||||
|
||||
import java.lang.reflect.Field;
|
||||
import java.lang.reflect.Member;
|
||||
import java.lang.reflect.Method;
|
||||
|
||||
import org.junit.jupiter.api.Test;
|
||||
|
||||
import org.springframework.aot.generate.AccessControl.Visibility;
|
||||
import org.springframework.core.ResolvableType;
|
||||
import org.springframework.core.testfixture.aot.generator.visibility.ProtectedGenericParameter;
|
||||
import org.springframework.core.testfixture.aot.generator.visibility.ProtectedParameter;
|
||||
import org.springframework.core.testfixture.aot.generator.visibility.PublicFactoryBean;
|
||||
import org.springframework.javapoet.ClassName;
|
||||
import org.springframework.util.ReflectionUtils;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
/**
|
||||
* Tests for {@link AccessControl}.
|
||||
*
|
||||
* @author Phillip Webb
|
||||
* @author Stephane Nicoll
|
||||
*/
|
||||
class AccessControlTests {
|
||||
|
||||
@Test
|
||||
void isAccessibleWhenPublicVisibilityInSamePackage() {
|
||||
AccessControl accessControl = new AccessControl(PublicClass.class, Visibility.PUBLIC);
|
||||
assertThat(accessControl.isAccessibleFrom(ClassName.get(PublicClass.class))).isTrue();
|
||||
}
|
||||
|
||||
@Test
|
||||
void isAccessibleWhenPublicVisibilityInDifferentPackage() {
|
||||
AccessControl accessControl = new AccessControl(PublicClass.class, Visibility.PUBLIC);
|
||||
assertThat(accessControl.isAccessibleFrom(ClassName.get(String.class))).isTrue();
|
||||
}
|
||||
|
||||
@Test
|
||||
void isAccessibleWhenProtectedVisibilityInSamePackage() {
|
||||
AccessControl accessControl = new AccessControl(PublicClass.class, Visibility.PROTECTED);
|
||||
assertThat(accessControl.isAccessibleFrom(ClassName.get(PublicClass.class))).isTrue();
|
||||
}
|
||||
|
||||
@Test
|
||||
void isAccessibleWhenProtectedVisibilityInDifferentPackage() {
|
||||
AccessControl accessControl = new AccessControl(PublicClass.class, Visibility.PROTECTED);
|
||||
assertThat(accessControl.isAccessibleFrom(ClassName.get(String.class))).isFalse();
|
||||
}
|
||||
|
||||
@Test
|
||||
void isAccessibleWhenPackagePrivateVisibilityInSamePackage() {
|
||||
AccessControl accessControl = new AccessControl(PublicClass.class, Visibility.PACKAGE_PRIVATE);
|
||||
assertThat(accessControl.isAccessibleFrom(ClassName.get(PublicClass.class))).isTrue();
|
||||
}
|
||||
|
||||
@Test
|
||||
void isAccessibleWhenPackagePrivateVisibilityInDifferentPackage() {
|
||||
AccessControl accessControl = new AccessControl(PublicClass.class, Visibility.PACKAGE_PRIVATE);
|
||||
assertThat(accessControl.isAccessibleFrom(ClassName.get(String.class))).isFalse();
|
||||
}
|
||||
|
||||
@Test
|
||||
void isAccessibleWhenPrivateVisibilityInSamePackage() {
|
||||
AccessControl accessControl = new AccessControl(PublicClass.class, Visibility.PRIVATE);
|
||||
assertThat(accessControl.isAccessibleFrom(ClassName.get(PublicClass.class))).isFalse();
|
||||
}
|
||||
|
||||
@Test
|
||||
void isAccessibleWhenPrivateVisibilityInDifferentPackage() {
|
||||
AccessControl accessControl = new AccessControl(PublicClass.class, Visibility.PRIVATE);
|
||||
assertThat(accessControl.isAccessibleFrom(ClassName.get(String.class))).isFalse();
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicConstructor() throws NoSuchMethodException {
|
||||
Member member = PublicClass.class.getConstructor();
|
||||
AccessControl accessControl = AccessControl.forMember(member);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PUBLIC);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPackagePrivateConstructor() {
|
||||
Member member = ProtectedAccessor.class.getDeclaredConstructors()[0];
|
||||
AccessControl accessControl = AccessControl.forMember(member);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPackagePrivateClassWithPublicConstructor() {
|
||||
Member member = PackagePrivateClass.class.getDeclaredConstructors()[0];
|
||||
AccessControl accessControl = AccessControl.forMember(member);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPackagePrivateClassWithPublicMethod() {
|
||||
Member member = method(PackagePrivateClass.class, "stringBean");
|
||||
AccessControl accessControl = AccessControl.forMember(member);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPackagePrivateConstructorParameter() {
|
||||
Member member = ProtectedParameter.class.getConstructors()[0];
|
||||
AccessControl accessControl = AccessControl.forMember(member);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPackagePrivateGenericOnConstructorParameter() {
|
||||
Member member = ProtectedGenericParameter.class.getConstructors()[0];
|
||||
AccessControl accessControl = AccessControl.forMember(member);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPackagePrivateMethod() {
|
||||
Member member = method(PublicClass.class, "getProtectedMethod");
|
||||
AccessControl accessControl = AccessControl.forMember(member);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPackagePrivateMethodReturnType() {
|
||||
Member member = method(ProtectedAccessor.class, "methodWithProtectedReturnType");
|
||||
AccessControl accessControl = AccessControl.forMember(member);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPackagePrivateMethodParameter() {
|
||||
Member member = method(ProtectedAccessor.class, "methodWithProtectedParameter",
|
||||
PackagePrivateClass.class);
|
||||
AccessControl accessControl = AccessControl.forMember(member);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPackagePrivateField() {
|
||||
Field member = field(PublicClass.class, "protectedField");
|
||||
AccessControl accessControl = AccessControl.forMember(member);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPublicFieldAndPackagePrivateFieldType() {
|
||||
Member member = field(PublicClass.class, "protectedClassField");
|
||||
AccessControl accessControl = AccessControl.forMember(member);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPrivateField() {
|
||||
Member member = field(PublicClass.class, "privateField");
|
||||
AccessControl accessControl = AccessControl.forMember(member);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPublicMethodAndPackagePrivateGenericOnReturnType() {
|
||||
Member member = method(PublicFactoryBean.class, "protectedTypeFactoryBean");
|
||||
AccessControl accessControl = AccessControl.forMember(member);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPackagePrivateArrayComponent() {
|
||||
Member member = field(PublicClass.class, "packagePrivateClasses");
|
||||
AccessControl accessControl = AccessControl.forMember(member);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forResolvableTypeWhenPackagePrivateGeneric() {
|
||||
ResolvableType resolvableType = PublicFactoryBean
|
||||
.resolveToProtectedGenericParameter();
|
||||
AccessControl accessControl = AccessControl.forResolvableType(resolvableType);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forResolvableTypeWhenRecursiveType() {
|
||||
ResolvableType resolvableType = ResolvableType
|
||||
.forClassWithGenerics(SelfReference.class, SelfReference.class);
|
||||
AccessControl accessControl = AccessControl.forResolvableType(resolvableType);
|
||||
assertThat(accessControl.getVisibility()).isEqualTo(Visibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
|
||||
private static Method method(Class<?> type, String name, Class<?>... parameterTypes) {
|
||||
Method method = ReflectionUtils.findMethod(type, name, parameterTypes);
|
||||
assertThat(method).isNotNull();
|
||||
return method;
|
||||
}
|
||||
|
||||
private static Field field(Class<?> type, String name) {
|
||||
Field field = ReflectionUtils.findField(type, name);
|
||||
assertThat(field).isNotNull();
|
||||
return field;
|
||||
}
|
||||
|
||||
static class SelfReference<T extends SelfReference<T>> {
|
||||
|
||||
@SuppressWarnings({ "unchecked", "unused" })
|
||||
T getThis() {
|
||||
return (T) this;
|
||||
}
|
||||
|
||||
}
|
||||
}
|
||||
@@ -1,175 +0,0 @@
|
||||
/*
|
||||
* Copyright 2002-2022 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* https://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
package org.springframework.aot.generate;
|
||||
|
||||
import java.lang.reflect.Field;
|
||||
import java.lang.reflect.Member;
|
||||
import java.lang.reflect.Method;
|
||||
|
||||
import org.junit.jupiter.api.Test;
|
||||
|
||||
import org.springframework.core.ResolvableType;
|
||||
import org.springframework.core.testfixture.aot.generator.visibility.ProtectedGenericParameter;
|
||||
import org.springframework.core.testfixture.aot.generator.visibility.ProtectedParameter;
|
||||
import org.springframework.core.testfixture.aot.generator.visibility.PublicFactoryBean;
|
||||
import org.springframework.util.ReflectionUtils;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
/**
|
||||
* Tests for {@link AccessVisibility}.
|
||||
*
|
||||
* @author Phillip Webb
|
||||
* @author Stephane Nicoll
|
||||
*/
|
||||
class AccessVisibilityTests {
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicConstructor() throws NoSuchMethodException {
|
||||
Member member = PublicClass.class.getConstructor();
|
||||
assertThat(AccessVisibility.forMember(member)).isEqualTo(AccessVisibility.PUBLIC);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPackagePrivateConstructor() {
|
||||
Member member = ProtectedAccessor.class.getDeclaredConstructors()[0];
|
||||
assertThat(AccessVisibility.forMember(member))
|
||||
.isEqualTo(AccessVisibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPackagePrivateClassWithPublicConstructor() {
|
||||
Member member = PackagePrivateClass.class.getDeclaredConstructors()[0];
|
||||
assertThat(AccessVisibility.forMember(member))
|
||||
.isEqualTo(AccessVisibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPackagePrivateClassWithPublicMethod() {
|
||||
Member member = method(PackagePrivateClass.class, "stringBean");
|
||||
assertThat(AccessVisibility.forMember(member))
|
||||
.isEqualTo(AccessVisibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPackagePrivateConstructorParameter() {
|
||||
Member member = ProtectedParameter.class.getConstructors()[0];
|
||||
assertThat(AccessVisibility.forMember(member))
|
||||
.isEqualTo(AccessVisibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPackagePrivateGenericOnConstructorParameter() {
|
||||
Member member = ProtectedGenericParameter.class.getConstructors()[0];
|
||||
assertThat(AccessVisibility.forMember(member))
|
||||
.isEqualTo(AccessVisibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPackagePrivateMethod() {
|
||||
Member member = method(PublicClass.class, "getProtectedMethod");
|
||||
assertThat(AccessVisibility.forMember(member))
|
||||
.isEqualTo(AccessVisibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPackagePrivateMethodReturnType() {
|
||||
Member member = method(ProtectedAccessor.class, "methodWithProtectedReturnType");
|
||||
assertThat(AccessVisibility.forMember(member))
|
||||
.isEqualTo(AccessVisibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPackagePrivateMethodParameter() {
|
||||
Member member = method(ProtectedAccessor.class, "methodWithProtectedParameter",
|
||||
PackagePrivateClass.class);
|
||||
assertThat(AccessVisibility.forMember(member))
|
||||
.isEqualTo(AccessVisibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPackagePrivateField() {
|
||||
Field member = field(PublicClass.class, "protectedField");
|
||||
assertThat(AccessVisibility.forMember(member))
|
||||
.isEqualTo(AccessVisibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPublicFieldAndPackagePrivateFieldType() {
|
||||
Member member = field(PublicClass.class, "protectedClassField");
|
||||
assertThat(AccessVisibility.forMember(member))
|
||||
.isEqualTo(AccessVisibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPublicMethodAndPackagePrivateGenericOnReturnType() {
|
||||
Member member = method(PublicFactoryBean.class, "protectedTypeFactoryBean");
|
||||
assertThat(AccessVisibility.forMember(member))
|
||||
.isEqualTo(AccessVisibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPackagePrivateArrayComponent() {
|
||||
Member member = field(PublicClass.class, "packagePrivateClasses");
|
||||
assertThat(AccessVisibility.forMember(member))
|
||||
.isEqualTo(AccessVisibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forResolvableTypeWhenPackagePrivateGeneric() {
|
||||
ResolvableType resolvableType = PublicFactoryBean
|
||||
.resolveToProtectedGenericParameter();
|
||||
assertThat(AccessVisibility.forResolvableType(resolvableType))
|
||||
.isEqualTo(AccessVisibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forResolvableTypeWhenRecursiveType() {
|
||||
ResolvableType resolvableType = ResolvableType
|
||||
.forClassWithGenerics(SelfReference.class, SelfReference.class);
|
||||
assertThat(AccessVisibility.forResolvableType(resolvableType))
|
||||
.isEqualTo(AccessVisibility.PACKAGE_PRIVATE);
|
||||
}
|
||||
|
||||
@Test
|
||||
void forMemberWhenPublicClassWithPrivateField() {
|
||||
Member member = field(PublicClass.class, "privateField");
|
||||
assertThat(AccessVisibility.forMember(member))
|
||||
.isEqualTo(AccessVisibility.PRIVATE);
|
||||
}
|
||||
|
||||
private static Method method(Class<?> type, String name, Class<?>... parameterTypes) {
|
||||
Method method = ReflectionUtils.findMethod(type, name, parameterTypes);
|
||||
assertThat(method).isNotNull();
|
||||
return method;
|
||||
}
|
||||
|
||||
private static Field field(Class<?> type, String name) {
|
||||
Field field = ReflectionUtils.findField(type, name);
|
||||
assertThat(field).isNotNull();
|
||||
return field;
|
||||
}
|
||||
|
||||
static class SelfReference<T extends SelfReference<T>> {
|
||||
|
||||
@SuppressWarnings("unchecked")
|
||||
T getThis() {
|
||||
return (T) this;
|
||||
}
|
||||
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user