Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BindingPoint to ConversionPoint, javadoc

Browse Source
This commit is contained in:
Keith Donald
2009-05-15 20:32:23 +00:00
parent 2ede4d2731
commit 46c9a003eb
40 changed files with 229 additions and 197 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
org.springframework.expression/src/main/java/org/springframework/expression/TypeConverter.java
View File

@@ -16,7 +16,7 @@
package org.springframework.expression;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
/**
* A type converter can convert values between different types encountered
@@ -48,7 +48,7 @@ public interface TypeConverter {
* @return the converted value
* @throws EvaluationException if conversion is not possible
*/
Object convertValue(Object value, BindingPoint typeDescriptor) throws EvaluationException;
Object convertValue(Object value, ConversionPoint typeDescriptor) throws EvaluationException;
/**
* Return true if the type converter can convert the specified type to the desired target type.
@@ -64,6 +64,6 @@ public interface TypeConverter {
* @param typeDescriptor a type descriptor that supplies extra information about the requested result type
* @return true if that conversion can be performed
*/
boolean canConvert(Class<?> sourceType, BindingPoint typeDescriptor);
boolean canConvert(Class<?> sourceType, ConversionPoint typeDescriptor);
}

12
org.springframework.expression/src/main/java/org/springframework/expression/TypedValue.java
View File

@@ -15,7 +15,7 @@
*/
package org.springframework.expression;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
/**
* Encapsulates an object and a type descriptor that describes it.
@@ -28,9 +28,9 @@ import org.springframework.core.convert.BindingPoint;
public class TypedValue {
private Object value;
private BindingPoint typeDescriptor;
private ConversionPoint typeDescriptor;
public static final TypedValue NULL_TYPED_VALUE = new TypedValue(null, BindingPoint.NULL_TYPE_DESCRIPTOR);
public static final TypedValue NULL_TYPED_VALUE = new TypedValue(null, ConversionPoint.NULL);
/**
* Create a TypedValue for a simple object. The type descriptor is inferred
@@ -39,7 +39,7 @@ public class TypedValue {
*/
public TypedValue(Object value) {
this.value = value;
this.typeDescriptor = BindingPoint.forObject(value);
this.typeDescriptor = ConversionPoint.forObject(value);
}
/**
@@ -47,7 +47,7 @@ public class TypedValue {
* @param value the object value
* @param typeDescriptor a type descriptor describing the type of the value
*/
public TypedValue(Object value, BindingPoint typeDescriptor) {
public TypedValue(Object value, ConversionPoint typeDescriptor) {
this.value = value;
this.typeDescriptor = typeDescriptor;
}
@@ -56,7 +56,7 @@ public class TypedValue {
return this.value;
}
public BindingPoint getTypeDescriptor() {
public ConversionPoint getTypeDescriptor() {
return this.typeDescriptor;
}

10
org.springframework.expression/src/main/java/org/springframework/expression/spel/ExpressionState.java
View File

@@ -20,7 +20,7 @@ import java.util.List;
import java.util.Map;
import java.util.Stack;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
import org.springframework.expression.EvaluationContext;
import org.springframework.expression.EvaluationException;
import org.springframework.expression.Operation;
@@ -99,7 +99,7 @@ public class ExpressionState {
if (value==null) {
return TypedValue.NULL_TYPED_VALUE;
} else {
return new TypedValue(value,BindingPoint.forObject(value));
return new TypedValue(value,ConversionPoint.forObject(value));
}
}
@@ -111,11 +111,11 @@ public class ExpressionState {
return this.relatedContext.getTypeLocator().findType(type);
}
public Object convertValue(Object value, BindingPoint targetTypeDescriptor) throws EvaluationException {
public Object convertValue(Object value, ConversionPoint targetTypeDescriptor) throws EvaluationException {
return this.relatedContext.getTypeConverter().convertValue(value, targetTypeDescriptor);
}
public Object convertValue(TypedValue value, BindingPoint targetTypeDescriptor) throws EvaluationException {
public Object convertValue(TypedValue value, ConversionPoint targetTypeDescriptor) throws EvaluationException {
return this.relatedContext.getTypeConverter().convertValue(value.getValue(), targetTypeDescriptor);
}
@@ -153,7 +153,7 @@ public class ExpressionState {
OperatorOverloader overloader = this.relatedContext.getOperatorOverloader();
if (overloader.overridesOperation(op, left, right)) {
Object returnValue = overloader.operate(op, left, right);
return new TypedValue(returnValue,BindingPoint.forObject(returnValue));
return new TypedValue(returnValue,ConversionPoint.forObject(returnValue));
}
else {
String leftType = (left==null?"null":left.getClass().getName());

24
org.springframework.expression/src/main/java/org/springframework/expression/spel/ast/CommonTypeDescriptors.java
View File

@@ -15,7 +15,7 @@
*/
package org.springframework.expression.spel.ast;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
/**
* @author Andy Clement
@@ -23,16 +23,16 @@ import org.springframework.core.convert.BindingPoint;
*/
public interface CommonTypeDescriptors {
// TODO push into TypeDescriptor?
static BindingPoint BOOLEAN_TYPE_DESCRIPTOR = BindingPoint.valueOf(Boolean.class);
static BindingPoint INTEGER_TYPE_DESCRIPTOR = BindingPoint.valueOf(Integer.class);
static BindingPoint CHARACTER_TYPE_DESCRIPTOR = BindingPoint.valueOf(Character.class);
static BindingPoint LONG_TYPE_DESCRIPTOR = BindingPoint.valueOf(Long.class);
static BindingPoint SHORT_TYPE_DESCRIPTOR = BindingPoint.valueOf(Short.class);
static BindingPoint BYTE_TYPE_DESCRIPTOR = BindingPoint.valueOf(Byte.class);
static BindingPoint FLOAT_TYPE_DESCRIPTOR = BindingPoint.valueOf(Float.class);
static BindingPoint DOUBLE_TYPE_DESCRIPTOR = BindingPoint.valueOf(Double.class);
static BindingPoint STRING_TYPE_DESCRIPTOR = BindingPoint.valueOf(String.class);
static BindingPoint CLASS_TYPE_DESCRIPTOR = BindingPoint.valueOf(Class.class);
static BindingPoint OBJECT_TYPE_DESCRIPTOR = BindingPoint.valueOf(Object.class);
static ConversionPoint BOOLEAN_TYPE_DESCRIPTOR = ConversionPoint.valueOf(Boolean.class);
static ConversionPoint INTEGER_TYPE_DESCRIPTOR = ConversionPoint.valueOf(Integer.class);
static ConversionPoint CHARACTER_TYPE_DESCRIPTOR = ConversionPoint.valueOf(Character.class);
static ConversionPoint LONG_TYPE_DESCRIPTOR = ConversionPoint.valueOf(Long.class);
static ConversionPoint SHORT_TYPE_DESCRIPTOR = ConversionPoint.valueOf(Short.class);
static ConversionPoint BYTE_TYPE_DESCRIPTOR = ConversionPoint.valueOf(Byte.class);
static ConversionPoint FLOAT_TYPE_DESCRIPTOR = ConversionPoint.valueOf(Float.class);
static ConversionPoint DOUBLE_TYPE_DESCRIPTOR = ConversionPoint.valueOf(Double.class);
static ConversionPoint STRING_TYPE_DESCRIPTOR = ConversionPoint.valueOf(String.class);
static ConversionPoint CLASS_TYPE_DESCRIPTOR = ConversionPoint.valueOf(Class.class);
static ConversionPoint OBJECT_TYPE_DESCRIPTOR = ConversionPoint.valueOf(Object.class);
}

4
org.springframework.expression/src/main/java/org/springframework/expression/spel/ast/FunctionReference.java
View File

@@ -22,7 +22,7 @@ import java.lang.reflect.Modifier;
import org.antlr.runtime.Token;
import org.springframework.core.MethodParameter;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
import org.springframework.expression.EvaluationException;
import org.springframework.expression.TypeConverter;
import org.springframework.expression.TypedValue;
@@ -104,7 +104,7 @@ public class FunctionReference extends SpelNodeImpl {
try {
ReflectionUtils.makeAccessible(m);
Object result = m.invoke(m.getClass(), functionArgs);
return new TypedValue(result, new BindingPoint(new MethodParameter(m,-1)));
return new TypedValue(result, new ConversionPoint(new MethodParameter(m,-1)));
} catch (IllegalArgumentException e) {
throw new SpelException(getCharPositionInLine(), e, SpelMessages.EXCEPTION_DURING_FUNCTION_CALL, name, e
.getMessage());

22
org.springframework.expression/src/main/java/org/springframework/expression/spel/ast/Indexer.java
View File

@@ -21,7 +21,7 @@ import java.util.List;
import java.util.Map;
import org.antlr.runtime.Token;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
import org.springframework.expression.EvaluationException;
import org.springframework.expression.TypedValue;
import org.springframework.expression.spel.ExpressionState;
@@ -47,15 +47,15 @@ public class Indexer extends SpelNodeImpl {
public TypedValue getValueInternal(ExpressionState state) throws EvaluationException {
TypedValue context = state.getActiveContextObject();
Object targetObject = context.getValue();
BindingPoint targetObjectTypeDescriptor = context.getTypeDescriptor();
ConversionPoint targetObjectTypeDescriptor = context.getTypeDescriptor();
TypedValue indexValue = getChild(0).getValueInternal(state);
Object index = indexValue.getValue();
// Indexing into a Map
if (targetObject instanceof Map) {
Object possiblyConvertedKey = state.convertValue(indexValue,BindingPoint.valueOf(targetObjectTypeDescriptor.getMapKeyType()));
Object possiblyConvertedKey = state.convertValue(indexValue,ConversionPoint.valueOf(targetObjectTypeDescriptor.getMapKeyType()));
Object o = ((Map<?, ?>) targetObject).get(possiblyConvertedKey);
return new TypedValue(o,BindingPoint.valueOf(targetObjectTypeDescriptor.getMapValueType()));
return new TypedValue(o,ConversionPoint.valueOf(targetObjectTypeDescriptor.getMapValueType()));
}
int idx = (Integer)state.convertValue(index, INTEGER_TYPE_DESCRIPTOR);
@@ -65,7 +65,7 @@ public class Indexer extends SpelNodeImpl {
}
if (targetObject.getClass().isArray()) {
return new TypedValue(accessArrayElement(targetObject, idx),BindingPoint.valueOf(targetObjectTypeDescriptor.getElementType()));
return new TypedValue(accessArrayElement(targetObject, idx),ConversionPoint.valueOf(targetObjectTypeDescriptor.getElementType()));
} else if (targetObject instanceof Collection) {
Collection<?> c = (Collection<?>) targetObject;
if (idx >= c.size()) {
@@ -74,7 +74,7 @@ public class Indexer extends SpelNodeImpl {
int pos = 0;
for (Object o : c) {
if (pos == idx) {
return new TypedValue(o,BindingPoint.valueOf(targetObjectTypeDescriptor.getElementType()));
return new TypedValue(o,ConversionPoint.valueOf(targetObjectTypeDescriptor.getElementType()));
}
pos++;
}
@@ -99,7 +99,7 @@ public class Indexer extends SpelNodeImpl {
public void setValue(ExpressionState state, Object newValue) throws EvaluationException {
TypedValue contextObject = state.getActiveContextObject();
Object targetObject = contextObject.getValue();
BindingPoint targetObjectTypeDescriptor = contextObject.getTypeDescriptor();
ConversionPoint targetObjectTypeDescriptor = contextObject.getTypeDescriptor();
TypedValue index = getChild(0).getValueInternal(state);
if (targetObject == null) {
@@ -108,8 +108,8 @@ public class Indexer extends SpelNodeImpl {
// Indexing into a Map
if (targetObjectTypeDescriptor.isMap()) {
Map map = (Map)targetObject;
Object possiblyConvertedKey = state.convertValue(index.getValue(),BindingPoint.valueOf(targetObjectTypeDescriptor.getMapKeyType()));
Object possiblyConvertedValue = state.convertValue(newValue,BindingPoint.valueOf(targetObjectTypeDescriptor.getMapValueType()));
Object possiblyConvertedKey = state.convertValue(index.getValue(),ConversionPoint.valueOf(targetObjectTypeDescriptor.getMapKeyType()));
Object possiblyConvertedValue = state.convertValue(newValue,ConversionPoint.valueOf(targetObjectTypeDescriptor.getMapValueType()));
map.put(possiblyConvertedKey,possiblyConvertedValue);
return;
}
@@ -125,7 +125,7 @@ public class Indexer extends SpelNodeImpl {
}
if (targetObject instanceof List) {
List list = (List)targetObject;
Object possiblyConvertedValue = state.convertValue(newValue,BindingPoint.valueOf(targetObjectTypeDescriptor.getElementType()));
Object possiblyConvertedValue = state.convertValue(newValue,ConversionPoint.valueOf(targetObjectTypeDescriptor.getElementType()));
list.set(idx,possiblyConvertedValue);
} else {
throw new SpelException(SpelMessages.INDEXING_NOT_SUPPORTED_FOR_TYPE, contextObject.getClass().getName());
@@ -185,7 +185,7 @@ public class Indexer extends SpelNodeImpl {
} else {
Object[] array = (Object[]) ctx;
checkAccess(array.length, idx);
array[idx] = state.convertValue(newValue, BindingPoint.valueOf(clazz));
array[idx] = state.convertValue(newValue, ConversionPoint.valueOf(clazz));
}
}

4
org.springframework.expression/src/main/java/org/springframework/expression/spel/ast/OperatorDivide.java
View File

@@ -17,7 +17,7 @@
package org.springframework.expression.spel.ast;
import org.antlr.runtime.Token;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
import org.springframework.expression.EvaluationException;
import org.springframework.expression.Operation;
import org.springframework.expression.TypedValue;
@@ -56,7 +56,7 @@ public class OperatorDivide extends Operator {
}
}
Object result = state.operate(Operation.DIVIDE, operandOne, operandTwo);
return new TypedValue(result,BindingPoint.forObject(result));
return new TypedValue(result,ConversionPoint.forObject(result));
}
}

8
org.springframework.expression/src/main/java/org/springframework/expression/spel/ast/Projection.java
View File

@@ -22,7 +22,7 @@ import java.util.List;
import java.util.Map;
import org.antlr.runtime.Token;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
import org.springframework.expression.EvaluationException;
import org.springframework.expression.TypedValue;
import org.springframework.expression.spel.ExpressionState;
@@ -60,13 +60,13 @@ public class Projection extends SpelNodeImpl {
List<Object> result = new ArrayList<Object>();
for (Map.Entry entry : mapdata.entrySet()) {
try {
state.pushActiveContextObject(new TypedValue(entry,BindingPoint.valueOf(Map.Entry.class)));
state.pushActiveContextObject(new TypedValue(entry,ConversionPoint.valueOf(Map.Entry.class)));
result.add(getChild(0).getValueInternal(state).getValue());
} finally {
state.popActiveContextObject();
}
}
return new TypedValue(result,BindingPoint.valueOf(List.class)); // TODO unable to build correct type descriptor
return new TypedValue(result,ConversionPoint.valueOf(List.class)); // TODO unable to build correct type descriptor
} else if (operand instanceof List) {
List<Object> data = new ArrayList<Object>();
data.addAll((Collection<?>) operand);
@@ -74,7 +74,7 @@ public class Projection extends SpelNodeImpl {
int idx = 0;
for (Object element : data) {
try {
state.pushActiveContextObject(new TypedValue(element,BindingPoint.valueOf(op.getTypeDescriptor().getType())));
state.pushActiveContextObject(new TypedValue(element,ConversionPoint.valueOf(op.getTypeDescriptor().getType())));
state.enterScope("index", idx);
result.add(getChild(0).getValueInternal(state).getValue());
} finally {

14
org.springframework.expression/src/main/java/org/springframework/expression/spel/ast/Selection.java
View File

@@ -23,7 +23,7 @@ import java.util.List;
import java.util.Map;
import org.antlr.runtime.Token;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
import org.springframework.expression.EvaluationException;
import org.springframework.expression.TypedValue;
import org.springframework.expression.spel.ExpressionState;
@@ -66,7 +66,7 @@ public class Selection extends SpelNodeImpl {
for (Map.Entry entry : mapdata.entrySet()) {
try {
lastKey = entry.getKey();
TypedValue kvpair = new TypedValue(entry,BindingPoint.valueOf(Map.Entry.class));
TypedValue kvpair = new TypedValue(entry,ConversionPoint.valueOf(Map.Entry.class));
state.pushActiveContextObject(kvpair);
Object o = selectionCriteria.getValueInternal(state).getValue();
if (o instanceof Boolean) {
@@ -86,13 +86,13 @@ public class Selection extends SpelNodeImpl {
}
}
if ((variant == FIRST || variant == LAST) && result.size() == 0) {
return new TypedValue(null,BindingPoint.NULL_TYPE_DESCRIPTOR);
return new TypedValue(null,ConversionPoint.NULL);
}
if (variant == LAST) {
Map resultMap = new HashMap();
Object lastValue = result.get(lastKey);
resultMap.put(lastKey,lastValue);
return new TypedValue(resultMap,BindingPoint.valueOf(Map.class));
return new TypedValue(resultMap,ConversionPoint.valueOf(Map.class));
}
return new TypedValue(result,op.getTypeDescriptor());
} else if (operand instanceof Collection) {
@@ -102,13 +102,13 @@ public class Selection extends SpelNodeImpl {
int idx = 0;
for (Object element : data) {
try {
state.pushActiveContextObject(new TypedValue(element,BindingPoint.valueOf(op.getTypeDescriptor().getElementType())));
state.pushActiveContextObject(new TypedValue(element,ConversionPoint.valueOf(op.getTypeDescriptor().getElementType())));
state.enterScope("index", idx);
Object o = selectionCriteria.getValueInternal(state).getValue();
if (o instanceof Boolean) {
if (((Boolean) o).booleanValue() == true) {
if (variant == FIRST) {
return new TypedValue(element,BindingPoint.valueOf(op.getTypeDescriptor().getElementType()));
return new TypedValue(element,ConversionPoint.valueOf(op.getTypeDescriptor().getElementType()));
}
result.add(element);
}
@@ -126,7 +126,7 @@ public class Selection extends SpelNodeImpl {
return TypedValue.NULL_TYPED_VALUE;
}
if (variant == LAST) {
return new TypedValue(result.get(result.size() - 1),BindingPoint.valueOf(op.getTypeDescriptor().getElementType()));
return new TypedValue(result.get(result.size() - 1),ConversionPoint.valueOf(op.getTypeDescriptor().getElementType()));
}
return new TypedValue(result,op.getTypeDescriptor());
} else {

4
org.springframework.expression/src/main/java/org/springframework/expression/spel/support/ReflectiveConstructorExecutor.java
View File

@@ -18,7 +18,7 @@ package org.springframework.expression.spel.support;
import java.lang.reflect.Constructor;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
import org.springframework.expression.AccessException;
import org.springframework.expression.ConstructorExecutor;
import org.springframework.expression.EvaluationContext;
@@ -56,7 +56,7 @@ class ReflectiveConstructorExecutor implements ConstructorExecutor {
if (!c.isAccessible()) {
c.setAccessible(true);
}
return new TypedValue(c.newInstance(arguments),BindingPoint.valueOf(c.getClass()));
return new TypedValue(c.newInstance(arguments),ConversionPoint.valueOf(c.getClass()));
} catch (Exception ex) {
throw new AccessException("Problem invoking constructor: " + c, ex);
}

4
org.springframework.expression/src/main/java/org/springframework/expression/spel/support/ReflectiveMethodExecutor.java
View File

@@ -19,7 +19,7 @@ package org.springframework.expression.spel.support;
import java.lang.reflect.Method;
import org.springframework.core.MethodParameter;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
import org.springframework.expression.AccessException;
import org.springframework.expression.EvaluationContext;
import org.springframework.expression.MethodExecutor;
@@ -55,7 +55,7 @@ class ReflectiveMethodExecutor implements MethodExecutor {
arguments = ReflectionHelper.setupArgumentsForVarargsInvocation(this.method.getParameterTypes(), arguments);
}
ReflectionUtils.makeAccessible(this.method);
return new TypedValue(this.method.invoke(target, arguments), new BindingPoint(new MethodParameter(method,-1)));
return new TypedValue(this.method.invoke(target, arguments), new ConversionPoint(new MethodParameter(method,-1)));
} catch (Exception ex) {
throw new AccessException("Problem invoking method: " + this.method, ex);
}

26
org.springframework.expression/src/main/java/org/springframework/expression/spel/support/ReflectivePropertyResolver.java
View File

@@ -25,7 +25,7 @@ import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import org.springframework.core.MethodParameter;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
import org.springframework.expression.AccessException;
import org.springframework.expression.EvaluationContext;
import org.springframework.expression.EvaluationException;
@@ -48,7 +48,7 @@ public class ReflectivePropertyResolver implements PropertyAccessor {
protected final Map<CacheKey, Member> writerCache = new ConcurrentHashMap<CacheKey, Member>();
protected final Map<CacheKey, BindingPoint> typeDescriptorCache = new ConcurrentHashMap<CacheKey,BindingPoint>();
protected final Map<CacheKey, ConversionPoint> typeDescriptorCache = new ConcurrentHashMap<CacheKey,ConversionPoint>();
/**
* @return null which means this is a general purpose accessor
@@ -72,14 +72,14 @@ public class ReflectivePropertyResolver implements PropertyAccessor {
Method method = findGetterForProperty(name, type, target instanceof Class);
if (method != null) {
this.readerCache.put(cacheKey, method);
this.typeDescriptorCache.put(cacheKey, new BindingPoint(new MethodParameter(method,-1)));
this.typeDescriptorCache.put(cacheKey, new ConversionPoint(new MethodParameter(method,-1)));
return true;
}
else {
Field field = findField(name, type, target instanceof Class);
if (field != null) {
this.readerCache.put(cacheKey, field);
this.typeDescriptorCache.put(cacheKey, new BindingPoint(field));
this.typeDescriptorCache.put(cacheKey, new ConversionPoint(field));
return true;
}
}
@@ -96,7 +96,7 @@ public class ReflectivePropertyResolver implements PropertyAccessor {
if (target instanceof Class) {
throw new AccessException("Cannot access length on array class itself");
}
return new TypedValue(Array.getLength(target),BindingPoint.valueOf(Integer.TYPE));
return new TypedValue(Array.getLength(target),ConversionPoint.valueOf(Integer.TYPE));
}
CacheKey cacheKey = new CacheKey(type, name);
@@ -114,7 +114,7 @@ public class ReflectivePropertyResolver implements PropertyAccessor {
if (method != null) {
try {
ReflectionUtils.makeAccessible(method);
BindingPoint resultTypeDescriptor = new BindingPoint(new MethodParameter(method,-1));
ConversionPoint resultTypeDescriptor = new ConversionPoint(new MethodParameter(method,-1));
return new TypedValue(method.invoke(target),resultTypeDescriptor);
}
catch (Exception ex) {
@@ -135,7 +135,7 @@ public class ReflectivePropertyResolver implements PropertyAccessor {
if (field != null) {
try {
ReflectionUtils.makeAccessible(field);
return new TypedValue(field.get(target),new BindingPoint(field));
return new TypedValue(field.get(target),new ConversionPoint(field));
}
catch (Exception ex) {
throw new AccessException("Unable to access field: " + name, ex);
@@ -158,14 +158,14 @@ public class ReflectivePropertyResolver implements PropertyAccessor {
Method method = findSetterForProperty(name, type, target instanceof Class);
if (method != null) {
this.writerCache.put(cacheKey, method);
this.typeDescriptorCache.put(cacheKey, new BindingPoint(new MethodParameter(method,0)));
this.typeDescriptorCache.put(cacheKey, new ConversionPoint(new MethodParameter(method,0)));
return true;
}
else {
Field field = findField(name, type, target instanceof Class);
if (field != null) {
this.writerCache.put(cacheKey, field);
this.typeDescriptorCache.put(cacheKey, new BindingPoint(field));
this.typeDescriptorCache.put(cacheKey, new ConversionPoint(field));
return true;
}
}
@@ -179,7 +179,7 @@ public class ReflectivePropertyResolver implements PropertyAccessor {
Class<?> type = (target instanceof Class ? (Class<?>) target : target.getClass());
Object possiblyConvertedNewValue = newValue;
BindingPoint typeDescriptor = getTypeDescriptor(context, target, name);
ConversionPoint typeDescriptor = getTypeDescriptor(context, target, name);
if (typeDescriptor != null) {
try {
possiblyConvertedNewValue = context.getTypeConverter().convertValue(newValue, typeDescriptor);
@@ -236,17 +236,17 @@ public class ReflectivePropertyResolver implements PropertyAccessor {
throw new AccessException("Neither setter nor field found for property '" + name + "'");
}
private BindingPoint getTypeDescriptor(EvaluationContext context, Object target, String name) {
private ConversionPoint getTypeDescriptor(EvaluationContext context, Object target, String name) {
if (target == null) {
return null;
}
Class<?> type = (target instanceof Class ? (Class<?>) target : target.getClass());
if (type.isArray() && name.equals("length")) {
return BindingPoint.valueOf(Integer.TYPE);
return ConversionPoint.valueOf(Integer.TYPE);
}
CacheKey cacheKey = new CacheKey(type, name);
BindingPoint typeDescriptor = this.typeDescriptorCache.get(cacheKey);
ConversionPoint typeDescriptor = this.typeDescriptorCache.get(cacheKey);
if (typeDescriptor == null) {
// attempt to populate the cache entry
try {

6
org.springframework.expression/src/main/java/org/springframework/expression/spel/support/StandardEvaluationContext.java
View File

@@ -22,7 +22,7 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
import org.springframework.expression.ConstructorResolver;
import org.springframework.expression.EvaluationContext;
import org.springframework.expression.MethodResolver;
@@ -75,10 +75,10 @@ public class StandardEvaluationContext implements EvaluationContext {
}
public void setRootObject(Object rootObject) {
this.rootObject = new TypedValue(rootObject,BindingPoint.forObject(rootObject));
this.rootObject = new TypedValue(rootObject,ConversionPoint.forObject(rootObject));
}
public void setRootObject(Object rootObject, BindingPoint typeDescriptor) {
public void setRootObject(Object rootObject, ConversionPoint typeDescriptor) {
this.rootObject = new TypedValue(rootObject,typeDescriptor);
}

10
org.springframework.expression/src/main/java/org/springframework/expression/spel/support/StandardTypeConverter.java
View File

@@ -18,7 +18,7 @@ package org.springframework.expression.spel.support;
import org.springframework.core.convert.ConvertException;
import org.springframework.core.convert.ConverterNotFoundException;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
import org.springframework.core.convert.support.DefaultTypeConverter;
import org.springframework.expression.EvaluationException;
import org.springframework.expression.TypeConverter;
@@ -46,11 +46,11 @@ public class StandardTypeConverter implements TypeConverter {
@SuppressWarnings("unchecked")
public <T> T convertValue(Object value, Class<T> targetType) throws EvaluationException {
return (T) convertValue(value, BindingPoint.valueOf(targetType));
return (T) convertValue(value, ConversionPoint.valueOf(targetType));
}
@SuppressWarnings("unchecked")
public Object convertValue(Object value, BindingPoint typeDescriptor) throws EvaluationException {
public Object convertValue(Object value, ConversionPoint typeDescriptor) throws EvaluationException {
try {
return this.typeConverter.convert(value, typeDescriptor);
}
@@ -63,10 +63,10 @@ public class StandardTypeConverter implements TypeConverter {
}
public boolean canConvert(Class<?> sourceType, Class<?> targetType) {
return canConvert(sourceType, BindingPoint.valueOf(targetType));
return canConvert(sourceType, ConversionPoint.valueOf(targetType));
}
public boolean canConvert(Class<?> sourceType, BindingPoint targetType) {
public boolean canConvert(Class<?> sourceType, ConversionPoint targetType) {
return this.typeConverter.canConvert(sourceType, targetType);
}

6
org.springframework.expression/src/test/java/org/springframework/expression/spel/ExpressionLanguageScenarioTests.java
View File

@@ -23,7 +23,7 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
import org.springframework.expression.AccessException;
import org.springframework.expression.EvaluationContext;
import org.springframework.expression.EvaluationException;
@@ -236,7 +236,7 @@ public class ExpressionLanguageScenarioTests extends ExpressionTestCase {
private static class FruitColourAccessor implements PropertyAccessor {
private static Map<String,Color> propertyMap = new HashMap<String,Color>();
private static BindingPoint mapElementTypeDescriptor = BindingPoint.valueOf(Color.class);
private static ConversionPoint mapElementTypeDescriptor = ConversionPoint.valueOf(Color.class);
static {
propertyMap.put("banana",Color.yellow);
@@ -295,7 +295,7 @@ public class ExpressionLanguageScenarioTests extends ExpressionTestCase {
}
public TypedValue read(EvaluationContext context, Object target, String name) throws AccessException {
return new TypedValue(propertyMap.get(name),BindingPoint.valueOf(Color.class));
return new TypedValue(propertyMap.get(name),ConversionPoint.valueOf(Color.class));
}
public boolean canWrite(EvaluationContext context, Object target, String name) throws AccessException {

8
org.springframework.expression/src/test/java/org/springframework/expression/spel/ExpressionStateTests.java
View File

@@ -18,7 +18,7 @@ package org.springframework.expression.spel;
import java.util.HashMap;
import java.util.Map;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
import org.springframework.expression.EvaluationContext;
import org.springframework.expression.EvaluationException;
import org.springframework.expression.Operation;
@@ -117,7 +117,7 @@ public class ExpressionStateTests extends ExpressionTestCase {
assertEquals(TypedValue.NULL_TYPED_VALUE,state.getRootContextObject());
((StandardEvaluationContext)state.getEvaluationContext()).setRootObject(null,BindingPoint.NULL_TYPE_DESCRIPTOR);
((StandardEvaluationContext)state.getEvaluationContext()).setRootObject(null,ConversionPoint.NULL);
assertEquals(null,state.getRootContextObject().getValue());
}
@@ -222,10 +222,10 @@ public class ExpressionStateTests extends ExpressionTestCase {
public void testTypeConversion() throws EvaluationException {
ExpressionState state = getState();
String s = (String)state.convertValue(34,BindingPoint.valueOf(String.class));
String s = (String)state.convertValue(34,ConversionPoint.valueOf(String.class));
assertEquals("34",s);
s = (String)state.convertValue(new TypedValue(34),BindingPoint.valueOf(String.class));
s = (String)state.convertValue(new TypedValue(34),ConversionPoint.valueOf(String.class));
assertEquals("34",s);
}

18
org.springframework.expression/src/test/java/org/springframework/expression/spel/ExpressionTestsUsingCoreConversionService.java
View File

@@ -19,7 +19,7 @@ package org.springframework.expression.spel;
import java.util.ArrayList;
import java.util.List;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
import org.springframework.core.convert.support.DefaultTypeConverter;
import org.springframework.core.convert.support.GenericTypeConverter;
import org.springframework.expression.EvaluationException;
@@ -35,9 +35,9 @@ import org.springframework.expression.spel.support.StandardEvaluationContext;
public class ExpressionTestsUsingCoreConversionService extends ExpressionTestCase {
private static List<String> listOfString = new ArrayList<String>();
private static BindingPoint typeDescriptorForListOfString = null;
private static ConversionPoint typeDescriptorForListOfString = null;
private static List<Integer> listOfInteger = new ArrayList<Integer>();
private static BindingPoint typeDescriptorForListOfInteger = null;
private static ConversionPoint typeDescriptorForListOfInteger = null;
static {
listOfString.add("1");
@@ -50,8 +50,8 @@ public class ExpressionTestsUsingCoreConversionService extends ExpressionTestCas
public void setUp() throws Exception {
super.setUp();
typeDescriptorForListOfString = new BindingPoint(ExpressionTestsUsingCoreConversionService.class.getDeclaredField("listOfString"));
typeDescriptorForListOfInteger = new BindingPoint(ExpressionTestsUsingCoreConversionService.class.getDeclaredField("listOfInteger"));
typeDescriptorForListOfString = new ConversionPoint(ExpressionTestsUsingCoreConversionService.class.getDeclaredField("listOfString"));
typeDescriptorForListOfInteger = new ConversionPoint(ExpressionTestsUsingCoreConversionService.class.getDeclaredField("listOfInteger"));
}
@@ -96,20 +96,20 @@ public class ExpressionTestsUsingCoreConversionService extends ExpressionTestCas
private final DefaultTypeConverter service = new DefaultTypeConverter();
public boolean canConvert(Class<?> sourceType, Class<?> targetType) {
return this.service.canConvert(sourceType, BindingPoint.valueOf(targetType));
return this.service.canConvert(sourceType, ConversionPoint.valueOf(targetType));
}
public boolean canConvert(Class<?> sourceType, BindingPoint typeDescriptor) {
public boolean canConvert(Class<?> sourceType, ConversionPoint typeDescriptor) {
return this.service.canConvert(sourceType, typeDescriptor);
}
@SuppressWarnings("unchecked")
public <T> T convertValue(Object value, Class<T> targetType) throws EvaluationException {
return (T) this.service.convert(value,BindingPoint.valueOf(targetType));
return (T) this.service.convert(value,ConversionPoint.valueOf(targetType));
}
@SuppressWarnings("unchecked")
public Object convertValue(Object value, BindingPoint typeDescriptor) throws EvaluationException {
public Object convertValue(Object value, ConversionPoint typeDescriptor) throws EvaluationException {
return this.service.convert(value, typeDescriptor);
}
}

8
org.springframework.expression/src/test/java/org/springframework/expression/spel/ScenariosForSpringSecurity.java
View File

@@ -19,7 +19,7 @@ package org.springframework.expression.spel;
import java.lang.reflect.Method;
import org.springframework.core.MethodParameter;
import org.springframework.core.convert.BindingPoint;
import org.springframework.core.convert.ConversionPoint;
import org.springframework.expression.AccessException;
import org.springframework.expression.EvaluationContext;
import org.springframework.expression.EvaluationException;
@@ -214,7 +214,7 @@ public class ScenariosForSpringSecurity extends ExpressionTestCase {
}
public TypedValue read(EvaluationContext context, Object target, String name) throws AccessException {
return new TypedValue(new Principal(),BindingPoint.valueOf(Principal.class));
return new TypedValue(new Principal(),ConversionPoint.valueOf(Principal.class));
}
public boolean canWrite(EvaluationContext context, Object target, String name) throws AccessException {
@@ -244,7 +244,7 @@ public class ScenariosForSpringSecurity extends ExpressionTestCase {
}
public TypedValue read(EvaluationContext context, Object target, String name) throws AccessException {
return new TypedValue(activePerson,BindingPoint.valueOf(Person.class));
return new TypedValue(activePerson,ConversionPoint.valueOf(Person.class));
}
public boolean canWrite(EvaluationContext context, Object target, String name) throws AccessException {
@@ -283,7 +283,7 @@ public class ScenariosForSpringSecurity extends ExpressionTestCase {
if (m.isVarArgs()) {
args = ReflectionHelper.setupArgumentsForVarargsInvocation(m.getParameterTypes(), args);
}
return new TypedValue(m.invoke(null, args), new BindingPoint(new MethodParameter(m,-1)));
return new TypedValue(m.invoke(null, args), new ConversionPoint(new MethodParameter(m,-1)));
}
catch (Exception ex) {
throw new AccessException("Problem invoking hasRole", ex);