Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve performance of NumberUtils

Browse Source 
This commit aims to improve the space and time performance of
NumberUtils by invoking valueOf() factory methods instead of the
corresponding constructors when converting a number to a target class.
This commit is contained in:
Sam Brannen
2015-08-06 19:42:03 +02:00
parent e0392d9da5
commit 48b965ad33
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spring-core/src/main/java/org/springframework/util/NumberUtils.java
View File

@@ -91,21 +91,21 @@ public abstract class NumberUtils {
if (value < Byte.MIN_VALUE || value > Byte.MAX_VALUE) {
raiseOverflowException(number, targetClass);
}
return (T) new Byte(number.byteValue());
return (T) Byte.valueOf(number.byteValue());
}
else if (Short.class == targetClass) {
long value = number.longValue();
if (value < Short.MIN_VALUE || value > Short.MAX_VALUE) {
raiseOverflowException(number, targetClass);
}
return (T) new Short(number.shortValue());
return (T) Short.valueOf(number.shortValue());
}
else if (Integer.class == targetClass) {
long value = number.longValue();
if (value < Integer.MIN_VALUE || value > Integer.MAX_VALUE) {
raiseOverflowException(number, targetClass);
}
return (T) new Integer(number.intValue());
return (T) Integer.valueOf(number.intValue());
}
else if (Long.class == targetClass) {
BigInteger bigInt = null;
@@ -119,7 +119,7 @@ public abstract class NumberUtils {
if (bigInt != null && (bigInt.compareTo(LONG_MIN) < 0 || bigInt.compareTo(LONG_MAX) > 0)) {
raiseOverflowException(number, targetClass);
}
return (T) new Long(number.longValue());
return (T) Long.valueOf(number.longValue());
}
else if (BigInteger.class == targetClass) {
if (number instanceof BigDecimal) {
@@ -132,10 +132,10 @@ public abstract class NumberUtils {
}
}
else if (Float.class == targetClass) {
return (T) new Float(number.floatValue());
return (T) Float.valueOf(number.floatValue());
}
else if (Double.class == targetClass) {
return (T) new Double(number.doubleValue());
return (T) Double.valueOf(number.doubleValue());
}
else if (BigDecimal.class == targetClass) {
// always use BigDecimal(String) here to avoid unpredictability of BigDecimal(double)