Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UriTemplateRequestEntity overrides equals/hashCode

Browse Source 
Closes gh-27531
This commit is contained in:
Juergen Hoeller
2021-10-08 20:41:18 +02:00
parent b6111d04a5
commit 4b01370f54
2 changed files with 62 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
spring-web/src/test/java/org/springframework/http/RequestEntityTests.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2002-2020 the original author or authors.
* Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -20,6 +20,7 @@ import java.net.URI;
import java.net.URISyntaxException;
import java.nio.charset.StandardCharsets;
import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
@@ -175,4 +176,37 @@ class RequestEntityTests {
assertThat(entity.getType()).isEqualTo(typeReference.getType());
}
@Test
void equalityWithUrl() {
RequestEntity<Void> requestEntity1 = RequestEntity.method(HttpMethod.GET, "http://test.api/path/").build();
RequestEntity<Void> requestEntity2 = RequestEntity.method(HttpMethod.GET, "http://test.api/path/").build();
RequestEntity<Void> requestEntity3 = RequestEntity.method(HttpMethod.GET, "http://test.api/pathX/").build();
assertThat(requestEntity1).isEqualTo(requestEntity2);
assertThat(requestEntity2).isEqualTo(requestEntity1);
assertThat(requestEntity1).isNotEqualTo(requestEntity3);
assertThat(requestEntity3).isNotEqualTo(requestEntity2);
assertThat(requestEntity1.hashCode()).isEqualTo(requestEntity2.hashCode());
assertThat(requestEntity1.hashCode()).isNotEqualTo(requestEntity3.hashCode());
}
@Test // gh-27531
void equalityWithUriTemplate() {
Map<String, Object> vars = Collections.singletonMap("id", "1");
RequestEntity<Void> requestEntity1 =
RequestEntity.method(HttpMethod.GET, "http://test.api/path/{id}", vars).build();
RequestEntity<Void> requestEntity2 =
RequestEntity.method(HttpMethod.GET, "http://test.api/path/{id}", vars).build();
RequestEntity<Void> requestEntity3 =
RequestEntity.method(HttpMethod.GET, "http://test.api/pathX/{id}", vars).build();
assertThat(requestEntity1).isEqualTo(requestEntity2);
assertThat(requestEntity2).isEqualTo(requestEntity1);
assertThat(requestEntity1).isNotEqualTo(requestEntity3);
assertThat(requestEntity3).isNotEqualTo(requestEntity2);
assertThat(requestEntity1.hashCode()).isEqualTo(requestEntity2.hashCode());
assertThat(requestEntity1.hashCode()).isNotEqualTo(requestEntity3.hashCode());
}
}