Support List and Publisher<Fragment> return values

See gh-33162
This commit is contained in:
rstoyanchev
2024-07-10 08:17:34 +01:00
parent f2028d2339
commit 54e76c8105
3 changed files with 77 additions and 34 deletions

View File

@@ -33,6 +33,7 @@ import org.springframework.context.annotation.AnnotationConfigApplicationContext
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.context.support.ResourceBundleMessageSource;
import org.springframework.core.MethodParameter;
import org.springframework.http.MediaType;
import org.springframework.web.reactive.BindingContext;
import org.springframework.web.reactive.HandlerResult;
@@ -44,42 +45,46 @@ import org.springframework.web.testfixture.http.server.reactive.MockServerHttpRe
import org.springframework.web.testfixture.server.MockServerWebExchange;
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
import static org.junit.jupiter.api.Named.named;
import static org.springframework.web.testfixture.method.ResolvableMethod.on;
/**
* Tests for multi-view rendering through {@link ViewResolutionResultHandler}.
* Tests for {@link Fragment} rendering through {@link ViewResolutionResultHandler}.
*
* @author Rossen Stoyanchev
*/
public class FragmentResolutionResultHandlerTests {
public class FragmentViewResolutionResultHandlerTests {
static Stream<Arguments> arguments() {
Fragment f1 = Fragment.create("fragment1", Map.of("foo", "Foo"));
Fragment f2 = Fragment.create("fragment2", Map.of("bar", "Bar"));
return Stream.of(
Arguments.of(named("Flux",
FragmentRendering.fromPublisher(Flux.just(f1, f2).subscribeOn(Schedulers.boundedElastic()))
.headers(headers -> headers.setContentType(MediaType.TEXT_HTML))
.build())),
Arguments.of(named("List",
FragmentRendering.fromCollection(List.of(f1, f2))
.headers(headers -> headers.setContentType(MediaType.TEXT_HTML))
.build()))
);}
static Stream<Arguments> arguments() {
Fragment f1 = Fragment.create("fragment1", Map.of("foo", "Foo"));
Fragment f2 = Fragment.create("fragment2", Map.of("bar", "Bar"));
return Stream.of(
Arguments.of(
FragmentRendering.fromPublisher(Flux.just(f1, f2).subscribeOn(Schedulers.boundedElastic()))
.headers(headers -> headers.setContentType(MediaType.TEXT_HTML))
.build(),
on(Handler.class).resolveReturnType(FragmentRendering.class)),
Arguments.of(
FragmentRendering.fromCollection(List.of(f1, f2))
.headers(headers -> headers.setContentType(MediaType.TEXT_HTML))
.build(),
on(Handler.class).resolveReturnType(FragmentRendering.class)),
Arguments.of(
Flux.just(f1, f2).subscribeOn(Schedulers.boundedElastic()),
on(Handler.class).resolveReturnType(Flux.class, Fragment.class)),
Arguments.of(
List.of(f1, f2),
on(Handler.class).resolveReturnType(List.class, Fragment.class)));
}
@ParameterizedTest
@MethodSource("arguments")
void render(FragmentRendering rendering) {
void render(Object returnValue, MethodParameter parameter) {
Locale locale = Locale.ENGLISH;
MockServerHttpRequest request = MockServerHttpRequest.get("/").acceptLanguageAsLocales(locale).build();
MockServerWebExchange exchange = MockServerWebExchange.from(request);
HandlerResult result = new HandlerResult(
new Handler(), rendering, on(Handler.class).resolveReturnType(FragmentRendering.class),
new BindingContext());
HandlerResult result = new HandlerResult(new Handler(), returnValue, parameter, new BindingContext());
String body = initHandler().handleResult(exchange, result)
.then(Mono.defer(() -> exchange.getResponse().getBodyAsString()))
@@ -102,10 +107,15 @@ public class FragmentResolutionResultHandlerTests {
}
@SuppressWarnings("unused")
private static class Handler {
FragmentRendering rendering() { return null; }
Flux<Fragment> fragmentFlux() { return null; }
List<Fragment> fragmentList() { return null; }
}

View File

@@ -79,9 +79,14 @@ class ViewResolutionResultHandlerTests {
testSupports(on(Handler.class).resolveReturnType(Mono.class, String.class));
testSupports(on(Handler.class).resolveReturnType(Rendering.class));
testSupports(on(Handler.class).resolveReturnType(FragmentRendering.class));
testSupports(on(Handler.class).resolveReturnType(Mono.class, Rendering.class));
testSupports(on(Handler.class).resolveReturnType(FragmentRendering.class));
testSupports(on(Handler.class).resolveReturnType(Flux.class, Fragment.class));
testSupports(on(Handler.class).resolveReturnType(List.class, Fragment.class));
testSupports(on(Handler.class).resolveReturnType(
Mono.class, ResolvableType.forClassWithGenerics(List.class, Fragment.class)));
testSupports(on(Handler.class).resolveReturnType(View.class));
testSupports(on(Handler.class).resolveReturnType(Mono.class, View.class));
@@ -436,6 +441,9 @@ class ViewResolutionResultHandlerTests {
Mono<Rendering> monoRendering() { return null; }
FragmentRendering fragmentRendering() { return null; }
Flux<Fragment> fragmentFlux() { return null; }
Mono<List<Fragment>> monoFragmentList() { return null; }
List<Fragment> fragmentList() { return null; }
View view() { return null; }
Mono<View> monoView() { return null; }