Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Do not assert thread count in ParallelApplicationEventsIntegrationTests

Browse Source
This commit is contained in:
Sam Brannen
2021-03-11 10:14:12 +01:00
parent 6d4c0091b5
commit 5593e95e89
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
spring-test/src/test/java/org/springframework/test/context/junit/jupiter/event/ParallelApplicationEventsIntegrationTests.java
View File

@@ -68,13 +68,17 @@ class ParallelApplicationEventsIntegrationTests {
Set<String> testNames = payloads.stream()// Set<String> testNames = payloads.stream()//
.map(payload -> payload.substring(0, payload.indexOf("-")))// .map(payload -> payload.substring(0, payload.indexOf("-")))//
.collect(Collectors.toSet()); .collect(Collectors.toSet());
Set<String> threadNames = payloads.stream()//
.map(payload -> payload.substring(payload.indexOf("-")))//
.collect(Collectors.toSet());
assertThat(payloads).hasSize(10); assertThat(payloads).hasSize(10);
assertThat(testNames).hasSize(10); assertThat(testNames).hasSize(10);
// The following assertion is currently commented out, since it fails
// regularly on the CI server due to only 1 thread being used for
// parallel test execution on the CI server.
/*
Set<String> threadNames = payloads.stream()//
.map(payload -> payload.substring(payload.indexOf("-")))//
.collect(Collectors.toSet());
int availableProcessors = Runtime.getRuntime().availableProcessors(); int availableProcessors = Runtime.getRuntime().availableProcessors();
// Skip the following assertion entirely if too few processors are available // Skip the following assertion entirely if too few processors are available
// to the current JVM. // to the current JVM.
@@ -86,6 +90,7 @@ class ParallelApplicationEventsIntegrationTests {
.as("number of threads used with " + availableProcessors + " available processors") .as("number of threads used with " + availableProcessors + " available processors")
.hasSizeGreaterThanOrEqualTo(2); .hasSizeGreaterThanOrEqualTo(2);
} }
*/
} }