Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Bean destruction exceptions consistently logged at warn level

Browse Source 
Closes gh-23200
This commit is contained in:
Juergen Hoeller
2019-07-05 17:07:22 +02:00
parent aeef95938e
commit 56cc0d02e9
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spring-beans/src/main/java/org/springframework/beans/factory/support/DefaultSingletonBeanRegistry.java
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2018 the original author or authors. * Copyright 2002-2019 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -571,8 +571,8 @@ public class DefaultSingletonBeanRegistry extends SimpleAliasRegistry implements
bean.destroy(); bean.destroy();
} }
catch (Throwable ex) { catch (Throwable ex) {
if (logger.isInfoEnabled()) { if (logger.isWarnEnabled()) {
logger.info("Destroy method on bean with name '" + beanName + "' threw an exception", ex); logger.warn("Destruction of bean with name '" + beanName + "' threw an exception", ex);
} }
} }
} }

10
spring-beans/src/main/java/org/springframework/beans/factory/support/DisposableBeanAdapter.java
View File

@@ -261,10 +261,10 @@ class DisposableBeanAdapter implements DisposableBean, Runnable, Serializable {
catch (Throwable ex) { catch (Throwable ex) {
String msg = "Invocation of destroy method failed on bean with name '" + this.beanName + "'"; String msg = "Invocation of destroy method failed on bean with name '" + this.beanName + "'";
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
logger.info(msg, ex); logger.warn(msg, ex);
} }
else { else {
logger.info(msg + ": " + ex); logger.warn(msg + ": " + ex);
} }
} }
} }
@@ -343,14 +343,14 @@ class DisposableBeanAdapter implements DisposableBean, Runnable, Serializable {
String msg = "Destroy method '" + this.destroyMethodName + "' on bean with name '" + String msg = "Destroy method '" + this.destroyMethodName + "' on bean with name '" +
this.beanName + "' threw an exception"; this.beanName + "' threw an exception";
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
logger.info(msg, ex.getTargetException()); logger.warn(msg, ex.getTargetException());
} }
else { else {
logger.info(msg + ": " + ex.getTargetException()); logger.warn(msg + ": " + ex.getTargetException());
} }
} }
catch (Throwable ex) { catch (Throwable ex) {
logger.info("Failed to invoke destroy method '" + this.destroyMethodName + logger.warn("Failed to invoke destroy method '" + this.destroyMethodName +
"' on bean with name '" + this.beanName + "'", ex); "' on bean with name '" + this.beanName + "'", ex);
} }
} }