From 5ba69441454a834e0bf4a7c992d0f5c06540502b Mon Sep 17 00:00:00 2001 From: James Yuzawa Date: Tue, 28 Mar 2023 08:21:07 -0400 Subject: [PATCH] Remove String.formatter from DefaultServerRequestObservationConvention Closes gh-30218 --- .../observation/DefaultServerRequestObservationConvention.java | 2 +- .../observation/DefaultServerRequestObservationConvention.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spring-web/src/main/java/org/springframework/http/server/observation/DefaultServerRequestObservationConvention.java b/spring-web/src/main/java/org/springframework/http/server/observation/DefaultServerRequestObservationConvention.java index 72c6e762ca..4e113675b9 100644 --- a/spring-web/src/main/java/org/springframework/http/server/observation/DefaultServerRequestObservationConvention.java +++ b/spring-web/src/main/java/org/springframework/http/server/observation/DefaultServerRequestObservationConvention.java @@ -84,7 +84,7 @@ public class DefaultServerRequestObservationConvention implements ServerRequestO public String getContextualName(ServerRequestObservationContext context) { String httpMethod = context.getCarrier().getMethod().toLowerCase(); if (context.getPathPattern() != null) { - return "http %s %s".formatted(httpMethod, context.getPathPattern()); + return "http " + httpMethod + " " + context.getPathPattern(); } return "http " + httpMethod; } diff --git a/spring-web/src/main/java/org/springframework/http/server/reactive/observation/DefaultServerRequestObservationConvention.java b/spring-web/src/main/java/org/springframework/http/server/reactive/observation/DefaultServerRequestObservationConvention.java index 825cf99f3d..d1f8bb0fb1 100644 --- a/spring-web/src/main/java/org/springframework/http/server/reactive/observation/DefaultServerRequestObservationConvention.java +++ b/spring-web/src/main/java/org/springframework/http/server/reactive/observation/DefaultServerRequestObservationConvention.java @@ -84,7 +84,7 @@ public class DefaultServerRequestObservationConvention implements ServerRequestO public String getContextualName(ServerRequestObservationContext context) { String httpMethod = context.getCarrier().getMethod().name().toLowerCase(); if (context.getPathPattern() != null) { - return "http %s %s".formatted(httpMethod, context.getPathPattern()); + return "http " + httpMethod + " " + context.getPathPattern(); } return "http " + httpMethod; }