Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid accidental usage of JUnit 4 assumptions

Browse Source 
This commit also avoids starting a server if an assumption fails.
This commit is contained in:
Sam Brannen
2019-09-06 16:03:36 +02:00
parent 591995ecc8
commit 5d5f9aceca
4 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/SseIntegrationTests.java
View File

@@ -141,9 +141,9 @@ class SseIntegrationTests extends AbstractHttpHandlerIntegrationTests {
@ParameterizedSseTest
void sseAsEvent(HttpServer httpServer, ClientHttpConnector connector) throws Exception {
startServer(httpServer, connector);
assumeTrue(httpServer instanceof JettyHttpServer);
assumeTrue(super.server instanceof JettyHttpServer);
startServer(httpServer, connector);
Flux<ServerSentEvent<Person>> result = this.webClient.get()
.uri("/event")
@@ -190,9 +190,9 @@ class SseIntegrationTests extends AbstractHttpHandlerIntegrationTests {
@ParameterizedSseTest // SPR-16494
@Disabled // https://github.com/reactor/reactor-netty/issues/283
void serverDetectsClientDisconnect(HttpServer httpServer, ClientHttpConnector connector) throws Exception {
startServer(httpServer, connector);
assumeTrue(httpServer instanceof ReactorHttpServer);
assumeTrue(super.server instanceof ReactorHttpServer);
startServer(httpServer, connector);
Flux<String> result = this.webClient.get()
.uri("/infinite")