diff --git a/spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompSession.java b/spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompSession.java index 7a6c6a0851..8a01b90f6c 100644 --- a/spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompSession.java +++ b/spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompSession.java @@ -63,7 +63,7 @@ public interface StompSession { * {@link StompHeaders} instead of just a destination. The headers must * contain a destination and may also have other headers such as * "content-type" or custom headers for the broker to propagate to - * subscribers, or broker-specific, non-standard headers.. + * subscribers, or broker-specific, non-standard headers. * @param headers the message headers * @param payload the message payload * @return a Receiptable for tracking receipts diff --git a/spring-web/src/main/java/org/springframework/http/HttpHeaders.java b/spring-web/src/main/java/org/springframework/http/HttpHeaders.java index 386ef57c0d..0e06390836 100644 --- a/spring-web/src/main/java/org/springframework/http/HttpHeaders.java +++ b/spring-web/src/main/java/org/springframework/http/HttpHeaders.java @@ -1678,7 +1678,7 @@ public class HttpHeaders implements MultiValueMap, Serializable /** - * Return a {@code HttpHeaders} object that can only be read, not written to. + * Return an {@code HttpHeaders} object that can only be read, not written to. */ public static HttpHeaders readOnlyHttpHeaders(HttpHeaders headers) { Assert.notNull(headers, "HttpHeaders must not be null"); @@ -1691,7 +1691,7 @@ public class HttpHeaders implements MultiValueMap, Serializable } /** - * Return a {@code HttpHeaders} object that can be read and written to. + * Return an {@code HttpHeaders} object that can be read and written to. * @since 5.1.1 */ public static HttpHeaders writableHttpHeaders(HttpHeaders headers) { diff --git a/spring-web/src/main/java/org/springframework/web/server/adapter/HttpWebHandlerAdapter.java b/spring-web/src/main/java/org/springframework/web/server/adapter/HttpWebHandlerAdapter.java index 7968d1b874..5d59f670cf 100644 --- a/spring-web/src/main/java/org/springframework/web/server/adapter/HttpWebHandlerAdapter.java +++ b/spring-web/src/main/java/org/springframework/web/server/adapter/HttpWebHandlerAdapter.java @@ -301,11 +301,12 @@ public class HttpWebHandlerAdapter extends WebHandlerDecorator implements HttpHa } } - private boolean isDisconnectedClientError(Throwable ex) { + private boolean isDisconnectedClientError(Throwable ex) { String message = NestedExceptionUtils.getMostSpecificCause(ex).getMessage(); - message = (message != null ? message.toLowerCase() : ""); - String className = ex.getClass().getSimpleName(); - return (message.contains("broken pipe") || DISCONNECTED_CLIENT_EXCEPTIONS.contains(className)); + if (message != null && message.toLowerCase().contains("broken pipe")) { + return true; + } + return DISCONNECTED_CLIENT_EXCEPTIONS.contains(ex.getClass().getSimpleName()); } } diff --git a/spring-webflux/src/main/java/org/springframework/web/reactive/result/method/AbstractHandlerMethodMapping.java b/spring-webflux/src/main/java/org/springframework/web/reactive/result/method/AbstractHandlerMethodMapping.java index ad9e9719ae..83a0df600f 100644 --- a/spring-webflux/src/main/java/org/springframework/web/reactive/result/method/AbstractHandlerMethodMapping.java +++ b/spring-webflux/src/main/java/org/springframework/web/reactive/result/method/AbstractHandlerMethodMapping.java @@ -217,7 +217,7 @@ public abstract class AbstractHandlerMethodMapping extends AbstractHandlerMap private String formatMappings(Class userType, Map methods) { String formattedType = Arrays.stream(ClassUtils.getPackageName(userType).split("\\.")) .map(p -> p.substring(0, 1)) - .collect(Collectors.joining(".", "", ".")) + userType.getSimpleName(); + .collect(Collectors.joining(".", "", "." + userType.getSimpleName())); Function methodFormatter = method -> Arrays.stream(method.getParameterTypes()) .map(Class::getSimpleName) .collect(Collectors.joining(",", "(", ")")); @@ -249,16 +249,11 @@ public abstract class AbstractHandlerMethodMapping extends AbstractHandlerMap * @return the created HandlerMethod */ protected HandlerMethod createHandlerMethod(Object handler, Method method) { - HandlerMethod handlerMethod; if (handler instanceof String) { - String beanName = (String) handler; - handlerMethod = new HandlerMethod(beanName, + return new HandlerMethod((String) handler, obtainApplicationContext().getAutowireCapableBeanFactory(), method); } - else { - handlerMethod = new HandlerMethod(handler, method); - } - return handlerMethod; + return new HandlerMethod(handler, method); } /** diff --git a/spring-webmvc/src/main/java/org/springframework/web/servlet/handler/AbstractHandlerMethodMapping.java b/spring-webmvc/src/main/java/org/springframework/web/servlet/handler/AbstractHandlerMethodMapping.java index 38dbfd4853..bfd8a7bf4d 100644 --- a/spring-webmvc/src/main/java/org/springframework/web/servlet/handler/AbstractHandlerMethodMapping.java +++ b/spring-webmvc/src/main/java/org/springframework/web/servlet/handler/AbstractHandlerMethodMapping.java @@ -287,7 +287,7 @@ public abstract class AbstractHandlerMethodMapping extends AbstractHandlerMap private String formatMappings(Class userType, Map methods) { String formattedType = Arrays.stream(ClassUtils.getPackageName(userType).split("\\.")) .map(p -> p.substring(0, 1)) - .collect(Collectors.joining(".", "", ".")) + userType.getSimpleName(); + .collect(Collectors.joining(".", "", "." + userType.getSimpleName())); Function methodFormatter = method -> Arrays.stream(method.getParameterTypes()) .map(Class::getSimpleName) .collect(Collectors.joining(",", "(", ")")); @@ -319,16 +319,11 @@ public abstract class AbstractHandlerMethodMapping extends AbstractHandlerMap * @return the created HandlerMethod */ protected HandlerMethod createHandlerMethod(Object handler, Method method) { - HandlerMethod handlerMethod; if (handler instanceof String) { - String beanName = (String) handler; - handlerMethod = new HandlerMethod(beanName, + return new HandlerMethod((String) handler, obtainApplicationContext().getAutowireCapableBeanFactory(), method); } - else { - handlerMethod = new HandlerMethod(handler, method); - } - return handlerMethod; + return new HandlerMethod(handler, method); } /**