diff --git a/spring-core/src/test/java/org/springframework/core/ResolvableTypeTests.java b/spring-core/src/test/java/org/springframework/core/ResolvableTypeTests.java index ef61c6c4c6..b79ad11578 100644 --- a/spring-core/src/test/java/org/springframework/core/ResolvableTypeTests.java +++ b/spring-core/src/test/java/org/springframework/core/ResolvableTypeTests.java @@ -48,6 +48,7 @@ import org.junit.runner.RunWith; import org.mockito.ArgumentCaptor; import org.mockito.Captor; import org.mockito.runners.MockitoJUnitRunner; + import org.springframework.core.ResolvableType.VariableResolver; import org.springframework.util.MultiValueMap; @@ -833,8 +834,7 @@ public class ResolvableTypeTests { assertThat("field " + field + " toString", type.toString(), equalTo(expected)); } - private void assertTypedFieldToStringValue(String field, String expected) - throws Exception { + private void assertTypedFieldToStringValue(String field, String expected) throws Exception { ResolvableType type = ResolvableType.forField(Fields.class.getField(field), TypedFields.class); assertThat("field " + field + " toString", type.toString(), equalTo(expected)); } @@ -842,8 +842,7 @@ public class ResolvableTypeTests { @Test public void resolveFromOuterClass() throws Exception { Field field = EnclosedInParameterizedType.InnerTyped.class.getField("field"); - ResolvableType type = ResolvableType.forField( - field, TypedEnclosedInParameterizedType.TypedInnerTyped.class); + ResolvableType type = ResolvableType.forField(field, TypedEnclosedInParameterizedType.TypedInnerTyped.class); assertThat(type.resolve(), equalTo((Type) Integer.class)); } @@ -1198,8 +1197,7 @@ public class ResolvableTypeTests { return read; } - private static AssertAssignbleMatcher assertAssignable(final ResolvableType type, - final ResolvableType... fromTypes) { + private static AssertAssignbleMatcher assertAssignable(final ResolvableType type, final ResolvableType... fromTypes) { return new AssertAssignbleMatcher() { @Override public void equalTo(boolean... values) { @@ -1227,19 +1225,16 @@ public class ResolvableTypeTests { private static interface AssertAssignbleMatcher { void equalTo(boolean... values); - } @SuppressWarnings("serial") static class ExtendsList extends ArrayList { - } @SuppressWarnings("serial") static class ExtendsMap extends HashMap { - } @@ -1281,12 +1276,10 @@ public class ResolvableTypeTests { public Map, Map> nested; public T[] variableTypeGenericArray; - } static class TypedFields extends Fields { - } @@ -1303,7 +1296,6 @@ public class ResolvableTypeTests { void typedParameter(T p); T typedReturn(); - } @@ -1352,17 +1344,14 @@ public class ResolvableTypeTests { public Collection> complexWildcard3; public List> complexWildcard4; - } static class Assignment extends AssignmentBase { - } static interface TypedMethods extends Methods { - } @@ -1373,7 +1362,6 @@ public class ResolvableTypeTests { public Constructors(Map p) { } - } @@ -1386,65 +1374,52 @@ public class ResolvableTypeTests { public TypedConstructors(Map p) { super(p); } - } public interface MyInterfaceType { - } public class MySimpleInterfaceType implements MyInterfaceType { - } public abstract class MySimpleInterfaceTypeWithImplementsRaw implements MyInterfaceType, List { - } public abstract class ExtendsMySimpleInterfaceTypeWithImplementsRaw extends MySimpleInterfaceTypeWithImplementsRaw { - } public class MyCollectionInterfaceType implements MyInterfaceType> { - } public abstract class MySuperclassType { - } public class MySimpleSuperclassType extends MySuperclassType { - } public class MyCollectionSuperclassType extends MySuperclassType> { - } static interface Wildcard extends List { - } static interface RawExtendsWildcard extends Wildcard { - } static interface VariableNameSwitch extends MultiValueMap { - } static interface ListOfGenericArray extends List[]> { - } @@ -1457,7 +1432,6 @@ public class ResolvableTypeTests { public T field; } - } @@ -1466,7 +1440,6 @@ public class ResolvableTypeTests { class TypedInnerTyped extends InnerTyped { } - } } diff --git a/spring-core/src/test/java/org/springframework/core/convert/support/CollectionToCollectionConverterTests.java b/spring-core/src/test/java/org/springframework/core/convert/support/CollectionToCollectionConverterTests.java index 9e12a26d77..ddb99a220b 100644 --- a/spring-core/src/test/java/org/springframework/core/convert/support/CollectionToCollectionConverterTests.java +++ b/spring-core/src/test/java/org/springframework/core/convert/support/CollectionToCollectionConverterTests.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2012 the original author or authors. + * Copyright 2002-2013 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -43,6 +43,7 @@ import static org.junit.Assert.*; /** * @author Keith Donald + * @author Juergen Hoeller */ public class CollectionToCollectionConverterTests { @@ -63,8 +64,9 @@ public class CollectionToCollectionConverterTests { assertTrue(conversionService.canConvert(sourceType, targetType)); try { conversionService.convert(list, sourceType, targetType); - } catch (ConversionFailedException e) { - assertTrue(e.getCause() instanceof ConverterNotFoundException); + } + catch (ConversionFailedException ex) { + assertTrue(ex.getCause() instanceof ConverterNotFoundException); } conversionService.addConverterFactory(new StringToNumberConverterFactory()); assertTrue(conversionService.canConvert(sourceType, targetType)); @@ -141,10 +143,10 @@ public class CollectionToCollectionConverterTests { TypeDescriptor targetType = new TypeDescriptor(getClass().getField("objectToCollection")); assertTrue(conversionService.canConvert(sourceType, targetType)); List>> result = (List>>) conversionService.convert(list, sourceType, targetType); - assertEquals((Integer)9, result.get(0).get(0).get(0)); - assertEquals((Integer)12, result.get(0).get(1).get(0)); - assertEquals((Integer)37, result.get(1).get(0).get(0)); - assertEquals((Integer)23, result.get(1).get(1).get(0)); + assertEquals((Integer) 9, result.get(0).get(0).get(0)); + assertEquals((Integer) 12, result.get(0).get(1).get(0)); + assertEquals((Integer) 37, result.get(1).get(0).get(0)); + assertEquals((Integer) 23, result.get(1).get(1).get(0)); } public List>> objectToCollection;