diff --git a/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractAutowireCapableBeanFactory.java b/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractAutowireCapableBeanFactory.java index 81ce08d29e..c21f498d81 100644 --- a/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractAutowireCapableBeanFactory.java +++ b/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractAutowireCapableBeanFactory.java @@ -300,8 +300,6 @@ public abstract class AbstractAutowireCapableBeanFactory extends AbstractBeanFac RootBeanDefinition bd = new RootBeanDefinition(beanClass); bd.setScope(SCOPE_PROTOTYPE); bd.allowCaching = ClassUtils.isCacheSafe(beanClass, getBeanClassLoader()); - // For the nullability warning, see the elaboration in AbstractBeanFactory.doGetBean; - // in short: This is never going to be null unless user-declared code enforces null. return (T) createBean(beanClass.getName(), bd, null); } @@ -335,8 +333,6 @@ public abstract class AbstractAutowireCapableBeanFactory extends AbstractBeanFac BeanWrapper bw = new BeanWrapperImpl(existingBean); initBeanWrapper(bw); populateBean(beanName, bd, bw); - // For the nullability warning, see the elaboration in AbstractBeanFactory.doGetBean; - // in short: This is never going to be null unless user-declared code enforces null. return initializeBean(beanName, existingBean, bd); } @@ -356,8 +352,6 @@ public abstract class AbstractAutowireCapableBeanFactory extends AbstractBeanFac // Use non-singleton bean definition, to avoid registering bean as dependent bean. RootBeanDefinition bd = new RootBeanDefinition(beanClass, autowireMode, dependencyCheck); bd.setScope(BeanDefinition.SCOPE_PROTOTYPE); - // For the nullability warning, see the elaboration in AbstractBeanFactory.doGetBean; - // in short: This is never going to be null unless user-declared code enforces null. return createBean(beanClass.getName(), bd, null); } diff --git a/spring-jdbc/src/main/java/org/springframework/jdbc/datasource/ConnectionHolder.java b/spring-jdbc/src/main/java/org/springframework/jdbc/datasource/ConnectionHolder.java index 618f79b7e7..4e543368e7 100644 --- a/spring-jdbc/src/main/java/org/springframework/jdbc/datasource/ConnectionHolder.java +++ b/spring-jdbc/src/main/java/org/springframework/jdbc/datasource/ConnectionHolder.java @@ -42,7 +42,7 @@ import org.springframework.util.Assert; public class ConnectionHolder extends ResourceHolderSupport { /** - * Prefix of savpoint names. + * Prefix for savepoint names. */ public static final String SAVEPOINT_NAME_PREFIX = "SAVEPOINT_"; diff --git a/spring-orm/src/test/java/org/springframework/orm/jpa/AbstractEntityManagerFactoryIntegrationTests.java b/spring-orm/src/test/java/org/springframework/orm/jpa/AbstractEntityManagerFactoryIntegrationTests.java index 4c2a1d0d69..25e709e01e 100644 --- a/spring-orm/src/test/java/org/springframework/orm/jpa/AbstractEntityManagerFactoryIntegrationTests.java +++ b/spring-orm/src/test/java/org/springframework/orm/jpa/AbstractEntityManagerFactoryIntegrationTests.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2017 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -89,7 +89,7 @@ public abstract class AbstractEntityManagerFactoryIntegrationTests { @Before - public void setUp() { + public void setup() { if (applicationContext == null) { applicationContext = new ClassPathXmlApplicationContext(getConfigLocations()); } @@ -105,7 +105,7 @@ public abstract class AbstractEntityManagerFactoryIntegrationTests { } @After - public void tearDown() throws Exception { + public void cleanup() { if (this.transactionStatus != null && !this.transactionStatus.isCompleted()) { endTransaction(); }