Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix HttpHeaders.setHost() to remove the header

Browse Source 
See gh-33716
This commit is contained in:
Ilya Serkov
2024-10-16 11:53:05 +03:00
committed by rstoyanchev
parent 9252e741e1
commit 657e002ed7
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-web/src/main/java/org/springframework/http/HttpHeaders.java
View File

@@ -1136,7 +1136,7 @@ public class HttpHeaders implements MultiValueMap<String, String>, Serializable
set(HOST, value); set(HOST, value);
} }
else { else {
remove(HOST, null); remove(HOST);
} }
} }

9
spring-web/src/test/java/org/springframework/http/HttpHeadersTests.java
View File

@@ -213,6 +213,15 @@ class HttpHeadersTests {
assertThat(headers.getFirst("Host")).as("Invalid Host header").isEqualTo("[::1]"); assertThat(headers.getFirst("Host")).as("Invalid Host header").isEqualTo("[::1]");
} }
@Test
void hostDeletion() {
InetSocketAddress host = InetSocketAddress.createUnresolved("localhost", 8080);
headers.setHost(host);
headers.setHost(null);
assertThat(headers.getHost()).as("Host is not deleted").isEqualTo(null);
assertThat(headers.getFirst("Host")).as("Host is not deleted").isEqualTo(null);
}
@Test @Test
void eTagWithoutQuotes() { void eTagWithoutQuotes() {
headers.setETag("v2.6"); headers.setETag("v2.6");