Cancel WebAsyncManager thread on request timeout

Issue: SPR-15852
This commit is contained in:
Rossen Stoyanchev
2017-08-16 09:42:39 +02:00
parent 8b64ad3192
commit 681ced8fd3
3 changed files with 56 additions and 4 deletions

View File

@@ -18,6 +18,7 @@ package org.springframework.web.context.request.async;
import java.util.List;
import java.util.concurrent.Callable;
import java.util.concurrent.Future;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -39,11 +40,19 @@ class CallableInterceptorChain {
private int preProcessIndex = -1;
private volatile Future<?> taskFuture;
public CallableInterceptorChain(List<CallableProcessingInterceptor> interceptors) {
this.interceptors = interceptors;
}
public void setTaskFuture(Future<?> taskFuture) {
this.taskFuture = taskFuture;
}
public void applyBeforeConcurrentHandling(NativeWebRequest request, Callable<?> task) throws Exception {
for (CallableProcessingInterceptor interceptor : this.interceptors) {
interceptor.beforeConcurrentHandling(request, task);
@@ -77,6 +86,7 @@ class CallableInterceptorChain {
}
public Object triggerAfterTimeout(NativeWebRequest request, Callable<?> task) {
cancelTask();
for (CallableProcessingInterceptor interceptor : this.interceptors) {
try {
Object result = interceptor.handleTimeout(request, task);
@@ -94,6 +104,18 @@ class CallableInterceptorChain {
return CallableProcessingInterceptor.RESULT_NONE;
}
private void cancelTask() {
Future<?> future = this.taskFuture;
if (future != null) {
try {
future.cancel(true);
}
catch (Throwable ex) {
// Ignore
}
}
}
public void triggerAfterCompletion(NativeWebRequest request, Callable<?> task) {
for (int i = this.interceptors.size()-1; i >= 0; i--) {
try {

View File

@@ -21,6 +21,7 @@ import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.Callable;
import java.util.concurrent.Future;
import java.util.concurrent.RejectedExecutionException;
import javax.servlet.http.HttpServletRequest;
@@ -307,7 +308,7 @@ public final class WebAsyncManager {
interceptorChain.applyBeforeConcurrentHandling(this.asyncWebRequest, callable);
startAsyncProcessing(processingContext);
try {
this.taskExecutor.submit(new Runnable() {
Future<?> future = this.taskExecutor.submit(new Runnable() {
@Override
public void run() {
Object result = null;
@@ -324,6 +325,7 @@ public final class WebAsyncManager {
setConcurrentResultAndDispatch(result);
}
});
interceptorChain.setTaskFuture(future);
}
catch (RejectedExecutionException ex) {
Object result = interceptorChain.applyPostProcess(this.asyncWebRequest, callable, ex);