more tests

org.springframework.context/src/main/java/org/springframework/ui/binding/Binder.java

@@ -137,7 +137,7 @@ public class Binder<T> {
 			required = config.isRequired();
 		}
 
-		public String getFormattedValue() {
+		public String getValue() {
 			try {
 				return format(property.getValue(createEvaluationContext()));
 			} catch (ExpressionException e) {
@@ -146,15 +146,13 @@ public class Binder<T> {
 		}
 
 		public void setValue(String formatted) {
-			Object value = parse(formatted);
-			assertRequired(value);
-			setValue(value);
+			setValue(parse(formatted));
 		}
 
-		public String format(Object possibleValue) {
+		public String format(Object selectableValue) {
 			Formatter formatter = getFormatter();
-			possibleValue = typeConverter.convert(possibleValue, formatter.getFormattedObjectType());
-			return formatter.format(possibleValue, LocaleContextHolder.getLocale());
+			selectableValue = typeConverter.convert(selectableValue, formatter.getFormattedObjectType());
+			return formatter.format(selectableValue, LocaleContextHolder.getLocale());
 		}
 
 		public boolean isCollection() {
@@ -162,7 +160,7 @@ public class Binder<T> {
 			return type.isCollection() || type.isArray();
 		}
 
-		public String[] getFormattedValues() {
+		public String[] getValues() {
 			Object multiValue;
 			try {
 				multiValue = property.getValue(createEvaluationContext());
@@ -199,18 +197,12 @@ public class Binder<T> {
 			return required;
 		}
 
-		public Messages getMessages() {
+		public BindingFailures getFailures() {
 			return null;
 		}
 
 		// internal helpers
 		
-		private void assertRequired(Object value) {
-			if (required && value == null) {
-				throw new IllegalArgumentException("Value required");
-			}
-		}
-		
 		private Object parse(String formatted) {
 			try {
 				return getFormatter().parse(formatted, LocaleContextHolder.getLocale());
@@ -254,7 +246,7 @@ public class Binder<T> {
 			return new Annotation[0];
 		}
 
-		private void copy(Iterable values, String[] formattedValues) {
+		private void copy(Iterable<?> values, String[] formattedValues) {
 			int i = 0;
 			for (Object value : values) {
 				formattedValues[i] = format(value);

org.springframework.context/src/main/java/org/springframework/ui/binding/Binding.java

@@ -4,24 +4,22 @@ public interface Binding {
 
 	// single-value properties
 	
-	String getFormattedValue();
+	String getValue();
 	
 	void setValue(String formatted);
 
-	String format(Object possibleValue);
+	String format(Object selectableValue);
 
 	// multi-value properties
 	
 	boolean isCollection();
 
-	String[] getFormattedValues();
+	String[] getValues();
 
 	void setValues(String[] formattedValues);
 
 	// validation metadata
 	
-	boolean isRequired();
-	
-	Messages getMessages();	
+	BindingFailures getFailures();	
 	
 }

org.springframework.context/src/main/java/org/springframework/ui/binding/BindingFailure.java

@@ -0,0 +1,15 @@
+package org.springframework.ui.binding;
+
+import java.util.Map;
+
+public interface BindingFailure {
+	
+	String getCode();
+
+	String getSeverity();
+	
+	// TODO - where does arg formatting occur
+	Map<String, Object> getArgs();
+	
+	Map<String, String> getDetails();
+}

org.springframework.context/src/main/java/org/springframework/ui/binding/BindingFailures.java

@@ -2,14 +2,14 @@ package org.springframework.ui.binding;
 
 import java.util.List;
 
-public interface Messages {
+public interface BindingFailures {
 	
 	int getCount();
 	
 	Severity getMaximumSeverity();
 	
-	List<Message> getAll();
+	List<BindingFailure> getAll();
 
-	List<Message> getBySeverity(Severity severity);
+	List<BindingFailure> getBySeverity(Severity severity);
 	
 }

org.springframework.context/src/main/java/org/springframework/ui/binding/Message.java

@@ -1,9 +0,0 @@
-package org.springframework.ui.binding;
-
-public interface Message {
-	
-	String getText();
-	
-	String getSeverity();
-	
-}

org.springframework.context/src/main/java/org/springframework/ui/format/Formatter.java

@@ -41,6 +41,7 @@ public interface Formatter<T> {
 	
 	/**
 	 * Parse an object from its formatted representation.
+	 * TODO - remove dependency on java.text by replacing ParseException?
 	 * @param formatted a formatted representation
 	 * @param locale the user's locale
 	 * @return the parsed object