Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CachedIntrospectionResults uses putIfAbsent where possible (for minimal write locking)

Browse Source 
Issue: SPR-12102
This commit is contained in:
Juergen Hoeller
2014-08-19 22:50:54 +02:00
parent 1ca0460534
commit 781a6d289e
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-beans/src/main/java/org/springframework/beans/CachedIntrospectionResults.java
View File

@@ -188,13 +188,13 @@ public class CachedIntrospectionResults {
results = new CachedIntrospectionResults(beanClass);
if (ClassUtils.isCacheSafe(beanClass, CachedIntrospectionResults.class.getClassLoader()) ||
isClassLoaderAccepted(beanClass.getClassLoader())) {
strongClassCache.put(beanClass, results);
strongClassCache.putIfAbsent(beanClass, results);
}
else {
if (logger.isDebugEnabled()) {
logger.debug("Not strongly caching class [" + beanClass.getName() + "] because it is not cache-safe");
}
softClassCache.put(beanClass, results);
softClassCache.putIfAbsent(beanClass, results);
}
return results;
}
@@ -295,7 +295,7 @@ public class CachedIntrospectionResults {
"; editor [" + pd.getPropertyEditorClass().getName() + "]" : ""));
}
pd = buildGenericTypeAwarePropertyDescriptor(beanClass, pd);
this.propertyDescriptorCache.put(pd.getName(), pd);
this.propertyDescriptorCache.putIfAbsent(pd.getName(), pd);
}
this.typeDescriptorCache = new ConcurrentHashMap<PropertyDescriptor, TypeDescriptor>();
@@ -348,7 +348,7 @@ public class CachedIntrospectionResults {
}
void addTypeDescriptor(PropertyDescriptor pd, TypeDescriptor td) {
this.typeDescriptorCache.put(pd, td);
this.typeDescriptorCache.putIfAbsent(pd, td);
}
TypeDescriptor getTypeDescriptor(PropertyDescriptor pd) {