From 7a20ed7d704ae4196a674810b02683be345d2408 Mon Sep 17 00:00:00 2001 From: Juergen Hoeller Date: Mon, 15 Aug 2011 21:29:15 +0000 Subject: [PATCH] fixed timeout assertion --- .../http/client/CommonsClientHttpRequestFactory.java | 4 ++-- .../httpinvoker/CommonsHttpInvokerRequestExecutor.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/org.springframework.web/src/main/java/org/springframework/http/client/CommonsClientHttpRequestFactory.java b/org.springframework.web/src/main/java/org/springframework/http/client/CommonsClientHttpRequestFactory.java index dc1f3b8070..228fee279c 100644 --- a/org.springframework.web/src/main/java/org/springframework/http/client/CommonsClientHttpRequestFactory.java +++ b/org.springframework.web/src/main/java/org/springframework/http/client/CommonsClientHttpRequestFactory.java @@ -94,7 +94,7 @@ public class CommonsClientHttpRequestFactory implements ClientHttpRequestFactory * @see org.apache.commons.httpclient.params.HttpConnectionManagerParams#setConnectionTimeout(int) */ public void setConnectTimeout(int timeout) { - Assert.isTrue(timeout < 0, "Timeout must be a non-negative value"); + Assert.isTrue(timeout >= 0, "Timeout must be a non-negative value"); this.httpClient.getHttpConnectionManager().getParams().setConnectionTimeout(timeout); } @@ -105,7 +105,7 @@ public class CommonsClientHttpRequestFactory implements ClientHttpRequestFactory * @see org.apache.commons.httpclient.params.HttpConnectionManagerParams#setSoTimeout(int) */ public void setReadTimeout(int timeout) { - Assert.isTrue(timeout < 0, "Timeout must be a non-negative value"); + Assert.isTrue(timeout >= 0, "Timeout must be a non-negative value"); getHttpClient().getHttpConnectionManager().getParams().setSoTimeout(timeout); } diff --git a/org.springframework.web/src/main/java/org/springframework/remoting/httpinvoker/CommonsHttpInvokerRequestExecutor.java b/org.springframework.web/src/main/java/org/springframework/remoting/httpinvoker/CommonsHttpInvokerRequestExecutor.java index 548721498f..c53e364226 100644 --- a/org.springframework.web/src/main/java/org/springframework/remoting/httpinvoker/CommonsHttpInvokerRequestExecutor.java +++ b/org.springframework.web/src/main/java/org/springframework/remoting/httpinvoker/CommonsHttpInvokerRequestExecutor.java @@ -102,7 +102,7 @@ public class CommonsHttpInvokerRequestExecutor extends AbstractHttpInvokerReques * @see org.apache.commons.httpclient.params.HttpConnectionManagerParams#setConnectionTimeout(int) */ public void setConnectTimeout(int timeout) { - Assert.isTrue(timeout < 0, "Timeout must be a non-negative value"); + Assert.isTrue(timeout >= 0, "Timeout must be a non-negative value"); this.httpClient.getHttpConnectionManager().getParams().setConnectionTimeout(timeout); } @@ -114,7 +114,7 @@ public class CommonsHttpInvokerRequestExecutor extends AbstractHttpInvokerReques * @see #DEFAULT_READ_TIMEOUT_MILLISECONDS */ public void setReadTimeout(int timeout) { - Assert.isTrue(timeout < 0, "Timeout must be a non-negative value"); + Assert.isTrue(timeout >= 0, "Timeout must be a non-negative value"); this.httpClient.getHttpConnectionManager().getParams().setSoTimeout(timeout); }