Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enforce TransactionRequiredException for pre-bound EntityManager without actual transaction active

Browse Source 
Issue: SPR-13243
This commit is contained in:
Juergen Hoeller
2015-07-17 15:25:29 +02:00
parent 2f8ac91872
commit 7e2a662f63
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-orm/src/main/java/org/springframework/orm/jpa/SharedEntityManagerCreator.java
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2014 the original author or authors. * Copyright 2002-2015 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -34,6 +34,7 @@ import javax.persistence.TransactionRequiredException;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.springframework.transaction.support.TransactionSynchronizationManager;
import org.springframework.util.ClassUtils; import org.springframework.util.ClassUtils;
import org.springframework.util.CollectionUtils; import org.springframework.util.CollectionUtils;
@@ -271,8 +272,9 @@ public abstract class SharedEntityManagerCreator {
else if (transactionRequiringMethods.contains(method.getName())) { else if (transactionRequiringMethods.contains(method.getName())) {
// We need a transactional target now, according to the JPA spec. // We need a transactional target now, according to the JPA spec.
// Otherwise, the operation would get accepted but remain unflushed... // Otherwise, the operation would get accepted but remain unflushed...
if (target == null) { if (target == null || !TransactionSynchronizationManager.isActualTransactionActive()) {
throw new TransactionRequiredException("No transactional EntityManager available"); throw new TransactionRequiredException("No EntityManager with actual transaction available " +
"for current thread - cannot reliably process '" + method.getName() + "' call");
} }
} }

6
spring-orm/src/test/java/org/springframework/orm/jpa/support/PersistenceContextTransactionTests.java
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2014 the original author or authors. * Copyright 2002-2015 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -116,12 +116,12 @@ public class PersistenceContextTransactionTests {
tt.execute(new TransactionCallback() { tt.execute(new TransactionCallback() {
@Override @Override
public Object doInTransaction(TransactionStatus status) { public Object doInTransaction(TransactionStatus status) {
bean.sharedEntityManager.flush(); bean.sharedEntityManager.clear();
return null; return null;
} }
}); });
verify(manager).flush(); verify(manager).clear();
verify(manager).close(); verify(manager).close();
} }