Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Debug-level log entry for any Jackson exception during canConvert

Browse Source 
Issue: SPR-15582
This commit is contained in:
Juergen Hoeller
2017-06-07 18:33:19 +02:00
parent 55b0fe1027
commit 7eaedf2916
2 changed files with 24 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
spring-messaging/src/main/java/org/springframework/messaging/converter/MappingJackson2MessageConverter.java
View File

@@ -180,10 +180,20 @@ public class MappingJackson2MessageConverter extends AbstractMessageConverter {
* @since 4.3 * @since 4.3
*/ */
protected void logWarningIfNecessary(Type type, @Nullable Throwable cause) { protected void logWarningIfNecessary(Type type, @Nullable Throwable cause) {
if (cause != null && !(cause instanceof JsonMappingException && cause.getMessage().startsWith("Can not find"))) { if (cause == null) {
return;
}
boolean debugLevel = (cause instanceof JsonMappingException &&
cause.getMessage().startsWith("Can not find"));
if (debugLevel ? logger.isDebugEnabled() : logger.isWarnEnabled()) {
String msg = "Failed to evaluate Jackson " + (type instanceof JavaType ? "de" : "") + String msg = "Failed to evaluate Jackson " + (type instanceof JavaType ? "de" : "") +
"serialization for type [" + type + "]"; "serialization for type [" + type + "]";
if (logger.isDebugEnabled()) { if (debugLevel) {
logger.debug(msg, cause);
}
else if (logger.isDebugEnabled()) {
logger.warn(msg, cause); logger.warn(msg, cause);
} }
else { else {

14
spring-web/src/main/java/org/springframework/http/converter/json/AbstractJackson2HttpMessageConverter.java
View File

@@ -191,10 +191,20 @@ public abstract class AbstractJackson2HttpMessageConverter extends AbstractGener
* @since 4.3 * @since 4.3
*/ */
protected void logWarningIfNecessary(Type type, @Nullable Throwable cause) { protected void logWarningIfNecessary(Type type, @Nullable Throwable cause) {
if (cause != null && !(cause instanceof JsonMappingException && cause.getMessage().startsWith("Can not find"))) { if (cause == null) {
return;
}
boolean debugLevel = (cause instanceof JsonMappingException &&
cause.getMessage().startsWith("Can not find"));
if (debugLevel ? logger.isDebugEnabled() : logger.isWarnEnabled()) {
String msg = "Failed to evaluate Jackson " + (type instanceof JavaType ? "de" : "") + String msg = "Failed to evaluate Jackson " + (type instanceof JavaType ? "de" : "") +
"serialization for type [" + type + "]"; "serialization for type [" + type + "]";
if (logger.isDebugEnabled()) { if (debugLevel) {
logger.debug(msg, cause);
}
else if (logger.isDebugEnabled()) {
logger.warn(msg, cause); logger.warn(msg, cause);
} }
else { else {