Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refactor BeanInfoFactory

Browse Source 
This commit refactors the BeanInfoFactory so that:

 - supports() and getBeanInfo() are folded into one, so that getBeanInfo()
    returns null if a given class is not supported.
 - CachedIntrospectionResults now uses SpringFactoriesLoader
This commit is contained in:
Arjen Poutsma
2012-09-10 14:28:53 +02:00
parent aeff91c1da
commit 82739dd4ac
6 changed files with 38 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
spring-beans/src/test/java/org/springframework/beans/ExtendedBeanInfoFactoryTests.java
View File

@@ -18,11 +18,11 @@ package org.springframework.beans;
import java.beans.IntrospectionException;
import static org.hamcrest.CoreMatchers.notNullValue;
import static org.hamcrest.CoreMatchers.nullValue;
import static org.junit.Assert.assertThat;
import org.junit.Test;
import static org.hamcrest.CoreMatchers.*;
import static org.junit.Assert.*;
/**
* Unit tests for {@link ExtendedBeanInfoTests}.
*
@@ -38,7 +38,7 @@ public class ExtendedBeanInfoFactoryTests {
class C {
public void setFoo(String s) { }
}
assertThat(factory.supports(C.class), is(false));
assertThat(factory.getBeanInfo(C.class), nullValue());
}
@Test
@@ -47,7 +47,7 @@ public class ExtendedBeanInfoFactoryTests {
class C {
public C setFoo(String s) { return this; }
}
assertThat(factory.supports(C.class), is(true));
assertThat(factory.getBeanInfo(C.class), notNullValue());
}
@Test
@@ -56,7 +56,7 @@ public class ExtendedBeanInfoFactoryTests {
class C {
public C setFoo(int i, String s) { return this; }
}
assertThat(factory.supports(C.class), is(true));
assertThat(factory.getBeanInfo(C.class), notNullValue());
}
@Test
@@ -65,7 +65,7 @@ public class ExtendedBeanInfoFactoryTests {
class C {
void setBar(String s) { }
}
assertThat(factory.supports(C.class), is(false));
assertThat(factory.getBeanInfo(C.class), nullValue());
}
@Test
@@ -74,7 +74,7 @@ public class ExtendedBeanInfoFactoryTests {
class C {
C setBar() { return this; }
}
assertThat(factory.supports(C.class), is(false));
assertThat(factory.getBeanInfo(C.class), nullValue());
}
@Test
@@ -83,7 +83,7 @@ public class ExtendedBeanInfoFactoryTests {
class C {
C set(String s) { return this; }
}
assertThat(factory.supports(C.class), is(false));
assertThat(factory.getBeanInfo(C.class), nullValue());
}
}