Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix Map.put contract for HeadersAdapter impl.

Browse Source 
This commit fixes the `Map.put` contract for both Reactor Netty and
Tomcat specific `HeadersAdapter` implementations.

Issue: SPR-17415
This commit is contained in:
Brian Clozel
2018-10-22 14:53:14 +02:00
parent 862dd23975
commit 85262a7932
3 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
spring-web/src/test/java/org/springframework/http/server/reactive/HeadersAdaptersTests.java
View File

@@ -16,12 +16,14 @@
package org.springframework.http.server.reactive;
import java.util.Arrays;
import java.util.Locale;
import io.netty.handler.codec.http.DefaultHttpHeaders;
import io.undertow.util.HeaderMap;
import org.apache.tomcat.util.http.MimeHeaders;
import org.eclipse.jetty.http.HttpFields;
import org.junit.After;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
@@ -57,6 +59,11 @@ public class HeadersAdaptersTests {
};
}
@After
public void tearDown() {
this.headers.clear();
}
@Test
public void getWithUnknownHeaderShouldReturnNull() {
assertNull(this.headers.get("Unknown"));
@@ -96,4 +103,12 @@ public class HeadersAdaptersTests {
assertEquals("first", this.headers.get("TestHeader").get(0));
}
}
@Test
public void putShouldOverrideExisting() {
this.headers.add("TestHeader", "first");
this.headers.put("TestHeader", Arrays.asList("override"));
assertEquals("override", this.headers.getFirst("TestHeader"));
assertEquals(1, this.headers.get("TestHeader").size());
}
}