Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

More WebSocket logging updates

Browse Source 
Update WebSocketSession toString methods to include the handshake URI
and add id and URI fields to ensure they're available after close().

Log WebSocket session open and close events at INFO.

Remove trace messages for destinations that do not match.

Issue: SPR-11884
This commit is contained in:
Rossen Stoyanchev
2014-06-28 14:01:13 -04:00
parent fac2d80054
commit 86de416908
14 changed files with 109 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spring-messaging/src/main/java/org/springframework/messaging/simp/broker/SimpleBrokerMessageHandler.java
View File

@@ -135,9 +135,6 @@ public class SimpleBrokerMessageHandler extends AbstractBrokerMessageHandler {
String sessionId = SimpMessageHeaderAccessor.getSessionId(headers);
if (!checkDestinationPrefix(destination)) {
if (logger.isTraceEnabled()) {
logger.trace("No match on destination in " + message);
}
return;
}
@@ -173,11 +170,6 @@ public class SimpleBrokerMessageHandler extends AbstractBrokerMessageHandler {
}
this.subscriptionRegistry.unregisterSubscription(message);
}
else {
if (logger.isTraceEnabled()) {
logger.trace("Unsupported message type in " + message);
}
}
}
private void initHeaders(SimpMessageHeaderAccessor accessor) {

3
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompBrokerRelayMessageHandler.java
View File

@@ -454,9 +454,6 @@ public class StompBrokerRelayMessageHandler extends AbstractBrokerMessageHandler
String destination = stompAccessor.getDestination();
if ((command != null) && command.requiresDestination() && !checkDestinationPrefix(destination)) {
if (logger.isTraceEnabled()) {
logger.trace("No match on destination. Ignoring " + message);
}
return;
}

6
spring-messaging/src/main/java/org/springframework/messaging/simp/user/UserDestinationMessageHandler.java
View File

@@ -171,8 +171,8 @@ public class UserDestinationMessageHandler implements MessageHandler, SmartLifec
}
Set<String> destinations = result.getTargetDestinations();
if (destinations.isEmpty()) {
if (logger.isDebugEnabled()) {
logger.debug("Use destination not resolved (no active sessions?): " + message);
if (logger.isTraceEnabled()) {
logger.trace("No user destinations for " + message);
}
return;
}
@@ -185,7 +185,7 @@ public class UserDestinationMessageHandler implements MessageHandler, SmartLifec
}
for (String destination : destinations) {
if (logger.isTraceEnabled()) {
logger.trace("Sending message with resolved user destination: " + message);
logger.trace("Sending " + message);
}
this.brokerMessagingTemplate.send(destination, message);
}