From 87fa2c3b97c7ee4785c4109ebd14ff3310f9db11 Mon Sep 17 00:00:00 2001 From: Johnny Lim Date: Sat, 18 Apr 2020 01:44:16 +0900 Subject: [PATCH] Avoid unnecessary String instantiation in StringUtils.deleteAny() This commit avoids unnecessary String instantiation in StringUtils.deleteAny() if nothing was deleted from the input string. Closes gh-24924 --- .../src/main/java/org/springframework/util/StringUtils.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/spring-core/src/main/java/org/springframework/util/StringUtils.java b/spring-core/src/main/java/org/springframework/util/StringUtils.java index 9fe0fcd4af..5eb623f94a 100644 --- a/spring-core/src/main/java/org/springframework/util/StringUtils.java +++ b/spring-core/src/main/java/org/springframework/util/StringUtils.java @@ -461,6 +461,9 @@ public abstract class StringUtils { result[lastCharIndex++] = c; } } + if (lastCharIndex == inString.length()) { + return inString; + } return new String(result, 0, lastCharIndex); }