Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

TransactionInterceptor avoids reflective method search for method identification

Browse Source 
As of Spring 3.0.4, we were trying to expose the target method signature as transaction name. Unfortunately, the algorithm called the ClassUtils.getMostSpecificMethod helper method which performs a quite expensive reflective search. As of this commit, we're simply concatenating the target class name with the method name, accepting the use of the concrete target class (which is arguably more meaningful for monitoring anyway) even when the method implementation actually sits on a base class.

Issue: SPR-9802
This commit is contained in:
Juergen Hoeller
2012-09-26 19:30:42 +02:00
parent abf341c33a
commit 89b365120a
3 changed files with 23 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spring-tx/src/test/java/org/springframework/transaction/interceptor/BeanFactoryTransactionTests.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2002-2010 the original author or authors.
* Copyright 2002-2012 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -127,16 +127,14 @@ public class BeanFactoryTransactionTests extends TestCase {
final TransactionStatus ts = (TransactionStatus) statusControl.getMock();
ptm = new PlatformTransactionManager() {
private boolean invoked;
public TransactionStatus getTransaction(TransactionDefinition definition) throws TransactionException {
public TransactionStatus getTransaction(TransactionDefinition def) throws TransactionException {
if (invoked) {
throw new IllegalStateException("getTransaction should not get invoked more than once");
}
invoked = true;
System.out.println(definition.getName());
if (!((definition.getName().indexOf(TestBean.class.getName()) != -1) &&
(definition.getName().indexOf("setAge") != -1))) {
if (!(def.getName().contains(DerivedTestBean.class.getName()) && def.getName().contains("setAge"))) {
throw new IllegalStateException(
"transaction name should contain class and method name: " + definition.getName());
"transaction name should contain class and method name: " + def.getName());
}
return ts;
}