Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Cache attribute methods in AnnotationUtils

Browse Source 
Issue: SPR-11512
This commit is contained in:
Sam Brannen
2015-05-24 15:55:54 +02:00
parent d5974a18ab
commit 8ecae8697a
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
spring-core/src/main/java/org/springframework/core/annotation/AnnotationUtils.java
View File

@@ -121,6 +121,9 @@ public abstract class AnnotationUtils {
private static final Map<Class<? extends Annotation>, Map<String, String>> attributeAliasesCache = private static final Map<Class<? extends Annotation>, Map<String, String>> attributeAliasesCache =
new ConcurrentReferenceHashMap<Class<? extends Annotation>, Map<String, String>>(256); new ConcurrentReferenceHashMap<Class<? extends Annotation>, Map<String, String>>(256);
private static final Map<Class<? extends Annotation>, List<Method>> attributeMethodsCache =
new ConcurrentReferenceHashMap<Class<? extends Annotation>, List<Method>>(256);
private static transient Log logger; private static transient Log logger;
@@ -1311,13 +1314,22 @@ public abstract class AnnotationUtils {
* @since 4.2 * @since 4.2
*/ */
static List<Method> getAttributeMethods(Class<? extends Annotation> annotationType) { static List<Method> getAttributeMethods(Class<? extends Annotation> annotationType) {
List<Method> methods = new ArrayList<Method>();
List<Method> methods = attributeMethodsCache.get(annotationType);
if (methods != null) {
return methods;
}
methods = new ArrayList<Method>();
for (Method method : annotationType.getDeclaredMethods()) { for (Method method : annotationType.getDeclaredMethods()) {
if ((method.getParameterTypes().length == 0) && (method.getReturnType() != void.class)) { if ((method.getParameterTypes().length == 0) && (method.getReturnType() != void.class)) {
ReflectionUtils.makeAccessible(method); ReflectionUtils.makeAccessible(method);
methods.add(method); methods.add(method);
} }
} }
attributeMethodsCache.put(annotationType, methods);
return methods; return methods;
} }