Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve performance of FormContentFilter

Browse Source 
Improve the performance of `FormContentFilter` by checking directly if
`contentType` is empty. This saves the need for an exception to thrown
then immediately caught.

Closes gh-23216
This commit is contained in:
Phillip Webb
2019-06-29 22:25:57 -07:00
parent b3d56ebf3b
commit 932f771380
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
spring-web/src/main/java/org/springframework/web/filter/FormContentFilter.java
View File

@@ -109,16 +109,17 @@ public class FormContentFilter extends OncePerRequestFilter {
} }
private boolean shouldParse(HttpServletRequest request) { private boolean shouldParse(HttpServletRequest request) {
if (!HTTP_METHODS.contains(request.getMethod())) { String contentType = request.getContentType();
return false; String method = request.getMethod();
} if (StringUtils.hasLength(contentType) && HTTP_METHODS.contains(method)) {
try { try {
MediaType mediaType = MediaType.parseMediaType(request.getContentType()); MediaType mediaType = MediaType.parseMediaType(contentType);
return MediaType.APPLICATION_FORM_URLENCODED.includes(mediaType); return MediaType.APPLICATION_FORM_URLENCODED.includes(mediaType);
} }
catch (IllegalArgumentException ex) { catch (IllegalArgumentException ex) {
return false; }
} }
return false;
} }