Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UnsatisfiedDependencyException avoids duplicate nested exception message

Browse Source 
Issue: SPR-14607
This commit is contained in:
Juergen Hoeller
2016-08-23 13:21:40 +02:00
parent c4fff6db1b
commit 93d2287894
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spring-beans/src/main/java/org/springframework/beans/factory/UnsatisfiedDependencyException.java
View File

@@ -17,7 +17,7 @@
package org.springframework.beans.factory; package org.springframework.beans.factory;
import org.springframework.beans.BeansException; import org.springframework.beans.BeansException;
import org.springframework.util.ClassUtils; import org.springframework.util.StringUtils;
/** /**
* Exception thrown when a bean depends on other beans or simple properties * Exception thrown when a bean depends on other beans or simple properties
@@ -46,7 +46,7 @@ public class UnsatisfiedDependencyException extends BeanCreationException {
super(resourceDescription, beanName, super(resourceDescription, beanName,
"Unsatisfied dependency expressed through bean property '" + propertyName + "'" + "Unsatisfied dependency expressed through bean property '" + propertyName + "'" +
(msg != null ? ": " + msg : "")); (StringUtils.hasLength(msg) ? ": " + msg : ""));
} }
/** /**
@@ -59,7 +59,7 @@ public class UnsatisfiedDependencyException extends BeanCreationException {
public UnsatisfiedDependencyException( public UnsatisfiedDependencyException(
String resourceDescription, String beanName, String propertyName, BeansException ex) { String resourceDescription, String beanName, String propertyName, BeansException ex) {
this(resourceDescription, beanName, propertyName, (ex != null ? ex.getMessage() : "")); this(resourceDescription, beanName, propertyName, "");
initCause(ex); initCause(ex);
} }
@@ -74,7 +74,9 @@ public class UnsatisfiedDependencyException extends BeanCreationException {
public UnsatisfiedDependencyException( public UnsatisfiedDependencyException(
String resourceDescription, String beanName, InjectionPoint injectionPoint, String msg) { String resourceDescription, String beanName, InjectionPoint injectionPoint, String msg) {
super(resourceDescription, beanName, "Unsatisfied dependency expressed through " + injectionPoint + ": " + msg); super(resourceDescription, beanName,
"Unsatisfied dependency expressed through " + injectionPoint +
(StringUtils.hasLength(msg) ? ": " + msg : ""));
this.injectionPoint = injectionPoint; this.injectionPoint = injectionPoint;
} }
@@ -89,7 +91,7 @@ public class UnsatisfiedDependencyException extends BeanCreationException {
public UnsatisfiedDependencyException( public UnsatisfiedDependencyException(
String resourceDescription, String beanName, InjectionPoint injectionPoint, BeansException ex) { String resourceDescription, String beanName, InjectionPoint injectionPoint, BeansException ex) {
this(resourceDescription, beanName, injectionPoint, (ex != null ? ex.getMessage() : "")); this(resourceDescription, beanName, injectionPoint, "");
initCause(ex); initCause(ex);
} }