From 940a37f9cefb33fd9c70072e8ced6a21d4a98a2b Mon Sep 17 00:00:00 2001 From: Sam Brannen Date: Thu, 14 Oct 2021 15:53:54 +0200 Subject: [PATCH] Apply "final fields" Eclipse clean-up in spring-test This has only been applied to `src/main/java`. --- .../main/java/org/springframework/mock/env/MockEnvironment.java | 2 +- .../test/web/client/response/DefaultResponseCreator.java | 2 +- .../test/web/servlet/setup/AbstractMockMvcBuilder.java | 2 +- .../test/web/servlet/setup/StandaloneMockMvcBuilder.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/spring-test/src/main/java/org/springframework/mock/env/MockEnvironment.java b/spring-test/src/main/java/org/springframework/mock/env/MockEnvironment.java index 8495e7c37b..447352f87c 100644 --- a/spring-test/src/main/java/org/springframework/mock/env/MockEnvironment.java +++ b/spring-test/src/main/java/org/springframework/mock/env/MockEnvironment.java @@ -31,7 +31,7 @@ import org.springframework.core.env.ConfigurableEnvironment; */ public class MockEnvironment extends AbstractEnvironment { - private MockPropertySource propertySource = new MockPropertySource(); + private final MockPropertySource propertySource = new MockPropertySource(); /** * Create a new {@code MockEnvironment} with a single {@link MockPropertySource}. diff --git a/spring-test/src/main/java/org/springframework/test/web/client/response/DefaultResponseCreator.java b/spring-test/src/main/java/org/springframework/test/web/client/response/DefaultResponseCreator.java index 5170d5a515..f76553c7fe 100644 --- a/spring-test/src/main/java/org/springframework/test/web/client/response/DefaultResponseCreator.java +++ b/spring-test/src/main/java/org/springframework/test/web/client/response/DefaultResponseCreator.java @@ -40,7 +40,7 @@ import org.springframework.util.Assert; */ public class DefaultResponseCreator implements ResponseCreator { - private HttpStatus statusCode; + private final HttpStatus statusCode; private byte[] content = new byte[0]; diff --git a/spring-test/src/main/java/org/springframework/test/web/servlet/setup/AbstractMockMvcBuilder.java b/spring-test/src/main/java/org/springframework/test/web/servlet/setup/AbstractMockMvcBuilder.java index dcf4b06b68..f8636fbd91 100644 --- a/spring-test/src/main/java/org/springframework/test/web/servlet/setup/AbstractMockMvcBuilder.java +++ b/spring-test/src/main/java/org/springframework/test/web/servlet/setup/AbstractMockMvcBuilder.java @@ -56,7 +56,7 @@ import org.springframework.web.context.WebApplicationContext; public abstract class AbstractMockMvcBuilder> extends MockMvcBuilderSupport implements ConfigurableMockMvcBuilder { - private List filters = new ArrayList<>(); + private final List filters = new ArrayList<>(); @Nullable private RequestBuilder defaultRequestBuilder; diff --git a/spring-test/src/main/java/org/springframework/test/web/servlet/setup/StandaloneMockMvcBuilder.java b/spring-test/src/main/java/org/springframework/test/web/servlet/setup/StandaloneMockMvcBuilder.java index ac94d5c103..7a547b5fe1 100644 --- a/spring-test/src/main/java/org/springframework/test/web/servlet/setup/StandaloneMockMvcBuilder.java +++ b/spring-test/src/main/java/org/springframework/test/web/servlet/setup/StandaloneMockMvcBuilder.java @@ -137,7 +137,7 @@ public class StandaloneMockMvcBuilder extends AbstractMockMvcBuilder placeholderValues = new HashMap<>(); + private final Map placeholderValues = new HashMap<>(); private Supplier handlerMappingFactory = RequestMappingHandlerMapping::new;