Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ObjectToObjectConverter properly handles constructors on non-public classes

Browse Source 
Issue: SPR-14304
This commit is contained in:
Juergen Hoeller
2016-10-30 22:29:53 +01:00
parent ac80ac6f8b
commit 9659bc5fe7
3 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
spring-core/src/main/java/org/springframework/core/convert/support/ObjectToObjectConverter.java
View File

@@ -102,6 +102,7 @@ final class ObjectToObjectConverter implements ConditionalGenericConverter {
}
else if (member instanceof Constructor) {
Constructor<?> ctor = (Constructor<?>) member;
ReflectionUtils.makeAccessible(ctor);
return ctor.newInstance(source);
}
}

13
spring-core/src/test/java/org/springframework/core/convert/support/DefaultConversionServiceTests.java → spring-core/src/test/java/org/springframework/core/convert/converter/DefaultConversionServiceTests.java
View File

@@ -14,7 +14,7 @@
* limitations under the License.
*/
package org.springframework.core.convert.support;
package org.springframework.core.convert.converter;
import java.awt.Color;
import java.lang.reflect.Method;
@@ -50,8 +50,7 @@ import org.springframework.core.MethodParameter;
import org.springframework.core.convert.ConversionFailedException;
import org.springframework.core.convert.ConverterNotFoundException;
import org.springframework.core.convert.TypeDescriptor;
import org.springframework.core.convert.converter.Converter;
import org.springframework.core.convert.converter.ConverterRegistry;
import org.springframework.core.convert.support.DefaultConversionService;
import org.springframework.tests.Assume;
import org.springframework.tests.TestGroup;
import org.springframework.util.ClassUtils;
@@ -61,16 +60,16 @@ import static org.hamcrest.Matchers.*;
import static org.junit.Assert.*;
/**
* Unit tests for the {@link DefaultConversionService}.
* Unit tests for {@link DefaultConversionService}.
*
* <p>For tests involving the {@link GenericConversionService}, see
* {@link GenericConversionServiceTests}.
* <p>In this package for enforcing accessibility checks to non-public classes outside
* of the {@code org.springframework.core.convert.support} implementation package.
* Only in such a scenario, {@code setAccessible(true)} is actually necessary.
*
* @author Keith Donald
* @author Juergen Hoeller
* @author Stephane Nicoll
* @author Sam Brannen
* @see GenericConversionServiceTests
*/
public class DefaultConversionServiceTests {

6
spring-core/src/test/java/org/springframework/core/convert/support/GenericConversionServiceTests.java
View File

@@ -54,17 +54,15 @@ import static org.hamcrest.Matchers.*;
import static org.junit.Assert.*;
/**
* Unit tests for the {@link GenericConversionService}.
* Unit tests for {@link GenericConversionService}.
*
* <p>For tests involving the {@link DefaultConversionService}, see
* {@link DefaultConversionServiceTests}.
* <p>In this package for access to package-local converter implementations.
*
* @author Keith Donald
* @author Juergen Hoeller
* @author Phillip Webb
* @author David Haraburda
* @author Sam Brannen
* @see DefaultConversionServiceTests
*/
public class GenericConversionServiceTests {