Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fail Gradle build for Javadoc warnings

Browse Source 
In order to catch Javadoc errors in the build, we now enable the
`Xwerror` flag for the `javadoc` tool. In addition, we now use
`Xdoclint:syntax` instead of `Xdoclint:none` in order to validate
syntax within our Javadoc.

This commit fixes all resulting Javadoc errors and warnings.

This commit also upgrades to Undertow 2.2.12.Final and fixes the
artifact names for exclusions for the Servlet and annotations APIs.

The incorrect exclusion of the Servlet API resulted in the Servlet API
being on the classpath twice for the javadoc task, which resulted in the
following warnings in previous builds.

javadoc: warning - Multiple sources of package comments found for package "javax.servlet"
javadoc: warning - Multiple sources of package comments found for package "javax.servlet.http"
javadoc: warning - Multiple sources of package comments found for package "javax.servlet.descriptor"
javadoc: warning - Multiple sources of package comments found for package "javax.servlet.annotation"

Closes gh-27480
This commit is contained in:
Sam Brannen
2021-09-29 14:02:37 +02:00
parent 040445612f
commit 96e4d3a530
81 changed files with 251 additions and 250 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spring-r2dbc/src/main/java/org/springframework/r2dbc/core/DatabaseClient.java
View File

@@ -44,9 +44,9 @@ import org.springframework.util.Assert;
* ConnectionFactory factory = …
*
* DatabaseClient client = DatabaseClient.create(factory);
* Mono&gtActor;lt actor = client.sql("select first_name, last_name from t_actor")
* .map(row -> new Actor(row.get("first_name, String.class"),
* row.get("last_name, String.class")))
* Mono<Actor> actor = client.sql("select first_name, last_name from t_actor")
* .map(row -> new Actor(row.get("first_name, String.class"),
* row.get("last_name, String.class")))
* .first();
* </pre>
*
@@ -190,7 +190,7 @@ public interface DatabaseClient extends ConnectionAccessor {
* before it is executed. For example:
* <pre class="code">
* DatabaseClient client = …;
* client.sql("SELECT book_id FROM book").filter(statement -> statement.fetchSize(100))
* client.sql("SELECT book_id FROM book").filter(statement -&gt; statement.fetchSize(100))
* </pre>
* @param filterFunction the filter to be added to the chain
*/
@@ -205,7 +205,7 @@ public interface DatabaseClient extends ConnectionAccessor {
* before it is executed. For example:
* <pre class="code">
* DatabaseClient client = …;
* client.sql("SELECT book_id FROM book").filter((statement, next) -> next.execute(statement.fetchSize(100)))
* client.sql("SELECT book_id FROM book").filter((statement, next) -&gt; next.execute(statement.fetchSize(100)))
* </pre>
* @param filter the filter to be added to the chain
*/

2
spring-r2dbc/src/main/java/org/springframework/r2dbc/core/ExecuteFunction.java
View File

@@ -36,7 +36,7 @@ import org.reactivestreams.Publisher;
* For example:
* <p><pre class="code">
* DatabaseClient.builder()
* .executeFunction(statement -> statement.execute())
* .executeFunction(statement -&gt; statement.execute())
* .build();
* </pre>
*