Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Defensively catch any exception from match attempts (for compatibility with AspectJ 1.8.10)

Browse Source 
Issue: SPR-15019
This commit is contained in:
Juergen Hoeller
2016-12-20 12:17:51 +01:00
parent f6b2a21206
commit 97ea22cb4a
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJExpressionPointcut.java
View File

@@ -28,7 +28,6 @@ import java.util.concurrent.ConcurrentHashMap;
import org.aopalliance.intercept.MethodInvocation; import org.aopalliance.intercept.MethodInvocation;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.aspectj.weaver.BCException;
import org.aspectj.weaver.patterns.NamePattern; import org.aspectj.weaver.patterns.NamePattern;
import org.aspectj.weaver.reflect.ReflectionWorld.ReflectionWorldException; import org.aspectj.weaver.reflect.ReflectionWorld.ReflectionWorldException;
import org.aspectj.weaver.reflect.ShadowMatchImpl; import org.aspectj.weaver.reflect.ShadowMatchImpl;
@@ -259,11 +258,7 @@ public class AspectJExpressionPointcut extends AbstractExpressionPointcut
} }
} }
} }
catch (BCException ex) { catch (Throwable ex) {
logger.debug("PointcutExpression matching rejected target class", ex);
}
catch (IllegalStateException ex) {
// AspectJ 1.8.10: encountered invalid signature
logger.debug("PointcutExpression matching rejected target class", ex); logger.debug("PointcutExpression matching rejected target class", ex);
} }
return false; return false;
@@ -331,7 +326,6 @@ public class AspectJExpressionPointcut extends AbstractExpressionPointcut
} }
catch (IllegalStateException ex) { catch (IllegalStateException ex) {
// No current invocation... // No current invocation...
// TODO: Should we really proceed here?
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
logger.debug("Could not access current invocation - matching with limited context: " + ex); logger.debug("Could not access current invocation - matching with limited context: " + ex);
} }
@@ -454,8 +448,8 @@ public class AspectJExpressionPointcut extends AbstractExpressionPointcut
} }
} }
} }
catch (IllegalStateException ex) { catch (Throwable ex) {
// AspectJ 1.8.10: encountered invalid signature // Possibly AspectJ 1.8.10 encountering an invalid signature
logger.debug("PointcutExpression matching rejected target method", ex); logger.debug("PointcutExpression matching rejected target method", ex);
fallbackExpression = null; fallbackExpression = null;
} }