MutableMessageHeaders serializes itself as regular MessageHeaders

Issue: SPR-15262
(cherry picked from commit 74bdcd8)
This commit is contained in:
Juergen Hoeller
2017-02-17 20:59:17 +01:00
parent 7879bdfc1d
commit 9834c42b5c
2 changed files with 48 additions and 54 deletions

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2002-2016 the original author or authors.
* Copyright 2002-2017 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -17,10 +17,8 @@
package org.springframework.messaging.support;
import java.nio.charset.Charset;
import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Map;
import java.util.UUID;
@@ -30,8 +28,8 @@ import org.junit.rules.ExpectedException;
import org.springframework.messaging.Message;
import org.springframework.messaging.MessageHeaders;
import org.springframework.util.IdGenerator;
import org.springframework.util.MimeTypeUtils;
import org.springframework.util.SerializationTestUtils;
import static org.hamcrest.CoreMatchers.*;
import static org.junit.Assert.*;
@@ -168,7 +166,7 @@ public class MessageHeaderAccessorTests {
headers.copyHeadersIfAbsent(null);
assertEquals(1, headers.getMessageHeaders().size());
assertEquals(new HashSet<>(Arrays.asList("id")), headers.getMessageHeaders().keySet());
assertEquals(Collections.singleton("id"), headers.getMessageHeaders().keySet());
}
@Test
@@ -282,12 +280,7 @@ public class MessageHeaderAccessorTests {
public void idGeneratorCustom() {
final UUID id = new UUID(0L, 23L);
MessageHeaderAccessor accessor = new MessageHeaderAccessor();
accessor.setIdGenerator(new IdGenerator() {
@Override
public UUID generateId() {
return id;
}
});
accessor.setIdGenerator(() -> id);
assertSame(id, accessor.getMessageHeaders().getId());
}
@@ -301,12 +294,7 @@ public class MessageHeaderAccessorTests {
@Test
public void idTimestampWithMutableHeaders() {
MessageHeaderAccessor accessor = new MessageHeaderAccessor();
accessor.setIdGenerator(new IdGenerator() {
@Override
public UUID generateId() {
return MessageHeaders.ID_VALUE_NONE;
}
});
accessor.setIdGenerator(() -> MessageHeaders.ID_VALUE_NONE);
accessor.setEnableTimestamp(false);
accessor.setLeaveMutable(true);
MessageHeaders headers = accessor.getMessageHeaders();
@@ -315,12 +303,7 @@ public class MessageHeaderAccessorTests {
assertNull(headers.getTimestamp());
final UUID id = new UUID(0L, 23L);
accessor.setIdGenerator(new IdGenerator() {
@Override
public UUID generateId() {
return id;
}
});
accessor.setIdGenerator(() -> id);
accessor.setEnableTimestamp(true);
accessor.setImmutable();
@@ -398,10 +381,25 @@ public class MessageHeaderAccessorTests {
assertEquals("headers={contentType=text/plain} payload=" + sb + " > 80", actual);
}
@Test
public void serializeMutableHeaders() throws Exception {
Map<String, Object> headers = new HashMap<>();
headers.put("foo", "bar");
Message<String> message = new GenericMessage<>("test", headers);
MessageHeaderAccessor mutableAccessor = MessageHeaderAccessor.getMutableAccessor(message);
mutableAccessor.setContentType(MimeTypeUtils.TEXT_PLAIN);
message = new GenericMessage<>(message.getPayload(), mutableAccessor.getMessageHeaders());
Message<?> output = (Message<?>) SerializationTestUtils.serializeAndDeserialize(message);
assertEquals("test", output.getPayload());
assertEquals("bar", output.getHeaders().get("foo"));
assertNotNull(output.getHeaders().get(MessageHeaders.CONTENT_TYPE));
}
public static class TestMessageHeaderAccessor extends MessageHeaderAccessor {
private TestMessageHeaderAccessor() {
public TestMessageHeaderAccessor() {
}
private TestMessageHeaderAccessor(Message<?> message) {