Allow consolidating config in root context with Java
Issue: SPR-11357 (backported from 4.0.1)
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright 2002-2012 the original author or authors.
|
||||
* Copyright 2002-2014 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -16,33 +16,34 @@
|
||||
|
||||
package org.springframework.web.servlet.support;
|
||||
|
||||
import static org.junit.Assert.assertEquals;
|
||||
import static org.junit.Assert.assertFalse;
|
||||
import static org.junit.Assert.assertNotNull;
|
||||
import static org.junit.Assert.assertTrue;
|
||||
|
||||
import java.util.Collections;
|
||||
import java.util.EnumSet;
|
||||
import java.util.EventListener;
|
||||
import java.util.LinkedHashMap;
|
||||
import java.util.Map;
|
||||
|
||||
import javax.servlet.DispatcherType;
|
||||
import javax.servlet.Filter;
|
||||
import javax.servlet.FilterRegistration.Dynamic;
|
||||
import javax.servlet.Servlet;
|
||||
import javax.servlet.ServletContextEvent;
|
||||
import javax.servlet.ServletContextListener;
|
||||
import javax.servlet.ServletException;
|
||||
import javax.servlet.ServletRegistration;
|
||||
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
|
||||
import org.springframework.context.annotation.Bean;
|
||||
import org.springframework.context.annotation.Configuration;
|
||||
import org.springframework.mock.web.test.MockServletConfig;
|
||||
import org.springframework.mock.web.test.MockServletContext;
|
||||
import org.springframework.web.context.WebApplicationContext;
|
||||
import org.springframework.web.context.support.AnnotationConfigWebApplicationContext;
|
||||
import org.springframework.web.filter.HiddenHttpMethodFilter;
|
||||
import org.springframework.web.servlet.DispatcherServlet;
|
||||
|
||||
import static org.junit.Assert.*;
|
||||
|
||||
/**
|
||||
* Test case for {@link AbstractAnnotationConfigDispatcherServletInitializer}.
|
||||
*
|
||||
@@ -89,11 +90,11 @@ public class AnnotationConfigDispatcherServletInitializerTests {
|
||||
assertNotNull(servlets.get(SERVLET_NAME));
|
||||
|
||||
DispatcherServlet servlet = (DispatcherServlet) servlets.get(SERVLET_NAME);
|
||||
WebApplicationContext dispatcherServletContext = servlet.getWebApplicationContext();
|
||||
((AnnotationConfigWebApplicationContext) dispatcherServletContext).refresh();
|
||||
WebApplicationContext wac = servlet.getWebApplicationContext();
|
||||
((AnnotationConfigWebApplicationContext) wac).refresh();
|
||||
|
||||
assertTrue(dispatcherServletContext.containsBean("bean"));
|
||||
assertTrue(dispatcherServletContext.getBean("bean") instanceof MyBean);
|
||||
assertTrue(wac.containsBean("bean"));
|
||||
assertTrue(wac.getBean("bean") instanceof MyBean);
|
||||
|
||||
assertEquals(1, servletRegistrations.size());
|
||||
assertNotNull(servletRegistrations.get(SERVLET_NAME));
|
||||
@@ -135,6 +136,32 @@ public class AnnotationConfigDispatcherServletInitializerTests {
|
||||
filterRegistration.getMappings().get(SERVLET_NAME));
|
||||
}
|
||||
|
||||
// SPR-11357
|
||||
@Test
|
||||
public void rootContextOnly() throws ServletException {
|
||||
initializer = new MyAnnotationConfigDispatcherServletInitializer() {
|
||||
@Override
|
||||
protected Class<?>[] getRootConfigClasses() {
|
||||
return new Class<?>[] {MyConfiguration.class};
|
||||
}
|
||||
@Override
|
||||
protected Class<?>[] getServletConfigClasses() {
|
||||
return null;
|
||||
}
|
||||
};
|
||||
|
||||
initializer.onStartup(servletContext);
|
||||
|
||||
DispatcherServlet servlet = (DispatcherServlet) servlets.get(SERVLET_NAME);
|
||||
servlet.init(new MockServletConfig(this.servletContext));
|
||||
|
||||
WebApplicationContext wac = servlet.getWebApplicationContext();
|
||||
((AnnotationConfigWebApplicationContext) wac).refresh();
|
||||
|
||||
assertTrue(wac.containsBean("bean"));
|
||||
assertTrue(wac.getBean("bean") instanceof MyBean);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void noFilters() throws ServletException {
|
||||
initializer = new MyAnnotationConfigDispatcherServletInitializer() {
|
||||
@@ -152,6 +179,12 @@ public class AnnotationConfigDispatcherServletInitializerTests {
|
||||
|
||||
private class MyMockServletContext extends MockServletContext {
|
||||
|
||||
public <T extends EventListener> void addListener(T t) {
|
||||
if (t instanceof ServletContextListener) {
|
||||
((ServletContextListener) t).contextInitialized(new ServletContextEvent(this));
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public ServletRegistration.Dynamic addServlet(String servletName, Servlet servlet) {
|
||||
servlets.put(servletName, servlet);
|
||||
@@ -169,6 +202,7 @@ public class AnnotationConfigDispatcherServletInitializerTests {
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
private static class MyAnnotationConfigDispatcherServletInitializer
|
||||
extends AbstractAnnotationConfigDispatcherServletInitializer {
|
||||
|
||||
@@ -201,13 +235,13 @@ public class AnnotationConfigDispatcherServletInitializerTests {
|
||||
protected Class<?>[] getRootConfigClasses() {
|
||||
return null;
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
|
||||
private static class MyBean {
|
||||
|
||||
}
|
||||
|
||||
|
||||
@Configuration
|
||||
@SuppressWarnings("unused")
|
||||
private static class MyConfiguration {
|
||||
@@ -219,7 +253,6 @@ public class AnnotationConfigDispatcherServletInitializerTests {
|
||||
public MyBean bean() {
|
||||
return new MyBean();
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user