Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enable leak detection in Netty 5 tests

Browse Source 
See gh-29310
This commit is contained in:
Violeta Georgieva
2022-10-12 16:17:32 +03:00
committed by rstoyanchev
parent 57bbc09fca
commit 997d1b3d7e
7 changed files with 45 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spring-core/src/test/java/org/springframework/core/codec/Netty5BufferDecoderTests.java
View File

@@ -87,7 +87,11 @@ class Netty5BufferDecoderTests extends AbstractDecoderTests<Netty5BufferDecoder>
}
private Consumer<Buffer> expectByteBuffer(Buffer expected) {
return actual -> assertThat(actual).isEqualTo(expected);
return actual -> {
try (actual; expected) {
assertThat(actual).isEqualTo(expected);
}
};
}
}

11
spring-core/src/test/java/org/springframework/core/io/buffer/DataBufferTests.java
View File

@@ -534,8 +534,12 @@ class DataBufferTests extends AbstractDataBufferAllocatingTests {
ByteBuffer result = buffer.asByteBuffer(1, 2);
assertThat(result.capacity()).isEqualTo(2);
assumeFalse(bufferFactory instanceof Netty5DataBufferFactory,
"Netty 5 does share the internal buffer");
boolean isNetty5DataBufferFactory = bufferFactory instanceof Netty5DataBufferFactory;
if (isNetty5DataBufferFactory) {
DataBufferUtils.release(buffer);
}
assumeFalse(isNetty5DataBufferFactory, "Netty 5 does share the internal buffer");
buffer.write((byte) 'c');
assertThat(result.remaining()).isEqualTo(2);
@@ -774,6 +778,9 @@ class DataBufferTests extends AbstractDataBufferAllocatingTests {
assertThat(result).isEqualTo(bytes);
if (bufferFactory instanceof Netty5DataBufferFactory) {
release(slice);
}
release(buffer);
}