More tests and some fixes. Also created tests based on the documentation examples.

org.springframework.expression/src/test/java/org/springframework/expression/spel/ConstructorInvocationTests.java

@@ -76,6 +76,31 @@ public class ConstructorInvocationTests extends ExpressionTestCase {
 		// evaluate("new String(new char[]{'h','e','l','l','o'})", "hello", String.class);
 	}
 	
+	public void testNonExistentType() {
+		evaluateAndCheckError("new FooBar()",SpelMessages.PROBLEM_LOCATING_CONSTRUCTOR);
+	}
+	
+	public void testVarargsInvocation01() {
+		// Calling 'Fruit(String... strings)'
+		evaluate("new org.springframework.expression.spel.testresources.Fruit('a','b','c').stringscount()", 3, Integer.class);
+		evaluate("new org.springframework.expression.spel.testresources.Fruit('a').stringscount()", 1, Integer.class);
+		evaluate("new org.springframework.expression.spel.testresources.Fruit().stringscount()", 0, Integer.class);
+		evaluate("new org.springframework.expression.spel.testresources.Fruit(1,2,3).stringscount()", 3, Integer.class); // all need converting to strings
+		evaluate("new org.springframework.expression.spel.testresources.Fruit(1).stringscount()", 1, Integer.class); // needs string conversion
+		evaluate("new org.springframework.expression.spel.testresources.Fruit(1,'a',3.0d).stringscount()", 3, Integer.class); // first and last need conversion
+	}
+
+	public void testVarargsInvocation02() {
+	    // Calling 'Fruit(int i, String... strings)' - returns int+length_of_strings
+		evaluate("new org.springframework.expression.spel.testresources.Fruit(5,'a','b','c').stringscount()", 8, Integer.class);
+		evaluate("new org.springframework.expression.spel.testresources.Fruit(2,'a').stringscount()", 3, Integer.class);
+		evaluate("new org.springframework.expression.spel.testresources.Fruit(4).stringscount()", 4, Integer.class);
+		evaluate("new org.springframework.expression.spel.testresources.Fruit(8,2,3).stringscount()", 10, Integer.class);
+		evaluate("new org.springframework.expression.spel.testresources.Fruit(9).stringscount()", 9, Integer.class);
+		evaluate("new org.springframework.expression.spel.testresources.Fruit(2,'a',3.0d).stringscount()", 4, Integer.class);
+		evaluate("new org.springframework.expression.spel.testresources.Fruit(8,stringArrayOfThreeItems).stringscount()", 11, Integer.class);
+	}
+	
 	/*
 	 * These tests are attempting to call constructors where we need to widen or convert the argument in order to
 	 * satisfy a suitable constructor.

org.springframework.expression/src/test/java/org/springframework/expression/spel/EvaluationTests.java

@@ -61,21 +61,25 @@ public class EvaluationTests extends ExpressionTestCase {
 	// evaluate("name in {null, \"Anonymous\"}", "false", Boolean.class);
 	// }
 	//
-	// public void testRelOperatorsBetween01() {
-	// evaluate("1 between {1, 5}", "true", Boolean.class);
-	// }
+	public void testRelOperatorsBetween01() {
+		evaluate("1 between listOneFive", "true", Boolean.class);
+		// evaluate("1 between {1, 5}", "true", Boolean.class); // no inline list building at the moment
+	}
 	//
 	// public void testRelOperatorsBetween02() {
 	// evaluate("'efg' between {'abc', 'xyz'}", "true", Boolean.class);
 	// }
 	//
-	// public void testRelOperatorsBetweenErrors01() {
-	// evaluateAndCheckError("1 between T(String)", SpelMessages.BETWEEN_RIGHT_OPERAND_MUST_BE_TWO_ELEMENT_LIST, 12);
-	// }
+	public void testRelOperatorsBetweenErrors01() {
+		 evaluateAndCheckError("1 between T(String)", SpelMessages.BETWEEN_RIGHT_OPERAND_MUST_BE_TWO_ELEMENT_LIST, 12);
+	}
 	//
 	// public void testRelOperatorsBetweenErrors02() {
 	// evaluateAndCheckError("'abc' between {5,7}", SpelMessages.NOT_COMPARABLE, 6);
 	// }
+	public void testRelOperatorsBetweenErrors03() {
+		 evaluateAndCheckError("1 between listOfNumbersUpToTen", SpelMessages.BETWEEN_RIGHT_OPERAND_MUST_BE_TWO_ELEMENT_LIST, 10);
+	}
 
 	public void testRelOperatorsIs01() {
 		evaluate("'xyz' instanceof T(int)", "false", Boolean.class);
@@ -343,18 +347,30 @@ public class EvaluationTests extends ExpressionTestCase {
 	// evaluate("{1,2,3,4,5,6,7,8,9,10}.?{$index > 5 }", "[7, 8, 9, 10]", ArrayList.class);
 	// }
 	 
-	 public void testSelection03() {
+	public void testSelection03() {
 		evaluate("mapOfNumbersUpToTen.?{key>5}.size()", "5", Integer.class);
-	 }
+	}
+
+	public void testSelection04() {
+		evaluateAndCheckError("mapOfNumbersUpToTen.?{'hello'}.size()",SpelMessages.RESULT_OF_SELECTION_CRITERIA_IS_NOT_BOOLEAN);
+	}
 
 	public void testSelectionFirst01() {
 		evaluate("listOfNumbersUpToTen.^{#isEven(#this) == 'y'}", "2", Integer.class);
 	}
-	
+
+	public void testSelectionFirst02() {
+		evaluate("mapOfNumbersUpToTen.^{key>5}.size()", "1", Integer.class);
+	}
+
 	public void testSelectionLast01() {
 		evaluate("listOfNumbersUpToTen.${#isEven(#this) == 'y'}", "10", Integer.class);
 	}
 
+	public void testSelectionLast02() {
+		evaluate("mapOfNumbersUpToTen.${key>5}.size()", "1", Integer.class);
+	}
+
 	public void testSelectionAST() throws Exception {
 		SpelExpression expr = (SpelExpression)parser.parseExpression("'abc'.^{true}");
 		assertEquals("'abc'.^{true}",expr.toStringAST());
@@ -411,6 +427,10 @@ public class EvaluationTests extends ExpressionTestCase {
 	public void testIndexer03() {
 		evaluate("'christian'[8]", "n", String.class);
 	}
+	
+	public void testIndexerError() {
+		evaluateAndCheckError("new org.springframework.expression.spel.testresources.Inventor().inventions[1]",SpelMessages.CANNOT_INDEX_INTO_NULL_VALUE);
+	}
 
 	// Bean references
 	// public void testReferences01() {

org.springframework.expression/src/test/java/org/springframework/expression/spel/ExpressionTestCase.java

@@ -27,6 +27,7 @@ import org.springframework.expression.ParseException;
 import org.springframework.expression.spel.antlr.SpelAntlrExpressionParser;
 import org.springframework.expression.spel.support.StandardEvaluationContext;
 
+///CLOVER:OFF
 /**
  * Common superclass for expression tests.
  *

org.springframework.expression/src/test/java/org/springframework/expression/spel/HelperTests.java

@@ -37,4 +37,9 @@ public class HelperTests extends ExpressionTestCase {
 		assertEquals("goo(java.lang.String,int[])",FormatHelper.formatMethodForMessage("goo", String.class,new int[1].getClass()));
 		assertEquals("boo()",FormatHelper.formatMethodForMessage("boo"));
 	}
+	
+//	public void testReflectionHelper01() {
+//		ReflectionHelper.convertArguments(parameterTypes, isVarargs, converter, arguments)
+////		ReflectionHelper.setupArgumentsForVarargsInvocation(;, args)
+//	}
 }

org.springframework.expression/src/test/java/org/springframework/expression/spel/MethodInvocationTests.java

@@ -85,5 +85,9 @@ public class MethodInvocationTests extends ExpressionTestCase {
 		evaluate("aVarargsMethod2(2,'a',3.0d)", 4, Integer.class);
 		// evaluate("aVarargsMethod2(8,new String[]{'a','b','c'})", 11, Integer.class);
 	}
+	
+	public void testInvocationOnNullContextObject() {
+		evaluateAndCheckError("null.toString()",SpelMessages.ATTEMPTED_METHOD_CALL_ON_NULL_CONTEXT_OBJECT);
+	}
 
 }

org.springframework.expression/src/test/java/org/springframework/expression/spel/OperatorOverloaderTests.java

@@ -0,0 +1,65 @@
+/*
+ * Copyright 2002-2009 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.expression.spel;
+
+import org.springframework.expression.EvaluationException;
+import org.springframework.expression.Operation;
+import org.springframework.expression.OperatorOverloader;
+import org.springframework.expression.spel.support.StandardEvaluationContext;
+
+/**
+ * Test providing operator support
+ * 
+ * @author Andy Clement
+ */
+public class OperatorOverloaderTests extends ExpressionTestCase {
+
+	static class StringAndBooleanAddition implements OperatorOverloader {
+
+		public Object operate(Operation operation, Object leftOperand, Object rightOperand) throws EvaluationException {
+			if (operation==Operation.ADD) {
+				return ((String)leftOperand)+((Boolean)rightOperand).toString();
+			} else {
+				return leftOperand;
+			}
+		}
+
+		public boolean overridesOperation(Operation operation, Object leftOperand, Object rightOperand)
+				throws EvaluationException {
+			if (leftOperand instanceof String && rightOperand instanceof Boolean) {
+				return true;
+			}
+			return false;
+			
+		}
+		
+	}
+	
+	public void testSimpleOperations() throws Exception {
+		// no built in support for this:
+		evaluateAndCheckError("'abc'+true",SpelMessages.OPERATOR_NOT_SUPPORTED_BETWEEN_TYPES);
+
+		StandardEvaluationContext eContext = TestScenarioCreator.getTestEvaluationContext();
+		eContext.setOperatorOverloader(new StringAndBooleanAddition());
+
+		SpelExpression expr = (SpelExpression)parser.parseExpression("'abc'+true");
+		assertEquals("abctrue",expr.getValue(eContext));
+
+		expr = (SpelExpression)parser.parseExpression("'abc'-true");
+		assertEquals("abc",expr.getValue(eContext));
+	}
+}

org.springframework.expression/src/test/java/org/springframework/expression/spel/OperatorTests.java

@@ -233,6 +233,9 @@ public class OperatorTests extends ExpressionTestCase {
 		
 		node = getOperatorNode((SpelExpression)parser.parseExpression("3>=4"));
 		assertEquals(">=",node.getOperatorName());
+
+		node = getOperatorNode((SpelExpression)parser.parseExpression("3 between 4"));
+		assertEquals("between",node.getOperatorName());
 	}
 	
 	public void testOperatorOverloading() {

org.springframework.expression/src/test/java/org/springframework/expression/spel/PerformanceTests.java

@@ -35,6 +35,8 @@ public class PerformanceTests extends TestCase {
 	private static SpelAntlrExpressionParser parser = new SpelAntlrExpressionParser();
 	private static EvaluationContext eContext = TestScenarioCreator.getTestEvaluationContext();
 
+	private static final boolean DEBUG = false;
+	
 	public void testPerformanceOfPropertyAccess() throws Exception {
 		long starttime = 0;
 		long endtime = 0;
@@ -58,7 +60,9 @@ public class PerformanceTests extends TestCase {
 		}
 		endtime = System.currentTimeMillis();
 		long freshParseTime = endtime - starttime;
-		System.out.println(freshParseTime);
+		if (DEBUG) {
+			System.out.println("PropertyAccess: Time for parsing and evaluation x 10000: "+freshParseTime+"ms");
+		}
 
 		Expression expr = parser.parseExpression("placeOfBirth.city");
 		if (expr == null) {
@@ -70,7 +74,9 @@ public class PerformanceTests extends TestCase {
 		}
 		endtime = System.currentTimeMillis();
 		long reuseTime = endtime - starttime;
-		System.out.println(reuseTime);
+		if (DEBUG) {
+			System.out.println("PropertyAccess: Time for just evaluation x 10000: "+reuseTime+"ms");
+		}
 		if (reuseTime > freshParseTime) {
 			System.out.println("Fresh parse every time, ITERATIONS iterations = " + freshParseTime + "ms");
 			System.out.println("Reuse SpelExpression, ITERATIONS iterations = " + reuseTime + "ms");
@@ -101,7 +107,9 @@ public class PerformanceTests extends TestCase {
 		}
 		endtime = System.currentTimeMillis();
 		long freshParseTime = endtime - starttime;
-		System.out.println(freshParseTime);
+		if (DEBUG) {
+			System.out.println("MethodExpression: Time for parsing and evaluation x 10000: "+freshParseTime+"ms");
+		}
 
 		Expression expr = parser.parseExpression("getPlaceOfBirth().getCity()");
 		if (expr == null) {
@@ -113,7 +121,10 @@ public class PerformanceTests extends TestCase {
 		}
 		endtime = System.currentTimeMillis();
 		long reuseTime = endtime - starttime;
-		System.out.println(reuseTime);
+		if (DEBUG) {
+			System.out.println("MethodExpression: Time for just evaluation x 10000: "+reuseTime+"ms");
+		}
+
 		if (reuseTime > freshParseTime) {
 			System.out.println("Fresh parse every time, ITERATIONS iterations = " + freshParseTime + "ms");
 			System.out.println("Reuse SpelExpression, ITERATIONS iterations = " + reuseTime + "ms");

org.springframework.expression/src/test/java/org/springframework/expression/spel/PropertyAccessTests.java

@@ -41,6 +41,10 @@ public class PropertyAccessTests extends ExpressionTestCase {
 		evaluate("placeOfBirth.city", "SmilJan", String.class);
 	}
 
+	public void testSimpleAccess03() {
+		evaluate("stringArrayOfThreeItems.length", "3", Integer.class);
+	}
+
 	public void testNonExistentPropertiesAndMethods() {
 		// madeup does not exist as a property
 		evaluateAndCheckError("madeup", SpelMessages.PROPERTY_OR_FIELD_NOT_FOUND, 0);
@@ -79,7 +83,7 @@ public class PropertyAccessTests extends ExpressionTestCase {
 		} catch (EvaluationException e) {
 			// success - message will be: EL1063E:(pos 20): A problem occurred whilst attempting to set the property
 			// 'flibbles': 'Cannot set flibbles to an object of type 'class java.lang.String''
-			System.out.println(e.getMessage());
+			// System.out.println(e.getMessage());
 		}
 	}
 

org.springframework.expression/src/test/java/org/springframework/expression/spel/ScenariosForSpringSecurity.java

@@ -33,6 +33,7 @@ import org.springframework.expression.spel.antlr.SpelAntlrExpressionParser;
 import org.springframework.expression.spel.support.ReflectionHelper;
 import org.springframework.expression.spel.support.StandardEvaluationContext;
 
+///CLOVER:OFF
 /**
  * Spring Security scenarios from https://wiki.springsource.com/display/SECURITY/Spring+Security+Expression-based+Authorization
  * 

org.springframework.expression/src/test/java/org/springframework/expression/spel/SetValueTests.java

@@ -47,7 +47,11 @@ public class SetValueTests extends ExpressionTestCase {
 	public void testSetArrayElementValue() {
 		setValue("inventions[0]", "Just the telephone");
 	}
-	
+
+	public void testSetElementOfNull() {
+		setValueExpectError("new org.springframework.expression.spel.testresources.Inventor().inventions[1]",SpelMessages.CANNOT_INDEX_INTO_NULL_VALUE);
+	}
+
 	public void testSetArrayElementValueAllPrimitiveTypes() {
 		setValue("arrayContainer.ints[1]", 3);
 		setValue("arrayContainer.floats[1]", 3.0f);

org.springframework.expression/src/test/java/org/springframework/expression/spel/SpelDocumentationTests.java

@@ -0,0 +1,480 @@
+/*
+ * Copyright 2002-2009 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.expression.spel;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Date;
+import java.util.GregorianCalendar;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import org.springframework.expression.EvaluationContext;
+import org.springframework.expression.Expression;
+import org.springframework.expression.ExpressionParser;
+import org.springframework.expression.ParserContext;
+import org.springframework.expression.spel.antlr.SpelAntlrExpressionParser;
+import org.springframework.expression.spel.support.StandardEvaluationContext;
+import org.springframework.expression.spel.testresources.Inventor;
+import org.springframework.expression.spel.testresources.PlaceOfBirth;
+
+/**
+ * Test the examples specified in the documentation.
+ * 
+ * NOTE: any outgoing changes from this file upon synchronizing with the repo may indicate that
+ * you need to update the documentation too !
+ * 
+ * @author Andy Clement
+ */
+public class SpelDocumentationTests extends ExpressionTestCase {
+
+	static Inventor tesla ;
+	static Inventor pupin ;
+
+	
+	
+	static {
+		GregorianCalendar c = new GregorianCalendar();
+		c.set(1856, 7, 9);
+		tesla = new Inventor("Nikola Tesla", c.getTime(), "Serbian");
+		tesla.setPlaceOfBirth(new PlaceOfBirth("SmilJan"));
+		tesla.setInventions(new String[] { "Telephone repeater", "Rotating magnetic field principle",
+				"Polyphase alternating-current system", "Induction motor", "Alternating-current power transmission",
+				"Tesla coil transformer", "Wireless communication", "Radio", "Fluorescent lights" });
+
+		pupin = new Inventor("Pupin", c.getTime(), "Idvor");
+		pupin.setPlaceOfBirth(new PlaceOfBirth("Idvor"));
+		
+	}
+	static class IEEE {
+		private String name;
+		
+		
+		public Inventor[] Members = new Inventor[1];
+		public List Members2 = new ArrayList();
+		public Map<String,Object> officers = new HashMap<String,Object>();
+		IEEE() {
+			officers.put("president",pupin);
+			List linv = new ArrayList();
+			linv.add(tesla);
+			officers.put("advisors",linv);
+			Members2.add(tesla);
+			Members2.add(pupin);
+		}
+		
+		public boolean isMember(String name) {
+			return true;
+		}
+		
+		public String getName() { return name; }
+		public void setName(String n) { this.name = n; }
+	}
+	
+	public void testMethodInvocation() {
+		evaluate("'Hello World'.concat('!')","Hello World!",String.class);
+	}
+	
+	public void testBeanPropertyAccess() {
+		evaluate("new String('Hello World'.bytes)","Hello World",String.class);
+	}
+	
+	public void testArrayLengthAccess() {
+		evaluate("'Hello World'.bytes.length",11,Integer.class);
+	}
+
+	public void testRootObject() throws Exception {
+		GregorianCalendar c = new GregorianCalendar();
+		c.set(1856, 7, 9);
+
+		//  The constructor arguments are name, birthday, and nationaltiy.
+		Inventor tesla = new Inventor("Nikola Tesla", c.getTime(), "Serbian");
+
+		ExpressionParser parser = new SpelAntlrExpressionParser();
+		Expression exp = parser.parseExpression("name");
+
+		EvaluationContext context = new StandardEvaluationContext();
+		context.setRootObject(tesla);
+
+		String name = (String) exp.getValue(context);
+		assertEquals("Nikola Tesla",name);
+	}	
+	
+	public void testEqualityCheck() throws Exception {
+
+		ExpressionParser parser = new SpelAntlrExpressionParser();
+	
+		EvaluationContext context = new StandardEvaluationContext();
+		context.setRootObject(tesla);
+
+		Expression exp = parser.parseExpression("name == 'Nikola Tesla'");
+		boolean isEqual = exp.getValue(context, Boolean.class);  // evaluates to true
+		assertTrue(isEqual);
+	}
+	
+	// Section 7.4.1
+	
+	public void testXMLBasedConfig() {
+		 evaluate("(T(java.lang.Math).random() * 100.0 )>0",true,Boolean.class);
+	}
+	
+	// Section 7.5
+	public void testLiterals() throws Exception {
+		ExpressionParser parser = new SpelAntlrExpressionParser();
+
+		String helloWorld = (String) parser.parseExpression("'Hello World'").getValue(); // evals to "Hello World"
+		assertEquals("Hello World",helloWorld);
+		
+		double avogadrosNumber  = (Double) parser.parseExpression("6.0221415E+23").getValue();  
+		assertEquals(6.0221415E+23,avogadrosNumber);
+		
+		int maxValue = (Integer) parser.parseExpression("0x7FFFFFFF").getValue();  // evals to 2147483647
+		assertEquals(Integer.MAX_VALUE,maxValue);
+		
+		boolean trueValue = (Boolean) parser.parseExpression("true").getValue();
+		assertTrue(trueValue);
+		
+		Object nullValue = parser.parseExpression("null").getValue();
+		assertNull(nullValue);
+	}
+
+	public void testPropertyAccess() throws Exception {
+		EvaluationContext context = TestScenarioCreator.getTestEvaluationContext();
+		int year = (Integer) parser.parseExpression("Birthdate.Year + 1900").getValue(context); // 1856
+		assertEquals(1856,year);
+		
+		String city = (String) parser.parseExpression("placeOfBirth.City").getValue(context);
+		assertEquals("SmilJan",city);
+	}
+	
+	public void testPropertyNavigation() throws Exception {
+		ExpressionParser parser = new SpelAntlrExpressionParser();
+
+		// Inventions Array
+		StandardEvaluationContext teslaContext = TestScenarioCreator.getTestEvaluationContext();
+//		teslaContext.setRootObject(tesla);
+
+		// evaluates to "Induction motor"
+		String invention = parser.parseExpression("inventions[3]").getValue(teslaContext, String.class); 
+		assertEquals("Induction motor",invention);
+
+		// Members List
+		StandardEvaluationContext societyContext = new StandardEvaluationContext();
+		IEEE ieee = new IEEE();
+		ieee.Members[0]= tesla;
+		societyContext.setRootObject(ieee);
+
+		// evaluates to "Nikola Tesla"
+		String name = parser.parseExpression("Members[0].Name").getValue(societyContext, String.class);
+		assertEquals("Nikola Tesla",name);
+		
+		// List and Array navigation
+		// evaluates to "Wireless communication"
+		invention = parser.parseExpression("Members[0].Inventions[6]").getValue(societyContext, String.class);
+		assertEquals("Wireless communication",invention);
+	}
+	
+	
+	public void testDictionaryAccess() throws Exception {
+		StandardEvaluationContext societyContext = new StandardEvaluationContext();
+		societyContext.setRootObject(new IEEE());
+		// Officer's Dictionary
+//		Inventor pupin = parser.parseExpression("officers['president']").getValue(societyContext, Inventor.class);
+//
+//		// evaluates to "Idvor"
+//		String city = parser.parseExpression("officers['president'].PlaceOfBirth.city").getValue(societyContext, String.class);
+
+		// setting values
+		Inventor i = parser.parseExpression("officers['advisors'][0]").getValue(societyContext,Inventor.class);
+		assertEquals("Nikola Tesla",i.getName());
+		
+		parser.parseExpression("officers['advisors'][0].PlaceOfBirth.Country").setValue(societyContext, "Croatia");
+
+	}
+	
+	// 7.5.3
+
+	public void testMethodInvocation2() throws Exception {
+		// string literal, evaluates to "bc"
+		String c = parser.parseExpression("'abc'.substring(1, 3)").getValue(String.class);
+		assertEquals("bc",c);
+		
+		StandardEvaluationContext societyContext = new StandardEvaluationContext();
+		societyContext.setRootObject(new IEEE());
+		// evaluates to true
+		boolean isMember = parser.parseExpression("isMember('Mihajlo Pupin')").getValue(societyContext, Boolean.class);
+		assertTrue(isMember);
+	}
+	
+	// 7.5.4.1
+	
+	public void testRelationalOperators() throws Exception {
+		boolean result = parser.parseExpression("2 == 2").getValue(Boolean.class);
+		assertTrue(result);
+		// evaluates to false
+		result = parser.parseExpression("2 < -5.0").getValue(Boolean.class);
+		assertFalse(result);
+		
+		// evaluates to true
+		result = parser.parseExpression("'black' < 'block'").getValue(Boolean.class);
+		assertTrue(result);
+	}
+	
+	public void testOtherOperators() throws Exception {
+		// evaluates to false
+		boolean falseValue = parser.parseExpression("'xyz' instanceof T(int)").getValue(Boolean.class);
+		assertFalse(falseValue);
+		
+		// evaluates to true
+		boolean trueValue = parser.parseExpression("'5.00' matches '^-?\\d+(\\.\\d{2})?$'").getValue(Boolean.class);
+		assertTrue(trueValue);
+
+		//evaluates to false
+		falseValue = parser.parseExpression("'5.0067' matches '^-?\\d+(\\.\\d{2})?$'").getValue(Boolean.class);
+		assertFalse(falseValue);
+	}
+	
+	// 7.5.4.2
+	
+	public void testLogicalOperators() throws Exception {
+
+		StandardEvaluationContext societyContext = new StandardEvaluationContext();
+		societyContext.setRootObject(new IEEE());
+		
+		// -- AND --
+
+		// evaluates to false
+		boolean falseValue = parser.parseExpression("true and false").getValue(Boolean.class);
+		assertFalse(falseValue);
+		// evaluates to true
+		String expression =  "isMember('Nikola Tesla') and isMember('Mihajlo Pupin')";
+		boolean trueValue = parser.parseExpression(expression).getValue(societyContext, Boolean.class);
+
+		// -- OR --
+
+		// evaluates to true
+		trueValue = parser.parseExpression("true or false").getValue(Boolean.class);
+		assertTrue(trueValue);
+		
+		// evaluates to true
+		expression =  "isMember('Nikola Tesla') or isMember('Albert Einstien')";
+		trueValue = parser.parseExpression(expression).getValue(societyContext, Boolean.class);
+		assertTrue(trueValue);
+		
+		// -- NOT --
+
+		// evaluates to false
+		falseValue = parser.parseExpression("!true").getValue(Boolean.class);
+		assertFalse(falseValue);
+
+
+		// -- AND and NOT --
+		expression =  "isMember('Nikola Tesla') and !isMember('Mihajlo Pupin')";
+		falseValue = parser.parseExpression(expression).getValue(societyContext, Boolean.class);
+		assertFalse(falseValue);
+	}
+	
+	// 7.5.4.3
+	
+	public void testNumericalOperators() throws Exception {
+		// Addition
+		int two = parser.parseExpression("1 + 1").getValue(Integer.class); // 2
+		assertEquals(2,two);
+		
+		String testString = parser.parseExpression("'test' + ' ' + 'string'").getValue(String.class); // 'test string'
+		assertEquals("test string",testString);
+		
+		// Subtraction
+		int four =  parser.parseExpression("1 - -3").getValue(Integer.class); // 4
+		assertEquals(4,four);
+		
+		double d = parser.parseExpression("1000.00 - 1e4").getValue(Double.class); // -9000
+		assertEquals(-9000.0d,d);
+		
+		// Multiplication
+		int six =  parser.parseExpression("-2 * -3").getValue(Integer.class); // 6
+		assertEquals(6,six);
+		
+		double twentyFour = parser.parseExpression("2.0 * 3e0 * 4").getValue(Double.class); // 24.0
+		assertEquals(24.0d,twentyFour);
+		
+		// Division
+		int minusTwo =  parser.parseExpression("6 / -3").getValue(Integer.class); // -2
+		assertEquals(-2,minusTwo);
+		
+		double one = parser.parseExpression("8.0 / 4e0 / 2").getValue(Double.class); // 1.0
+		assertEquals(1.0d,one);
+
+		// Modulus
+		int three =  parser.parseExpression("7 % 4").getValue(Integer.class); // 3
+		assertEquals(3,three);
+		
+		int oneInt = parser.parseExpression("8 / 5 % 2").getValue(Integer.class); // 1
+		assertEquals(1,oneInt);
+		
+		// Operator precedence
+		int minusTwentyOne = parser.parseExpression("1+2-3*8").getValue(Integer.class); // -21
+		assertEquals(-21,minusTwentyOne);
+	}
+
+	// 7.5.5
+	
+	public void testAssignment() throws Exception {
+		Inventor inventor = new Inventor();		
+		StandardEvaluationContext inventorContext = new StandardEvaluationContext();
+		inventorContext.setRootObject(inventor);
+
+		parser.parseExpression("foo").setValue(inventorContext, "Alexander Seovic2");
+
+		assertEquals("Alexander Seovic2",parser.parseExpression("foo").getValue(inventorContext,String.class));
+		// alternatively
+
+		String aleks = parser.parseExpression("foo = 'Alexandar Seovic'").getValue(inventorContext, String.class);
+		assertEquals("Alexandar Seovic",parser.parseExpression("foo").getValue(inventorContext,String.class));
+		assertEquals("Alexandar Seovic",aleks);
+	}
+	
+	// 7.5.6
+	
+	public void testTypes() throws Exception {
+		Class dateClass = parser.parseExpression("T(java.util.Date)").getValue(Class.class);
+		assertEquals(Date.class,dateClass);
+		boolean trueValue = parser.parseExpression("T(java.math.RoundingMode).CEILING < T(java.math.RoundingMode).FLOOR").getValue(Boolean.class);
+		assertTrue(trueValue);
+	}
+	
+	// 7.5.7
+	
+	public void testConstructors() throws Exception {
+		StandardEvaluationContext societyContext = new StandardEvaluationContext();
+		societyContext.setRootObject(new IEEE());
+		Inventor einstein = 
+			   parser.parseExpression("new org.springframework.expression.spel.testresources.Inventor('Albert Einstein',new java.util.Date(), 'German')").getValue(Inventor.class);
+		assertEquals("Albert Einstein", einstein.getName());
+		//create new inventor instance within add method of List
+		parser.parseExpression("Members2.add(new org.springframework.expression.spel.testresources.Inventor('Albert Einstein', 'German'))").getValue(societyContext);
+	}
+	
+	// 7.5.8
+	
+	public void testVariables() throws Exception {
+		Inventor tesla = new Inventor("Nikola Tesla", "Serbian");
+		StandardEvaluationContext context = new StandardEvaluationContext();
+		context.setVariable("newName", "Mike Tesla");
+
+		context.setRootObject(tesla);
+
+		parser.parseExpression("foo = #newName").getValue(context);
+
+		assertEquals("Mike Tesla",tesla.getFoo());
+	}
+	
+	public void testSpecialVariables() throws Exception {
+		// create an array of integers
+		List<Integer> primes = new ArrayList<Integer>();
+		primes.addAll(Arrays.asList(2,3,5,7,11,13,17));
+
+		// create parser and set variable 'primes' as the array of integers
+		ExpressionParser parser = new SpelAntlrExpressionParser();
+		StandardEvaluationContext context = new StandardEvaluationContext();
+		context.setVariable("primes",primes);
+
+		// all prime numbers > 10 from the list (using selection ?{...})
+		List<Integer> primesGreaterThanTen = (List<Integer>) parser.parseExpression("#primes.?{#this>10}").getValue(context);
+		assertEquals("[11, 13, 17]",primesGreaterThanTen.toString());
+	}
+	
+	// 7.5.9
+	
+	public void testFunctions() throws Exception {
+		ExpressionParser parser = new SpelAntlrExpressionParser();
+		StandardEvaluationContext context = new StandardEvaluationContext();
+
+		context.registerFunction("reverseString", 
+		                         StringUtils.class.getDeclaredMethod("reverseString", new Class[] { String.class }));
+
+		String helloWorldReversed = parser.parseExpression("#reverseString('hello world')").getValue(context, String.class);
+		assertEquals("dlrow olleh",helloWorldReversed);
+	}
+	
+	// 7.5.10
+	
+	public void testTernary() throws Exception {
+		String falseString = parser.parseExpression("false ? 'trueExp' : 'falseExp'").getValue(String.class);
+		assertEquals("falseExp",falseString);
+		
+		StandardEvaluationContext societyContext = new StandardEvaluationContext();
+		societyContext.setRootObject(new IEEE());
+
+		
+		parser.parseExpression("Name").setValue(societyContext, "IEEE");
+		societyContext.setVariable("queryName", "Nikola Tesla");
+
+		String expression = "isMember(#queryName)? #queryName + ' is a member of the ' " + 
+		             "+ Name + ' Society' : #queryName + ' is not a member of the ' + Name + ' Society'";
+
+		String queryResultString = parser.parseExpression(expression).getValue(societyContext, String.class);
+		assertEquals("Nikola Tesla is a member of the IEEE Society",queryResultString);
+		// queryResultString = "Nikola Tesla is a member of the IEEE Society"
+	}
+	
+	// 7.5.11
+	
+	public void testSelection() throws Exception {
+		StandardEvaluationContext societyContext = new StandardEvaluationContext();
+		societyContext.setRootObject(new IEEE());
+		List<Inventor> list = (List<Inventor>) parser.parseExpression("Members2.?{nationality == 'Serbian'}").getValue(societyContext);
+		assertEquals(1,list.size());
+		assertEquals("Nikola Tesla",list.get(0).getName());
+	}
+	
+	// 7.5.12
+	
+	public void testTemplating() throws Exception {
+		String randomPhrase = 
+			   parser.parseExpression("random number is ${T(java.lang.Math).random()}", new TemplatedParserContext()).getValue(String.class);
+		assertTrue(randomPhrase.startsWith("random number"));
+	}
+	
+	static class TemplatedParserContext implements ParserContext {
+
+		  public String getExpressionPrefix() {
+		    return "${";
+		  }
+
+		  public String getExpressionSuffix() {
+		    return "}";
+		  }
+		  
+		  public boolean isTemplate() {
+		    return true;
+		  }
+	}
+	
+	static class StringUtils {
+
+		  public static String reverseString(String input) {
+		    StringBuilder backwards = new StringBuilder();
+		    for (int i = 0; i < input.length(); i++) {
+		      backwards.append(input.charAt(input.length() - 1 - i));
+		    }
+		    return backwards.toString();
+		  }
+	}
+	
+}
+

org.springframework.expression/src/test/java/org/springframework/expression/spel/TestScenarioCreator.java

@@ -22,6 +22,7 @@ import org.springframework.expression.spel.support.StandardEvaluationContext;
 import org.springframework.expression.spel.testresources.Inventor;
 import org.springframework.expression.spel.testresources.PlaceOfBirth;
 
+///CLOVER:OFF
 /**
  * Builds an evaluation context for test expressions. Features of the test evaluation context are:
  * <ul>

org.springframework.expression/src/test/java/org/springframework/expression/spel/testresources/Fruit.java

@@ -10,7 +10,8 @@ public class Fruit {
 	public String name; // accessible as property field
 	public Color color; // accessible as property through getter/setter
 	public String colorName; // accessible as property through getter/setter
-
+	public int stringscount = -1;
+	
 	public Fruit(String name, Color color, String colorName) {
 		this.name = name;
 		this.color = color;
@@ -20,6 +21,18 @@ public class Fruit {
 	public Color getColor() {
 		return color;
 	}
+	
+	public Fruit(String... strings) {
+		stringscount = strings.length;
+	}
+	
+	public Fruit(int i, String... strings) {
+		stringscount = i + strings.length;
+	}
+	
+	public int stringscount() {
+		return stringscount;
+	}
 
 	public String toString() {
 		return "A" + (colorName.startsWith("o") ? "n " : " ") + colorName + " " + name;

org.springframework.expression/src/test/java/org/springframework/expression/spel/testresources/Inventor.java

@@ -12,7 +12,7 @@ public class Inventor {
 	private String name;
 	public String publicName;
 	private PlaceOfBirth placeOfBirth;
-	Date birthdate;
+	private Date birthdate;
 	private int sinNumber;
 	private String nationality;
 	private String[] inventions;
@@ -29,6 +29,9 @@ public class Inventor {
 	public Map<String,Boolean> mapOfStringToBoolean = new HashMap<String,Boolean>();
 	public Map<Integer,String> mapOfNumbersUpToTen = new HashMap<Integer,String>();
 	public List<Integer> listOfNumbersUpToTen = new ArrayList<Integer>();
+	public List<Integer> listOneFive = new ArrayList<Integer>();
+	public String[] stringArrayOfThreeItems = new String[]{"1","2","3"};
+	private String foo;
 	
 	public Inventor(String name, Date birthdate, String nationality) {
 		this.name = name;
@@ -43,6 +46,8 @@ public class Inventor {
 		testMap.put("friday", "freitag");
 		testMap.put("saturday", "samstag");
 		testMap.put("sunday", "sonntag");
+		listOneFive.add(1);
+		listOneFive.add(5);
 		booleanList.add(false);
 		booleanList.add(false);
 		listOfNumbersUpToTen.add(1);
@@ -148,4 +153,11 @@ public class Inventor {
 	public void setSomeProperty(boolean b) {
 		this.accessedThroughGetSet = b;
 	}
+	
+	public Date getBirthdate() { return birthdate;}
+
+	public String getFoo() { return foo; }
+	public void setFoo(String s) { foo = s; }
+
+	public String getNationality() { return nationality; }
 }

org.springframework.expression/src/test/java/org/springframework/expression/spel/testresources/PlaceOfBirth.java

@@ -4,6 +4,8 @@ package org.springframework.expression.spel.testresources;
 public class PlaceOfBirth {
 	private String city;
 	
+	public String Country;
+	
 	@Override
 	public String toString() {return "PlaceOfBirth("+city+")";}