Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Never use 'this.' when accessing loggers

Browse Source 
Ensure that `this.` is never used when accessing loggers.

Issue: SPR-16968
This commit is contained in:
Phillip Webb
2018-06-25 11:13:17 -07:00
committed by Juergen Hoeller
parent 0b53c1096a
commit 9de3689f63
14 changed files with 57 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spring-core/src/main/java/org/springframework/core/SimpleAliasRegistry.java
View File

@@ -69,7 +69,7 @@ public class SimpleAliasRegistry implements AliasRegistry {
throw new IllegalStateException("Cannot define alias '" + alias + "' for name '" +
name + "': It is already registered for name '" + registeredName + "'.");
}
if (this.logger.isInfoEnabled()) {
if (logger.isInfoEnabled()) {
logger.info("Overriding alias '" + alias + "' definition for registered name '" +
registeredName + "' with new target name '" + name + "'");
}

6
spring-core/src/main/java/org/springframework/util/CommonsLogWriter.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright 2002-2012 the original author or authors.
* Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -45,7 +45,7 @@ public class CommonsLogWriter extends Writer {
public void write(char ch) {
if (ch == '\n' && this.buffer.length() > 0) {
this.logger.debug(this.buffer.toString());
logger.debug(this.buffer.toString());
this.buffer.setLength(0);
}
else {
@@ -58,7 +58,7 @@ public class CommonsLogWriter extends Writer {
for (int i = 0; i < length; i++) {
char ch = buffer[offset + i];
if (ch == '\n' && this.buffer.length() > 0) {
this.logger.debug(this.buffer.toString());
logger.debug(this.buffer.toString());
this.buffer.setLength(0);
}
else {