Polish "Add support for converting String to Pattern"

See gh-24311
2023-08-23 16:51:24 +02:00
parent 06f6b45248
commit a20a74817e
5 changed files with 76 additions and 7 deletions
--- a/spring-core/src/test/java/org/springframework/core/convert/converter/DefaultConversionServiceTests.java
+++ b/spring-core/src/test/java/org/springframework/core/convert/converter/DefaultConversionServiceTests.java
@@ -319,10 +319,16 @@ class DefaultConversionServiceTests {
 		assertThat(convertToUUID).isEqualTo(uuid);
 	}

+	@Test
+	void stringToPatternEmptyString() {
+		assertThat(conversionService.convert("", Pattern.class)).isNull();
+	}
+
 	@Test
 	void stringToPattern() {
-		String regex = "\\s";
-		assertThat(conversionService.convert(regex, Pattern.class)).extracting(Pattern::pattern).isEqualTo(regex);
+		String pattern = "\\s";
+		assertThat(conversionService.convert(pattern, Pattern.class))
+				.isInstanceOfSatisfying(Pattern.class, regex -> assertThat(regex.pattern()).isEqualTo(pattern));
 	}

 	@Test