Replace StringBuffer with StringBuilder where possible
This commit is contained in:
committed by
Juergen Hoeller
parent
33195da64f
commit
a2bb59f1b8
@@ -589,7 +589,7 @@ class ReverseMethodReplacer implements MethodReplacer, Serializable {
|
||||
@Override
|
||||
public Object reimplement(Object obj, Method method, Object[] args) throws Throwable {
|
||||
String s = (String) args[0];
|
||||
return new StringBuffer(s).reverse().toString();
|
||||
return new StringBuilder(s).reverse().toString();
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -1324,7 +1324,7 @@ class XmlBeanFactoryTests {
|
||||
|
||||
// Now test replace
|
||||
String s = "this is not a palindrome";
|
||||
String reverse = new StringBuffer(s).reverse().toString();
|
||||
String reverse = new StringBuilder(s).reverse().toString();
|
||||
assertThat(oom.replaceMe(s)).as("Should have overridden to reverse, not echo").isEqualTo(reverse);
|
||||
|
||||
assertThat(oom.replaceMe()).as("Should have overridden no-arg overloaded replaceMe method to return fixed value").isEqualTo(FixedMethodReplacer.VALUE);
|
||||
@@ -1380,7 +1380,7 @@ class XmlBeanFactoryTests {
|
||||
reader.loadBeanDefinitions(DELEGATION_OVERRIDES_CONTEXT);
|
||||
SerializableMethodReplacerCandidate s = (SerializableMethodReplacerCandidate) xbf.getBean("serializableReplacer");
|
||||
String forwards = "this is forwards";
|
||||
String backwards = new StringBuffer(forwards).reverse().toString();
|
||||
String backwards = new StringBuilder(forwards).reverse().toString();
|
||||
assertThat(s.replaceMe(forwards)).isEqualTo(backwards);
|
||||
// SPR-356: lookup methods & method replacers are not serializable.
|
||||
assertThat(SerializationTestUtils.isSerializable(s)).as("Lookup methods and method replacers are not meant to be serializable.").isFalse();
|
||||
|
||||
@@ -28,7 +28,7 @@ public class MessengerScrambler {
|
||||
|
||||
public String scramble(ProceedingJoinPoint pjp) throws Throwable {
|
||||
String message = (String) pjp.proceed();
|
||||
return new StringBuffer(message).reverse().toString();
|
||||
return new StringBuilder(message).reverse().toString();
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user