Merge pull request #33957 from anaconda875
* pr/33957: Polish "Use proper return type in AsyncExecutionInterceptor" Use proper return type in AsyncExecutionInterceptor Closes gh-33957
This commit is contained in:
@@ -1,5 +1,5 @@
|
|||||||
/*
|
/*
|
||||||
* Copyright 2002-2024 the original author or authors.
|
* Copyright 2002-2025 the original author or authors.
|
||||||
*
|
*
|
||||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
* you may not use this file except in compliance with the License.
|
* you may not use this file except in compliance with the License.
|
||||||
@@ -125,7 +125,7 @@ public class AsyncExecutionInterceptor extends AsyncExecutionAspectSupport imple
|
|||||||
return null;
|
return null;
|
||||||
};
|
};
|
||||||
|
|
||||||
return doSubmit(task, executor, invocation.getMethod().getReturnType());
|
return doSubmit(task, executor, userMethod.getReturnType());
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|||||||
@@ -0,0 +1,73 @@
|
|||||||
|
/*
|
||||||
|
* Copyright 2002-2025 the original author or authors.
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* https://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package org.springframework.aop.interceptor;
|
||||||
|
|
||||||
|
import java.util.concurrent.Callable;
|
||||||
|
import java.util.concurrent.CompletableFuture;
|
||||||
|
import java.util.concurrent.Future;
|
||||||
|
|
||||||
|
import org.aopalliance.intercept.MethodInvocation;
|
||||||
|
import org.junit.jupiter.api.Test;
|
||||||
|
import org.mockito.ArgumentCaptor;
|
||||||
|
|
||||||
|
import org.springframework.core.task.AsyncTaskExecutor;
|
||||||
|
|
||||||
|
import static org.assertj.core.api.Assertions.assertThat;
|
||||||
|
import static org.mockito.BDDMockito.given;
|
||||||
|
import static org.mockito.Mockito.any;
|
||||||
|
import static org.mockito.Mockito.mock;
|
||||||
|
import static org.mockito.Mockito.spy;
|
||||||
|
import static org.mockito.Mockito.verify;
|
||||||
|
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Tests for {@link AsyncExecutionInterceptor}.
|
||||||
|
*
|
||||||
|
* @author Bao Ngo
|
||||||
|
* @since 7.0
|
||||||
|
*/
|
||||||
|
class AsyncExecutionInterceptorTests {
|
||||||
|
|
||||||
|
@Test
|
||||||
|
@SuppressWarnings("unchecked")
|
||||||
|
void invokeOnInterfaceWithGeneric() throws Throwable {
|
||||||
|
AsyncExecutionInterceptor interceptor = spy(new AsyncExecutionInterceptor(null));
|
||||||
|
FutureRunner impl = new FutureRunner();
|
||||||
|
MethodInvocation mi = mock();
|
||||||
|
given(mi.getThis()).willReturn(impl);
|
||||||
|
given(mi.getMethod()).willReturn(GenericRunner.class.getMethod("run"));
|
||||||
|
|
||||||
|
interceptor.invoke(mi);
|
||||||
|
ArgumentCaptor<Class<?>> classArgumentCaptor = ArgumentCaptor.forClass(Class.class);
|
||||||
|
verify(interceptor).doSubmit(any(Callable.class), any(AsyncTaskExecutor.class), classArgumentCaptor.capture());
|
||||||
|
assertThat(classArgumentCaptor.getValue()).isEqualTo(Future.class);
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
interface GenericRunner<O> {
|
||||||
|
|
||||||
|
O run();
|
||||||
|
}
|
||||||
|
|
||||||
|
static class FutureRunner implements GenericRunner<Future<Void>> {
|
||||||
|
@Override
|
||||||
|
public Future<Void> run() {
|
||||||
|
return CompletableFuture.runAsync(() -> {
|
||||||
|
});
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
Reference in New Issue
Block a user