ServerCookie ignores empty domain with double quotes

Closes gh-24663
This commit is contained in:
Rossen Stoyanchev
2020-03-12 12:21:19 +00:00
parent 4aedf2ea13
commit a599859595
4 changed files with 63 additions and 23 deletions

View File

@@ -1,5 +1,5 @@
/*
* Copyright 2002-2019 the original author or authors.
* Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -81,4 +81,14 @@ public class ResponseCookieTests {
.hasMessageContaining("invalid cookie domain char"));
}
@Test // gh-24663
public void domainWithEmptyDoubleQuotes() {
Arrays.asList("\"\"", "\t\"\" ", " \" \t \"\t")
.forEach(domain -> {
ResponseCookie cookie = ResponseCookie.fromClientResponse("id", "1fWa").domain("\"\"").build();
assertThat(cookie.getDomain()).isNull();
});
}
}