Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Changed Basic Authentication consumer to setBasicAuth method

Browse Source 
This commit changes the Basic Authentication Consumer<HttpHeaders> to
a basic setBasicAuth(String, String) method.

Issue: SPR-16913
This commit is contained in:
Arjen Poutsma
2018-07-09 16:34:56 +02:00
parent a80c5121fe
commit a663454fad
4 changed files with 63 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
spring-web/src/test/java/org/springframework/http/HttpHeadersTests.java
View File

@@ -34,7 +34,6 @@ import java.util.GregorianCalendar;
import java.util.List;
import java.util.Locale;
import java.util.TimeZone;
import java.util.function.Consumer;
import org.hamcrest.Matchers;
import org.junit.Test;
@@ -532,22 +531,22 @@ public class HttpHeadersTests {
}
@Test
public void basicAuthenticationConsumer() throws Exception {
public void basicAuth() {
String username = "foo";
String password = "bar";
Consumer<HttpHeaders> consumer =
HttpHeaders.basicAuthenticationConsumer(username, password);
HttpHeaders headers = new HttpHeaders();
assertFalse(headers.containsKey(HttpHeaders.AUTHORIZATION));
consumer.accept(headers);
headers.setBasicAuth(username, password);
String authorization = headers.getFirst(HttpHeaders.AUTHORIZATION);
assertNotNull(authorization);
assertTrue(authorization.startsWith("Basic "));
byte[] result = Base64.getDecoder().decode(authorization.substring(6).getBytes(StandardCharsets.ISO_8859_1));
assertEquals("foo:bar", new String(result, StandardCharsets.ISO_8859_1));
}
@Test(expected = IllegalArgumentException.class)
public void basicAuthIllegalChar() {
String username = "foo";
String password = "\u03BB";
headers.setBasicAuth(username, password);
}
}