Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve handling of empty response with Mono<T>

Browse Source 
Issue: SPR-17560
This commit is contained in:
Rossen Stoyanchev
2018-11-19 16:47:51 -05:00
parent 63275ae2b7
commit abf9ce8a34
3 changed files with 28 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestMappingMessageConversionIntegrationTests.java
View File

@@ -149,6 +149,19 @@ public class RequestMappingMessageConversionIntegrationTests extends AbstractReq
assertEquals(expected, responseEntity.getBody());
}
@Test // SPR-17506
public void personResponseBodyWithEmptyMono() throws Exception {
ResponseEntity<Person> responseEntity = performGet("/person-response/mono-empty", JSON, Person.class);
assertEquals(0, responseEntity.getHeaders().getContentLength());
assertNull(responseEntity.getBody());
// As we're on the same connection, the 2nd request proves server response handling
// did complete after the 1st request..
responseEntity = performGet("/person-response/mono-empty", JSON, Person.class);
assertEquals(0, responseEntity.getHeaders().getContentLength());
assertNull(responseEntity.getBody());
}
@Test
public void personResponseBodyWithMonoDeclaredAsObject() throws Exception {
Person expected = new Person("Robert");
@@ -495,6 +508,11 @@ public class RequestMappingMessageConversionIntegrationTests extends AbstractReq
return Mono.just(new Person("Robert"));
}
@GetMapping("/mono-empty")
public Mono<Person> getMonoEmpty() {
return Mono.empty();
}
@GetMapping("/mono-declared-as-object")
public Object getMonoDeclaredAsObject() {
return Mono.just(new Person("Robert"));