SPR-7912 Add tests for FormattingConversionServiceFactoryBean, update reference docs, and remove mvc:formatters
This commit is contained in:
Rossen Stoyanchev
@@ -0,0 +1,201 @@
|
||||
/*
|
||||
* Copyright 2002-2011 the original author or authors.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
package org.springframework.format.support;
|
||||
|
||||
import static org.junit.Assert.assertEquals;
|
||||
import static org.junit.Assert.assertTrue;
|
||||
import static org.junit.Assert.fail;
|
||||
|
||||
import java.lang.annotation.ElementType;
|
||||
import java.lang.annotation.Retention;
|
||||
import java.lang.annotation.RetentionPolicy;
|
||||
import java.lang.annotation.Target;
|
||||
import java.text.ParseException;
|
||||
import java.util.HashSet;
|
||||
import java.util.Locale;
|
||||
import java.util.Set;
|
||||
|
||||
import org.junit.Test;
|
||||
import org.springframework.core.convert.ConversionFailedException;
|
||||
import org.springframework.core.convert.TypeDescriptor;
|
||||
import org.springframework.format.AnnotationFormatterFactory;
|
||||
import org.springframework.format.Formatter;
|
||||
import org.springframework.format.FormatterRegistrar;
|
||||
import org.springframework.format.FormatterRegistry;
|
||||
import org.springframework.format.Parser;
|
||||
import org.springframework.format.Printer;
|
||||
import org.springframework.format.annotation.NumberFormat;
|
||||
import org.springframework.format.annotation.NumberFormat.Style;
|
||||
|
||||
/**
|
||||
* Test fixture for FormattingConversionServiceFactoryBean.
|
||||
* @author Rossen Stoyanchev
|
||||
*/
|
||||
public class FormattingConversionServiceFactoryBeanTests {
|
||||
|
||||
@Test
|
||||
public void testDefaultFormattersOn() throws Exception {
|
||||
FormattingConversionServiceFactoryBean factory = new FormattingConversionServiceFactoryBean();
|
||||
factory.afterPropertiesSet();
|
||||
FormattingConversionService fcs = factory.getObject();
|
||||
TypeDescriptor descriptor = new TypeDescriptor(TestBean.class.getDeclaredField("percent"));
|
||||
Object value = fcs.convert("5%", TypeDescriptor.valueOf(String.class), descriptor);
|
||||
assertEquals(.05, value);
|
||||
value = fcs.convert(.05, descriptor, TypeDescriptor.valueOf(String.class));
|
||||
assertEquals("5%", value);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testDefaultFormattersOff() throws Exception {
|
||||
FormattingConversionServiceFactoryBean factory = new FormattingConversionServiceFactoryBean();
|
||||
factory.setRegisterDefaultFormatters(false);
|
||||
factory.afterPropertiesSet();
|
||||
FormattingConversionService fcs = factory.getObject();
|
||||
TypeDescriptor descriptor = new TypeDescriptor(TestBean.class.getDeclaredField("percent"));
|
||||
try {
|
||||
fcs.convert("5%", TypeDescriptor.valueOf(String.class), descriptor);
|
||||
fail("This format should not be parseable");
|
||||
} catch (ConversionFailedException e) {
|
||||
assertTrue(e.getCause() instanceof NumberFormatException);
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testCustomFormatter() throws Exception {
|
||||
FormattingConversionServiceFactoryBean factory = new FormattingConversionServiceFactoryBean();
|
||||
Set<Object> formatters = new HashSet<Object>();
|
||||
formatters.add(new TestBeanFormatter());
|
||||
formatters.add(new SpecialIntAnnotationFormatterFactory());
|
||||
factory.setFormatters(formatters);
|
||||
factory.afterPropertiesSet();
|
||||
FormattingConversionService fcs = factory.getObject();
|
||||
|
||||
TestBean testBean = fcs.convert("5", TestBean.class);
|
||||
assertEquals(5, testBean.getSpecialInt());
|
||||
assertEquals("5", fcs.convert(testBean, String.class));
|
||||
|
||||
TypeDescriptor descriptor = new TypeDescriptor(TestBean.class.getDeclaredField("specialInt"));
|
||||
Object value = fcs.convert(":5", TypeDescriptor.valueOf(String.class), descriptor);
|
||||
assertEquals(5, value);
|
||||
value = fcs.convert(5, descriptor, TypeDescriptor.valueOf(String.class));
|
||||
assertEquals(":5", value);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testFormatterRegistrar() throws Exception {
|
||||
FormattingConversionServiceFactoryBean factory = new FormattingConversionServiceFactoryBean();
|
||||
Set<FormatterRegistrar> registrars = new HashSet<FormatterRegistrar>();
|
||||
registrars.add(new TestFormatterRegistrar());
|
||||
factory.setFormatterRegistrars(registrars);
|
||||
factory.afterPropertiesSet();
|
||||
FormattingConversionService fcs = factory.getObject();
|
||||
|
||||
TestBean testBean = fcs.convert("5", TestBean.class);
|
||||
assertEquals(5, testBean.getSpecialInt());
|
||||
assertEquals("5", fcs.convert(testBean, String.class));
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testInvalidFormatter() throws Exception {
|
||||
FormattingConversionServiceFactoryBean factory = new FormattingConversionServiceFactoryBean();
|
||||
Set<Object> formatters = new HashSet<Object>();
|
||||
formatters.add(new Object());
|
||||
factory.setFormatters(formatters);
|
||||
try {
|
||||
factory.afterPropertiesSet();
|
||||
fail("Expected formatter to be rejected");
|
||||
} catch (IllegalArgumentException e) {
|
||||
// expected
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@Target({ ElementType.METHOD, ElementType.FIELD, ElementType.PARAMETER })
|
||||
@Retention(RetentionPolicy.RUNTIME)
|
||||
private @interface SpecialInt {
|
||||
}
|
||||
|
||||
private static class TestBean {
|
||||
|
||||
@SuppressWarnings("unused")
|
||||
@NumberFormat(style = Style.PERCENT)
|
||||
private double percent;
|
||||
|
||||
@SpecialInt
|
||||
private int specialInt;
|
||||
|
||||
public int getSpecialInt() {
|
||||
return specialInt;
|
||||
}
|
||||
|
||||
public void setSpecialInt(int field) {
|
||||
this.specialInt = field;
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
private static class TestBeanFormatter implements Formatter<TestBean> {
|
||||
|
||||
public String print(TestBean object, Locale locale) {
|
||||
return String.valueOf(object.getSpecialInt());
|
||||
}
|
||||
|
||||
public TestBean parse(String text, Locale locale) throws ParseException {
|
||||
TestBean object = new TestBean();
|
||||
object.setSpecialInt(Integer.parseInt(text));
|
||||
return object;
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
private static class SpecialIntAnnotationFormatterFactory implements AnnotationFormatterFactory<SpecialInt> {
|
||||
|
||||
private final Set<Class<?>> fieldTypes = new HashSet<Class<?>>(1);
|
||||
|
||||
public SpecialIntAnnotationFormatterFactory() {
|
||||
fieldTypes.add(Integer.class);
|
||||
}
|
||||
|
||||
public Set<Class<?>> getFieldTypes() {
|
||||
return fieldTypes;
|
||||
}
|
||||
|
||||
public Printer<?> getPrinter(SpecialInt annotation, Class<?> fieldType) {
|
||||
return new Printer<Integer>() {
|
||||
public String print(Integer object, Locale locale) {
|
||||
return ":" + object.toString();
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
public Parser<?> getParser(SpecialInt annotation, Class<?> fieldType) {
|
||||
return new Parser<Integer>() {
|
||||
public Integer parse(String text, Locale locale) throws ParseException {
|
||||
return Integer.parseInt(text.substring(1));
|
||||
}
|
||||
};
|
||||
}
|
||||
}
|
||||
|
||||
private static class TestFormatterRegistrar implements FormatterRegistrar {
|
||||
|
||||
public void registerFormatters(FormatterRegistry registry) {
|
||||
registry.addFormatter(new TestBeanFormatter());
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
}
|
||||
Reference in New Issue
Block a user