Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix [serial] compiler warnings

Browse Source 
Fix serialization warnings by applying @SuppressWarnings("serial")
when appropriate.

In certain cases and for unknown reasons, a correctly-placed
@SuppressWarnings("serial") annotation will fix the warning at the
javac level (i.e. the Gradle command-line), but will produce an
"unnecessary @SuppressWarnings" warning within Eclipse. In these
cases, a private static final serialVersionUID field has been added
with the default value of 1L.
This commit is contained in:
Phillip Webb
2012-12-19 14:35:57 -08:00
committed by Chris Beams
parent 7f0aa5cfb2
commit b0986049a3
550 changed files with 705 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
spring-beans/src/test/java/org/springframework/beans/BeanWrapperTests.java
View File

@@ -1851,6 +1851,7 @@ public final class BeanWrapperTests {
}
@SuppressWarnings("serial")
public static class TypedReadOnlyMap extends ReadOnlyMap<String, TestBean> {
public TypedReadOnlyMap() {

1
spring-beans/src/test/java/org/springframework/beans/factory/annotation/AutowiredAnnotationBeanPostProcessorTests.java
View File

@@ -1346,6 +1346,7 @@ public final class AutowiredAnnotationBeanPostProcessorTests {
}
@SuppressWarnings("serial")
public static class ObjectFactoryInjectionBean implements Serializable {
@Autowired

6
spring-beans/src/test/java/org/springframework/beans/factory/annotation/InjectAnnotationBeanPostProcessorTests.java
View File

@@ -938,6 +938,7 @@ public class InjectAnnotationBeanPostProcessorTests {
}
@SuppressWarnings("serial")
public static class ObjectFactoryFieldInjectionBean implements Serializable {
@Inject
@@ -949,6 +950,7 @@ public class InjectAnnotationBeanPostProcessorTests {
}
@SuppressWarnings("serial")
public static class ObjectFactoryMethodInjectionBean implements Serializable {
private Provider<TestBean> testBeanFactory;
@@ -992,6 +994,7 @@ public class InjectAnnotationBeanPostProcessorTests {
}
@SuppressWarnings("serial")
public static class ObjectFactoryListFieldInjectionBean implements Serializable {
@Inject
@@ -1007,6 +1010,7 @@ public class InjectAnnotationBeanPostProcessorTests {
}
@SuppressWarnings("serial")
public static class ObjectFactoryListMethodInjectionBean implements Serializable {
private Provider<List<TestBean>> testBeanFactory;
@@ -1022,6 +1026,7 @@ public class InjectAnnotationBeanPostProcessorTests {
}
@SuppressWarnings("serial")
public static class ObjectFactoryMapFieldInjectionBean implements Serializable {
@Inject
@@ -1037,6 +1042,7 @@ public class InjectAnnotationBeanPostProcessorTests {
}
@SuppressWarnings("serial")
public static class ObjectFactoryMapMethodInjectionBean implements Serializable {
private Provider<Map<String, TestBean>> testBeanFactory;

2
spring-beans/src/test/java/org/springframework/beans/factory/support/DefinitionMetadataEqualsHashCodeTests.java
View File

@@ -28,6 +28,7 @@ import test.beans.TestBean;
*/
public class DefinitionMetadataEqualsHashCodeTests extends TestCase {
@SuppressWarnings("serial")
public void testRootBeanDefinitionEqualsAndHashCode() throws Exception {
RootBeanDefinition master = new RootBeanDefinition(TestBean.class);
RootBeanDefinition equal = new RootBeanDefinition(TestBean.class);
@@ -42,6 +43,7 @@ public class DefinitionMetadataEqualsHashCodeTests extends TestCase {
assertEquals("Hash code for equal instances should match", master.hashCode(), equal.hashCode());
}
@SuppressWarnings("serial")
public void testChildBeanDefinitionEqualsAndHashCode() throws Exception {
ChildBeanDefinition master = new ChildBeanDefinition("foo");
ChildBeanDefinition equal = new ChildBeanDefinition("foo");

1
spring-beans/src/test/java/org/springframework/beans/factory/xml/ConstructorDependenciesBean.java
View File

@@ -27,6 +27,7 @@ import test.beans.TestBean;
* @author Juergen Hoeller
* @since 09.11.2003
*/
@SuppressWarnings("serial")
public class ConstructorDependenciesBean implements Serializable {
private int age;

3
spring-beans/src/test/java/test/beans/Colour.java
View File

@@ -21,6 +21,7 @@ import org.springframework.core.enums.ShortCodedLabeledEnum;
/**
* @author Rob Harrop
*/
@SuppressWarnings("serial")
public class Colour extends ShortCodedLabeledEnum {
public static final Colour RED = new Colour(0, "RED");
@@ -32,4 +33,4 @@ public class Colour extends ShortCodedLabeledEnum {
super(code, label);
}
}
}

1
spring-beans/src/test/java/test/beans/DerivedTestBean.java
View File

@@ -25,6 +25,7 @@ import org.springframework.beans.factory.DisposableBean;
* @author Juergen Hoeller
* @since 21.08.2003
*/
@SuppressWarnings("serial")
public class DerivedTestBean extends TestBean implements Serializable, BeanNameAware, DisposableBean {
private String beanName;