Fix [serial] compiler warnings

Fix serialization warnings by applying @SuppressWarnings("serial")
when appropriate.

In certain cases and for unknown reasons, a correctly-placed
@SuppressWarnings("serial") annotation will fix the warning at the
javac level (i.e. the Gradle command-line), but will produce an
"unnecessary @SuppressWarnings" warning within Eclipse. In these
cases, a private static final serialVersionUID field has been added
with the default value of 1L.
This commit is contained in:
Phillip Webb
2012-12-19 14:35:57 -08:00
committed by Chris Beams
parent 7f0aa5cfb2
commit b0986049a3
550 changed files with 705 additions and 36 deletions

View File

@@ -32,6 +32,7 @@ import org.springframework.util.Assert;
* @author Juergen Hoeller
* @since 22.11.2003
*/
@SuppressWarnings("serial")
public class ModelAndViewDefiningException extends ServletException {
private ModelAndView modelAndView;

View File

@@ -88,6 +88,7 @@ import org.springframework.web.context.support.ServletContextResource;
* @see #setAllowedResources
* @see #setApplyLastModified
*/
@SuppressWarnings("serial")
public class ResourceServlet extends HttpServletBean {
/**

View File

@@ -43,6 +43,7 @@ import org.springframework.web.util.NestedServletException;
* @author Juergen Hoeller
* @since 2.0
*/
@SuppressWarnings("serial")
public class ViewRendererServlet extends HttpServlet {
/**

View File

@@ -32,6 +32,7 @@ import org.springframework.web.util.UrlPathHelper;
* @author Juergen Hoeller
* @see MethodNameResolver#getHandlerMethodName(javax.servlet.http.HttpServletRequest)
*/
@SuppressWarnings("serial")
public class NoSuchRequestHandlingMethodException extends ServletException {
private String methodName;

View File

@@ -33,6 +33,7 @@ import org.springframework.web.util.ExpressionEvaluationUtils;
* @see BindTag
* @see org.springframework.validation.Errors
*/
@SuppressWarnings("serial")
public class BindErrorsTag extends HtmlEscapingAwareTag {
public static final String ERRORS_VARIABLE_NAME = "errors";

View File

@@ -46,6 +46,7 @@ import org.springframework.web.util.ExpressionEvaluationUtils;
* @author Juergen Hoeller
* @see #setPath
*/
@SuppressWarnings("serial")
public class BindTag extends HtmlEscapingAwareTag implements EditorAwareTag {
/**

View File

@@ -43,6 +43,7 @@ import org.springframework.web.util.JavaScriptUtils;
* @see org.springframework.web.util.HtmlUtils
* @see org.springframework.web.util.JavaScriptUtils
*/
@SuppressWarnings("serial")
public class EscapeBodyTag extends HtmlEscapingAwareTag implements BodyTag {
private boolean javaScriptEscape = false;

View File

@@ -49,6 +49,7 @@ import org.springframework.web.util.TagUtils;
* @author Juergen Hoeller
* @since 3.0.1
*/
@SuppressWarnings("serial")
public class EvalTag extends HtmlEscapingAwareTag {
/**

View File

@@ -31,6 +31,7 @@ import org.springframework.web.util.ExpressionEvaluationUtils;
* @since 04.03.2003
* @see HtmlEscapingAwareTag#setHtmlEscape
*/
@SuppressWarnings("serial")
public class HtmlEscapeTag extends RequestContextAwareTag {
private String defaultHtmlEscape;

View File

@@ -35,6 +35,7 @@ import org.springframework.web.util.ExpressionEvaluationUtils;
* @see org.springframework.web.servlet.support.RequestContext#isDefaultHtmlEscape
* @see org.springframework.web.util.WebUtils#isDefaultHtmlEscape
*/
@SuppressWarnings("serial")
public abstract class HtmlEscapingAwareTag extends RequestContextAwareTag {
private Boolean htmlEscape;

View File

@@ -51,6 +51,7 @@ import org.springframework.web.util.TagUtils;
* @see HtmlEscapeTag#setDefaultHtmlEscape
* @see org.springframework.web.util.WebUtils#HTML_ESCAPE_CONTEXT_PARAM
*/
@SuppressWarnings("serial")
public class MessageTag extends HtmlEscapingAwareTag {
/**

View File

@@ -40,6 +40,7 @@ import org.springframework.web.util.ExpressionEvaluationUtils;
* @author Juergen Hoeller
* @since 1.1
*/
@SuppressWarnings("serial")
public class NestedPathTag extends TagSupport implements TryCatchFinally {
/**

View File

@@ -30,6 +30,7 @@ import javax.servlet.jsp.tagext.BodyTagSupport;
* @see Param
* @see UrlTag
*/
@SuppressWarnings("serial")
public class ParamTag extends BodyTagSupport {
private String name;

View File

@@ -45,6 +45,7 @@ import org.springframework.web.servlet.support.RequestContext;
* @see org.springframework.web.servlet.support.RequestContext
* @see org.springframework.web.servlet.DispatcherServlet
*/
@SuppressWarnings("serial")
public abstract class RequestContextAwareTag extends TagSupport implements TryCatchFinally {
/**

View File

@@ -40,6 +40,7 @@ import org.springframework.context.NoSuchMessageException;
* @see HtmlEscapeTag#setDefaultHtmlEscape
* @see org.springframework.web.util.WebUtils#HTML_ESCAPE_CONTEXT_PARAM
*/
@SuppressWarnings("serial")
public class ThemeTag extends MessageTag {
/**

View File

@@ -40,6 +40,7 @@ import org.springframework.web.util.TagUtils;
* @since 20.09.2003
* @see BindTag
*/
@SuppressWarnings("serial")
public class TransformTag extends HtmlEscapingAwareTag {
/** the value to transform using the appropriate property editor */

View File

@@ -75,6 +75,7 @@ import org.springframework.web.util.UriUtils;
* @since 3.0
* @see ParamTag
*/
@SuppressWarnings("serial")
public class UrlTag extends HtmlEscapingAwareTag implements ParamAware {
private static final String URL_TEMPLATE_DELIMITER_PREFIX = "{";

View File

@@ -28,6 +28,7 @@ import javax.servlet.jsp.JspException;
* @author Rossen Stoyanchev
* @since 2.5
*/
@SuppressWarnings("serial")
public abstract class AbstractCheckedElementTag extends AbstractHtmlInputElementTag {
/**

View File

@@ -43,6 +43,7 @@ import org.springframework.web.servlet.tags.NestedPathTag;
* @author Juergen Hoeller
* @since 2.0
*/
@SuppressWarnings("serial")
public abstract class AbstractDataBoundFormElementTag extends AbstractFormTag implements EditorAwareTag {
/**

View File

@@ -38,6 +38,7 @@ import org.springframework.web.util.ExpressionEvaluationUtils;
* @author Juergen Hoeller
* @since 2.0
*/
@SuppressWarnings("serial")
public abstract class AbstractFormTag extends HtmlEscapingAwareTag {
/**

View File

@@ -33,6 +33,7 @@ import org.springframework.util.StringUtils;
* @author Juergen Hoeller
* @since 2.0
*/
@SuppressWarnings("serial")
public abstract class AbstractHtmlElementBodyTag extends AbstractHtmlElementTag implements BodyTag {
private BodyContent bodyContent;

View File

@@ -40,6 +40,7 @@ import org.springframework.util.StringUtils;
* @author Rossen Stoyanchev
* @since 2.0
*/
@SuppressWarnings("serial")
public abstract class AbstractHtmlElementTag extends AbstractDataBoundFormElementTag implements DynamicAttributes {
public static final String CLASS_ATTRIBUTE = "class";

View File

@@ -29,6 +29,7 @@ import javax.servlet.jsp.JspException;
* @author Juergen Hoeller
* @since 2.0
*/
@SuppressWarnings("serial")
public abstract class AbstractHtmlInputElementTag extends AbstractHtmlElementTag {
/**

View File

@@ -37,6 +37,7 @@ import org.springframework.util.StringUtils;
* @author Scott Andrews
* @since 2.5.2
*/
@SuppressWarnings("serial")
public abstract class AbstractMultiCheckedElementTag extends AbstractCheckedElementTag {
/**

View File

@@ -27,6 +27,7 @@ import javax.servlet.jsp.JspException;
* @author Juergen Hoeller
* @since 2.5.2
*/
@SuppressWarnings("serial")
public abstract class AbstractSingleCheckedElementTag extends AbstractCheckedElementTag {
/**

View File

@@ -45,6 +45,7 @@ import org.springframework.web.bind.WebDataBinder;
* @author Juergen Hoeller
* @since 2.0
*/
@SuppressWarnings("serial")
public class CheckboxTag extends AbstractSingleCheckedElementTag {
@Override

View File

@@ -31,6 +31,7 @@ import org.springframework.web.bind.WebDataBinder;
* @author Mark Fisher
* @since 2.5
*/
@SuppressWarnings("serial")
public class CheckboxesTag extends AbstractMultiCheckedElementTag {
@Override

View File

@@ -43,6 +43,7 @@ import org.springframework.util.StringUtils;
* @author Rick Evans
* @since 2.0
*/
@SuppressWarnings("serial")
public class ErrorsTag extends AbstractHtmlElementBodyTag implements BodyTag {
/**

View File

@@ -53,6 +53,7 @@ import org.springframework.web.util.HtmlUtils;
* @since 2.0
* @see org.springframework.web.servlet.mvc.SimpleFormController
*/
@SuppressWarnings("serial")
public class FormTag extends AbstractHtmlElementTag {
/** The default HTTP method using which form values are sent to the server: "post" */

View File

@@ -34,6 +34,7 @@ import org.springframework.util.StringUtils;
* @author Juergen Hoeller
* @since 2.0
*/
@SuppressWarnings("serial")
public class LabelTag extends AbstractHtmlElementTag {
/**

View File

@@ -46,6 +46,7 @@ import org.springframework.web.util.TagUtils;
* @author Juergen Hoeller
* @since 2.0
*/
@SuppressWarnings("serial")
public class OptionTag extends AbstractHtmlElementBodyTag implements BodyTag {
/**

View File

@@ -35,6 +35,7 @@ import org.springframework.web.util.TagUtils;
* @author Scott Andrews
* @since 2.0
*/
@SuppressWarnings("serial")
public class OptionsTag extends AbstractHtmlElementTag {
/**

View File

@@ -27,6 +27,7 @@ import javax.servlet.jsp.JspException;
* @author Rossen Stoyanchev
* @since 2.0
*/
@SuppressWarnings("serial")
public class PasswordInputTag extends InputTag {
private boolean showPassword = false;

View File

@@ -32,6 +32,7 @@ import javax.servlet.jsp.JspException;
* @author Juergen Hoeller
* @since 2.0
*/
@SuppressWarnings("serial")
public class RadioButtonTag extends AbstractSingleCheckedElementTag {
@Override

View File

@@ -27,6 +27,7 @@ package org.springframework.web.servlet.tags.form;
* @author Juergen Hoeller
* @since 2.5
*/
@SuppressWarnings("serial")
public class RadioButtonsTag extends AbstractMultiCheckedElementTag {
@Override

View File

@@ -40,6 +40,7 @@ import org.springframework.web.servlet.support.BindStatus;
* @since 2.0
* @see OptionTag
*/
@SuppressWarnings("serial")
public class SelectTag extends AbstractHtmlInputElementTag {
/**

View File

@@ -25,6 +25,7 @@ import javax.servlet.jsp.JspException;
* @author Juergen Hoeller
* @since 2.0
*/
@SuppressWarnings("serial")
public class TextareaTag extends AbstractHtmlInputElementTag {
public static final String ROWS_ATTRIBUTE = "rows";

View File

@@ -49,6 +49,7 @@ public abstract class AbstractCachingViewResolver extends WebApplicationObjectSu
private boolean cacheUnresolved = true;
/** Map from view key to View instance */
@SuppressWarnings("serial")
private final Map<Object, View> viewCache =
new LinkedHashMap<Object, View>(DEFAULT_CACHE_LIMIT, 0.75f, true) {
@Override

View File

@@ -371,6 +371,7 @@ public class FreeMarkerView extends AbstractTemplateView {
* Simple adapter class that extends {@link GenericServlet}.
* Needed for JSP access in FreeMarker.
*/
@SuppressWarnings("serial")
private static class GenericServletAdapter extends GenericServlet {
@Override