Stop using Constants utility in JmsAccessor

See gh-30851
This commit is contained in:
Sam Brannen
2023-07-19 12:16:01 +03:00
parent 15253f3448
commit b2ca36f098
2 changed files with 42 additions and 4 deletions

View File

@@ -16,11 +16,18 @@
package org.springframework.jms.support;
import java.lang.reflect.Field;
import java.util.Arrays;
import java.util.stream.Stream;
import jakarta.jms.Session;
import org.junit.jupiter.api.Test;
import org.springframework.util.ReflectionUtils;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
import static org.assertj.core.api.Assertions.assertThatNoException;
import static org.mockito.BDDMockito.given;
import static org.mockito.Mockito.mock;
@@ -70,6 +77,24 @@ class JmsAccessorTests {
assertThatIllegalArgumentException().isThrownBy(() -> accessor.setSessionAcknowledgeModeName("bogus"));
}
/**
* This test effectively verifies that the internal 'constants' map is properly
* configured for all acknowledge mode constants constants defined in
* {@link jakarta.jms.Session}.
*/
@Test
void setSessionAcknowledgeModeNameToAllSupportedValues() {
streamAcknowledgeModeConstants()
.map(Field::getName)
.forEach(name -> assertThatNoException().isThrownBy(() -> accessor.setSessionAcknowledgeModeName(name)));
}
private static Stream<Field> streamAcknowledgeModeConstants() {
return Arrays.stream(Session.class.getFields())
.filter(ReflectionUtils::isPublicStaticFinal);
}
@Test
void customAcknowledgeModeIsConsideredClientAcknowledge() throws Exception {
Session session = mock();