Polish naming

Co-authored-by: Andy Wilkinson <wilkinsona@vmware.com>
This commit is contained in:
Stephane Nicoll
2022-02-22 16:07:52 +01:00
parent e85001f332
commit b4eb895927
6 changed files with 41 additions and 41 deletions

View File

@@ -56,8 +56,8 @@ import org.springframework.beans.factory.annotation.InjectionMetadata.InjectedEl
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
import org.springframework.beans.factory.config.DependencyDescriptor;
import org.springframework.beans.factory.config.SmartInstantiationAwareBeanPostProcessor;
import org.springframework.beans.factory.generator.BeanInstanceAotPostProcessor;
import org.springframework.beans.factory.generator.BeanInstanceContributor;
import org.springframework.beans.factory.generator.AotContributingBeanPostProcessor;
import org.springframework.beans.factory.generator.BeanInstantiationContributor;
import org.springframework.beans.factory.generator.InjectionGenerator;
import org.springframework.beans.factory.support.LookupOverride;
import org.springframework.beans.factory.support.MergedBeanDefinitionPostProcessor;
@@ -140,7 +140,7 @@ import org.springframework.util.StringUtils;
* @see Value
*/
public class AutowiredAnnotationBeanPostProcessor implements SmartInstantiationAwareBeanPostProcessor,
MergedBeanDefinitionPostProcessor, BeanInstanceAotPostProcessor, PriorityOrdered, BeanFactoryAware {
MergedBeanDefinitionPostProcessor, AotContributingBeanPostProcessor, PriorityOrdered, BeanFactoryAware {
protected final Log logger = LogFactory.getLog(getClass());
@@ -268,12 +268,12 @@ public class AutowiredAnnotationBeanPostProcessor implements SmartInstantiationA
}
@Override
public BeanInstanceContributor buildAotContributor(RootBeanDefinition beanDefinition, Class<?> beanType, String beanName) {
public BeanInstantiationContributor buildAotContributor(RootBeanDefinition beanDefinition, Class<?> beanType, String beanName) {
InjectionMetadata metadata = findInjectionMetadata(beanName, beanType, beanDefinition);
Collection<InjectedElement> injectedElements = metadata.getInjectedElements();
return (!ObjectUtils.isEmpty(injectedElements)
? new AutowiredAnnotationBeanInstanceContributor(injectedElements)
: BeanInstanceContributor.NO_OP);
? new AutowiredAnnotationBeanInstantiationContributor(injectedElements)
: BeanInstantiationContributor.NO_OP);
}
private InjectionMetadata findInjectionMetadata(String beanName, Class<?> beanType, RootBeanDefinition beanDefinition) {
@@ -821,13 +821,13 @@ public class AutowiredAnnotationBeanPostProcessor implements SmartInstantiationA
}
}
private static final class AutowiredAnnotationBeanInstanceContributor implements BeanInstanceContributor {
private static final class AutowiredAnnotationBeanInstantiationContributor implements BeanInstantiationContributor {
private final Collection<InjectedElement> injectedElements;
private final InjectionGenerator generator;
AutowiredAnnotationBeanInstanceContributor(Collection<InjectedElement> injectedElements) {
AutowiredAnnotationBeanInstantiationContributor(Collection<InjectedElement> injectedElements) {
this.injectedElements = injectedElements;
this.generator = new InjectionGenerator();
}

View File

@@ -20,9 +20,9 @@ import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.beans.factory.support.RootBeanDefinition;
/**
* Strategy interface to be implemented by a {@link BeanPostProcessor} that
* participates in a bean instance setup and can provide an equivalent setup
* using generated code.
* Specialization of {@link BeanPostProcessor} that contributes to bean
* instantiation ahead of time, providing generated code that is equivalent to
* its runtime behavior.
*
* <p>Contrary to other bean post processors, implementations of this interface
* are instantiated at build-time and should not rely on other beans in the
@@ -32,15 +32,15 @@ import org.springframework.beans.factory.support.RootBeanDefinition;
* @since 6.0
*/
@FunctionalInterface
public interface BeanInstanceAotPostProcessor extends BeanPostProcessor {
public interface AotContributingBeanPostProcessor extends BeanPostProcessor {
/**
* Build a {@link BeanInstanceContributor} for the given bean definition.
* Build a {@link BeanInstantiationContributor} for the given bean definition.
* @param beanDefinition the merged bean definition for the bean
* @param beanType the actual type of the managed bean instance
* @param beanType the inferred type of the bean
* @param beanName the name of the bean
* @return the contributor to use
*/
BeanInstanceContributor buildAotContributor(RootBeanDefinition beanDefinition, Class<?> beanType, String beanName);
BeanInstantiationContributor buildAotContributor(RootBeanDefinition beanDefinition, Class<?> beanType, String beanName);
}

View File

@@ -19,21 +19,20 @@ package org.springframework.beans.factory.generator;
import org.springframework.aot.generator.CodeContribution;
/**
* Strategy interface to be implemented by components that participates in a
* bean instance setup so that the generated code provides an equivalent
* setup.
* Contributor to the code that instantiates a bean following ahead of time
* processing.
*
* @author Stephane Nicoll
* @since 6.0
*/
@FunctionalInterface
public interface BeanInstanceContributor {
public interface BeanInstantiationContributor {
/**
* A {@link BeanInstanceContributor} that does not contribute anything
* A {@link BeanInstantiationContributor} that does not contribute anything
* to the {@link CodeContribution}.
*/
BeanInstanceContributor NO_OP = contribution -> { };
BeanInstantiationContributor NO_OP = contribution -> { };
/**
* Contribute to the specified {@link CodeContribution}.

View File

@@ -36,19 +36,20 @@ import org.springframework.util.ClassUtils;
* Write the necessary statements to instantiate a bean.
*
* @author Stephane Nicoll
* @see BeanInstantiationContributor
*/
class DefaultBeanInstanceGenerator {
class DefaultBeanInstantiationGenerator {
private final Executable instanceCreator;
private final List<BeanInstanceContributor> contributors;
private final List<BeanInstantiationContributor> contributors;
private final InjectionGenerator injectionGenerator;
private final Options beanInstanceOptions;
DefaultBeanInstanceGenerator(Executable instanceCreator, List<BeanInstanceContributor> contributors) {
DefaultBeanInstantiationGenerator(Executable instanceCreator, List<BeanInstantiationContributor> contributors) {
this.instanceCreator = instanceCreator;
this.contributors = List.copyOf(contributors);
this.injectionGenerator = new InjectionGenerator();
@@ -62,7 +63,7 @@ class DefaultBeanInstanceGenerator {
* @param runtimeHints the runtime hints instance to use
* @return a code contribution that provides an initialized bean instance
*/
public CodeContribution generateBeanInstance(RuntimeHints runtimeHints) {
public CodeContribution generateBeanInstantiation(RuntimeHints runtimeHints) {
DefaultCodeContribution contribution = new DefaultCodeContribution(runtimeHints);
contribution.protectedAccess().analyze(this.instanceCreator, this.beanInstanceOptions);
if (this.instanceCreator instanceof Constructor<?> constructor) {
@@ -109,7 +110,7 @@ class DefaultBeanInstanceGenerator {
contribution.statements().addStatement(code.build());
if (multiStatements) {
for (BeanInstanceContributor contributor : this.contributors) {
for (BeanInstantiationContributor contributor : this.contributors) {
contributor.contribute(contribution);
}
contribution.statements().addStatement("return bean")
@@ -147,7 +148,7 @@ class DefaultBeanInstanceGenerator {
code.add(this.injectionGenerator.writeInstantiation(method));
contribution.statements().addStatement(code.build());
if (multiStatements) {
for (BeanInstanceContributor contributor : this.contributors) {
for (BeanInstantiationContributor contributor : this.contributors) {
contributor.contribute(contribution);
}
contribution.statements().addStatement("return bean")