From b5bd4d8a8a27b014950bb106e2cdfcff7887676f Mon Sep 17 00:00:00 2001 From: Rossen Stoyanchev Date: Tue, 5 Nov 2013 20:44:17 -0500 Subject: [PATCH] Add div around extra hidden fields in FormTag Issue: SPR-10926 --- .../java/org/springframework/web/servlet/tags/form/FormTag.java | 2 ++ .../org/springframework/web/servlet/tags/form/FormTagTests.java | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/spring-webmvc/src/main/java/org/springframework/web/servlet/tags/form/FormTag.java b/spring-webmvc/src/main/java/org/springframework/web/servlet/tags/form/FormTag.java index a58b4c7acb..a6aa59c557 100644 --- a/spring-webmvc/src/main/java/org/springframework/web/servlet/tags/form/FormTag.java +++ b/spring-webmvc/src/main/java/org/springframework/web/servlet/tags/form/FormTag.java @@ -493,11 +493,13 @@ public class FormTag extends AbstractHtmlElementTag { */ private void writeHiddenFields(Map hiddenFields) throws JspException { if (hiddenFields != null) { + this.tagWriter.appendValue("
\n"); for (String name : hiddenFields.keySet()) { this.tagWriter.appendValue("\n"); } + this.tagWriter.appendValue("
"); } } diff --git a/spring-webmvc/src/test/java/org/springframework/web/servlet/tags/form/FormTagTests.java b/spring-webmvc/src/test/java/org/springframework/web/servlet/tags/form/FormTagTests.java index 43f86fac47..8fdcc1cc4b 100644 --- a/spring-webmvc/src/test/java/org/springframework/web/servlet/tags/form/FormTagTests.java +++ b/spring-webmvc/src/test/java/org/springframework/web/servlet/tags/form/FormTagTests.java @@ -335,7 +335,7 @@ public class FormTagTests extends AbstractHtmlElementTagTests { String output = getOutput(); - assertEquals("", getInputTag(output)); + assertEquals("
\n\n
", getInputTag(output)); assertFormTagOpened(output); assertFormTagClosed(output); }