Spring/spring-framework
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Introduce "synthesizable" cache in AnnotationUtils

Browse Source 
Issue: SPR-11512
This commit is contained in:
Sam Brannen
2015-05-22 21:40:36 +02:00
parent 2e4dabb349
commit bd787769be
1 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
spring-core/src/main/java/org/springframework/core/annotation/AnnotationUtils.java
View File

@@ -115,6 +115,9 @@ public abstract class AnnotationUtils {
private static final Map<Class<?>, Boolean> annotatedInterfaceCache = private static final Map<Class<?>, Boolean> annotatedInterfaceCache =
new ConcurrentReferenceHashMap<Class<?>, Boolean>(256); new ConcurrentReferenceHashMap<Class<?>, Boolean>(256);
private static final Map<Class<? extends Annotation>, Boolean> synthesizableCache =
new ConcurrentReferenceHashMap<Class<? extends Annotation>, Boolean>(256);
private static transient Log logger; private static transient Log logger;
@@ -1074,9 +1077,17 @@ public abstract class AnnotationUtils {
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
private static boolean isSynthesizable(Class<? extends Annotation> annotationType) { private static boolean isSynthesizable(Class<? extends Annotation> annotationType) {
Boolean flag = synthesizableCache.get(annotationType);
if (flag != null) {
return flag.booleanValue();
}
Boolean synthesizable = Boolean.FALSE;
for (Method attribute : getAttributeMethods(annotationType)) { for (Method attribute : getAttributeMethods(annotationType)) {
if (getAliasedAttributeName(attribute) != null) { if (getAliasedAttributeName(attribute) != null) {
return true; synthesizable = Boolean.TRUE;
break;
} }
Class<?> returnType = attribute.getReturnType(); Class<?> returnType = attribute.getReturnType();
@@ -1084,18 +1095,22 @@ public abstract class AnnotationUtils {
if (Annotation[].class.isAssignableFrom(returnType)) { if (Annotation[].class.isAssignableFrom(returnType)) {
Class<? extends Annotation> nestedAnnotationType = (Class<? extends Annotation>) returnType.getComponentType(); Class<? extends Annotation> nestedAnnotationType = (Class<? extends Annotation>) returnType.getComponentType();
if (isSynthesizable(nestedAnnotationType)) { if (isSynthesizable(nestedAnnotationType)) {
return true; synthesizable = Boolean.TRUE;
break;
} }
} }
else if (Annotation.class.isAssignableFrom(returnType)) { else if (Annotation.class.isAssignableFrom(returnType)) {
Class<? extends Annotation> nestedAnnotationType = (Class<? extends Annotation>) returnType; Class<? extends Annotation> nestedAnnotationType = (Class<? extends Annotation>) returnType;
if (isSynthesizable(nestedAnnotationType)) { if (isSynthesizable(nestedAnnotationType)) {
return true; synthesizable = Boolean.TRUE;
break;
} }
} }
} }
return false; synthesizableCache.put(annotationType, synthesizable);
return synthesizable.booleanValue();
} }
/** /**